RE: [PATCH v3] ath10k: support NET_DETECT WoWLAN feature

2019-09-19 Thread Wen Gong
> -Original Message- > From: ath10k On Behalf Of Kalle Valo > Sent: Wednesday, September 18, 2019 10:03 PM > To: Brian Norris > Cc: linux-wireless ; Linux Kernel ker...@vger.kernel.org>; ath10k@lists.infradead.org; Wen Gong > > Subject: [EXT] Re: [PATCH v3] ath10k: support NET_DETECT

[PATCH] ath10k: fix memory leak

2019-09-19 Thread Navid Emamdoost
In ath10k_usb_hif_tx_sg the allocated urb should be released if usb_submit_urb fails. Signed-off-by: Navid Emamdoost --- drivers/net/wireless/ath/ath10k/usb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/ath/ath10k/usb.c b/drivers/net/wireless/ath/ath10k/usb.c index

Re: [PATCH v3] ath10k: support NET_DETECT WoWLAN feature

2019-09-19 Thread Brian Norris
(I realize I replied to the v3, not the v4 which was merged.) On Wed, Sep 18, 2019 at 7:03 AM Kalle Valo wrote: > Brian Norris writes: > > Since Wen has once again suggested I use this patch in other forums, > > I'll ping here to note: > > > > On Wed, Nov 14, 2018 at 2:59 PM Brian Norris > >

Re: [PATCH 2/4] mac80211: defer txqs removal from rbtree

2019-09-19 Thread Toke Høiland-Jørgensen
Yibo Zhao writes: > On 2019-09-18 19:23, Toke Høiland-Jørgensen wrote: >> Yibo Zhao writes: >> >>> On 2019-09-18 05:10, Toke Høiland-Jørgensen wrote: Yibo Zhao writes: > In a loop txqs dequeue scenario, if the first txq in the rbtree gets > removed from rbtree immediately

Re: [PATCH 2/4] mac80211: defer txqs removal from rbtree

2019-09-19 Thread Yibo Zhao
On 2019-09-18 19:23, Toke Høiland-Jørgensen wrote: Yibo Zhao writes: On 2019-09-18 05:10, Toke Høiland-Jørgensen wrote: Yibo Zhao writes: In a loop txqs dequeue scenario, if the first txq in the rbtree gets removed from rbtree immediately in the ieee80211_return_txq(), the loop will break

Re: [PATCH v4 3/3] ath10k: add support for controlling tx power to a station

2019-09-19 Thread Balaji Pothunoori
On 2019-09-19 05:51, Bob Copeland wrote: On Wed, Sep 18, 2019 at 04:41:54PM +0300, Kalle Valo wrote: Bob Copeland writes: > - on A, changed the global tx power limit to 1 dBm > -> result: signal level dropped to ~ -95 dBm > > Reading the description above, now I'm wondering if the txpower is