[net-next PATCH 2/4] netdev: make napi_schedule return bool on NAPI successful schedule

2023-10-02 Thread Christian Marangi
Change napi_schedule to return a bool on NAPI successful schedule. This might be useful for some driver to do additional step after a NAPI ahs been scheduled. Signed-off-by: Christian Marangi --- include/linux/netdevice.h | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --

[net-next PATCH 1/4] netdev: replace simple napi_schedule_prep/__napi_schedule to napi_schedule

2023-10-02 Thread Christian Marangi
Replace drivers that still use napi_schedule_prep/__napi_schedule with napi_schedule helper as it does the same exact check and call. Signed-off-by: Christian Marangi --- drivers/net/ethernet/ni/nixge.c | 3 +-- drivers/net/ethernet/wiznet/w5100.c | 4 ++-- 2 files changed, 3 insertions(+),

[net-next PATCH 4/4] netdev: use napi_schedule bool instead of napi_schedule_prep/__napi_schedule

2023-10-02 Thread Christian Marangi
Replace if condition of napi_schedule_prep/__napi_schedule and use bool from napi_schedule directly where possible. Signed-off-by: Christian Marangi --- drivers/net/ethernet/atheros/atlx/atl1.c | 4 +--- drivers/net/ethernet/toshiba/tc35815.c | 4 +--- drivers/net/wireless/intel/iwlwif

[net-next PATCH 3/4] netdev: replace napi_reschedule with napi_schedule

2023-10-02 Thread Christian Marangi
Now that napi_schedule return a bool, we can drop napi_reschedule that does the same exact function. The function comes from a very old commit bfe13f54f502 ("ibm_emac: Convert to use napi_struct independent of struct net_device") and the purpose is actually deprecated in favour of different logic.

Re: [net-next PATCH 2/4] netdev: make napi_schedule return bool on NAPI successful schedule

2023-10-02 Thread Jeff Johnson
On 10/2/2023 8:10 AM, Christian Marangi wrote: Change napi_schedule to return a bool on NAPI successful schedule. This might be useful for some driver to do additional step after a NAPI ahs nit:s/ahs/has/ been scheduled. Signed-off-by: Christian Marangi --- include/linux/netdevice.h | 11

Re: [net-next PATCH 3/4] netdev: replace napi_reschedule with napi_schedule

2023-10-02 Thread Jeff Johnson
On 10/2/2023 8:10 AM, Christian Marangi wrote: Now that napi_schedule return a bool, we can drop napi_reschedule that does the same exact function. The function comes from a very old commit bfe13f54f502 ("ibm_emac: Convert to use napi_struct independent of struct net_device") and the purpose is a

Re: [PATCH] [v2] wifi: ath10k: consistently use kstrtoX_from_user() functions

2023-10-02 Thread Kalle Valo
Dmitry Antipov wrote: > Use 'kstrtoul_from_user()', 'kstrtobool_from_user()' and > 'kstrtoint_from_user()' where appropriate and thus avoid > some code duplication. > > Signed-off-by: Dmitry Antipov > Acked-by: Jeff Johnson > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.

Re: [PATCH] ath10k: Don't touch the CE interrupt registers after power up

2023-10-02 Thread Kalle Valo
Douglas Anderson wrote: > As talked about in commit d66d24ac300c ("ath10k: Keep track of which > interrupts fired, don't poll them"), if we access the copy engine > register at a bad time then ath10k can go boom. However, it's not > necessarily easy to know when it's safe to access them. > > The

Re: [PATCH] wifi: ath10k: indicate to mac80211 scan complete with aborted flag for ATH10K_SCAN_STARTING state

2023-10-02 Thread Kalle Valo
Wen Gong wrote: > Scan failure can not be recovered from when running a loop of the > following steps: > 1. run scan: "iw wlan scan". > 2. run command: echo soft > > /sys/kernel/debug/ieee80211/phy0/ath10k/simulate_fw_crash >immediately after step 1. > > result: > scan failed and can not re

Re: [net-next PATCH 3/4] netdev: replace napi_reschedule with napi_schedule

2023-10-02 Thread Nick Child
On 10/2/23 10:10, Christian Marangi wrote: Now that napi_schedule return a bool, we can drop napi_reschedule that does the same exact function. The function comes from a very old commit bfe13f54f502 ("ibm_emac: Convert to use napi_struct independent of struct net_device") and the purpose is ac

Re: [net-next PATCH 1/4] netdev: replace simple napi_schedule_prep/__napi_schedule to napi_schedule

2023-10-02 Thread Jakub Kicinski
On Mon, 2 Oct 2023 17:10:20 +0200 Christian Marangi wrote: > queue_work(priv->xfer_wq, &priv->rx_work); > - else if (napi_schedule_prep(&priv->napi)) > - __napi_schedule(&priv->napi); > + else > + napi_schedule(&

Re: [net-next PATCH 2/4] netdev: make napi_schedule return bool on NAPI successful schedule

2023-10-02 Thread Eric Dumazet
On Mon, Oct 2, 2023 at 5:10 PM Christian Marangi wrote: > > Change napi_schedule to return a bool on NAPI successful schedule. This > might be useful for some driver to do additional step after a NAPI ahs This might be useful for some drivers to do additional steps after a NAPI has been scheduled

[kvalo-ath:master-pending] BUILD SUCCESS 2b51b76a974aa20dc899859793e630a53c9cc21f

2023-10-02 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git master-pending branch HEAD: 2b51b76a974aa20dc899859793e630a53c9cc21f Merge branch 'pending' into master-pending elapsed time: 726m configs tested: 107 configs skipped: 2 The following configs have been built successful

[kvalo-ath:ath-next] BUILD SUCCESS d876188ab8074087b23b3d83a56c889ebb1904ae

2023-10-02 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git ath-next branch HEAD: d876188ab8074087b23b3d83a56c889ebb1904ae wifi: ath10k: indicate to mac80211 scan complete with aborted flag for ATH10K_SCAN_STARTING state elapsed time: 725m configs tested: 107 configs skipped: 2

[kvalo-ath:master] BUILD SUCCESS d531fe7422a4d02443d2ea15a84039a85c62f9d7

2023-10-02 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git master branch HEAD: d531fe7422a4d02443d2ea15a84039a85c62f9d7 Revert "PCI: Release resource invalidated by coalescing" elapsed time: 726m configs tested: 107 configs skipped: 2 The following configs have been built succ