Re: (subset) [PATCH v3 0/3] Work around missing MSA_READY indicator for msm8998 devices

2024-05-28 Thread Bjorn Andersson
rmware feature bit. > - Warn if the "no_msa_ready_indicator" property is true, > but we actually receive the indicator. > > [...] Applied, thanks! [3/3] arm64: dts: qcom: msm8998: set qcom,no-msa-ready-indicator for wifi commit: 737abcabe97bb37e38be2504acd28ad779dbaf3d Best regards, -- Bjorn Andersson

Re: [PATCH v3 2/3] wifi: ath10k: do not always wait for MSA_READY indicator

2024-04-29 Thread Bjorn Andersson
n't a strong > argument for changing the default behavior. > > Signed-off-by: Pierre-Hugues Husson > Signed-off-by: Marc Gonzalez As with patch 1, please address the s-o-b and accept my: Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > drivers/net/wireless/ath/ath10k

Re: [PATCH v3 1/3] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop

2024-04-29 Thread Bjorn Andersson
s that the two of you jointly came up with this and both certify the origin. Other than that, I think this looks good, so please upon addressing this problem feel free to add my: Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > Documentation/devicetree/bindings/net/wireless/qcom,at

Re: [PATCH v3 0/3] Work around missing MSA_READY indicator for msm8998 devices

2024-04-29 Thread Bjorn Andersson
On Tue, Apr 30, 2024 at 12:24:40AM +0100, Bryan O'Donoghue wrote: > On 29/04/2024 15:01, Marc Gonzalez wrote: > > Work around missing MSA_READY indicator in ath10k driver > > (apply work-around for all msm8998 devices) > > > > CHANGELOG v3 > > - Add a paragraph in binding commit to explain why we

Re: (subset) [PATCH RFC v2 0/4] wifi: ath10k: support board-specific firmware overrides

2024-04-22 Thread Bjorn Andersson
ware-name qualifier to WiFi node commit: 57ce4b27a12c827a24aaa18aa444bcb8733cb053 [4/4] arm64: dts: qcom: qrb4210-rb1: add firmware-name qualifier to WiFi node commit: 673b174b5b2ca2fb99fe52bf7bad3cc348432170 Best regards, -- Bjorn Andersson

Re: [PATCH] arm64: dts: qcom: sm8150-hdk: enable WiFI support

2024-04-04 Thread Bjorn Andersson
th10k_snoc 1880.wifi: htt-ver 3.73 wmi-op 4 htt-op 3 cal file max-sta 32 > raw 0 hwcrypto 1 > ath10k_snoc 1880.wifi: invalid MAC address; choosing random > > [...] Applied, thanks! [1/1] arm64: dts: qcom: sm8150-hdk: enable WiFI support commit: e5fd6512f6e842d8c5883b9fa4d72c8a5295efdc Best regards, -- Bjorn Andersson

Re: (subset) [PATCH v3 0/2] ATH10K YAML conversion

2023-04-07 Thread Bjorn Andersson
rivial issue. Patch 2 unchanged. > > [...] Applied, thanks! [2/2] arm64: dts: qcom: sdm845-polaris: Drop inexistent properties commit: fbc3a1df2866608ca43e7e6d602f66208a5afd88 Best regards, -- Bjorn Andersson ___ ath10k mailing list ath1

Re: [PATCH] firmware: qcom_scm: Use fixed width src vm bitmap

2023-03-15 Thread Bjorn Andersson
] firmware: qcom_scm: Use fixed width src vm bitmap commit: 968a26a07f75377afbd4f7bb18ef587a1443c244 Best regards, -- Bjorn Andersson ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k

Re: (subset) [PATCH v9 17/27] firmware: qcom_scm: Use fixed width src vm bitmap

2023-03-15 Thread Bjorn Andersson
] firmware: qcom_scm: Use fixed width src vm bitmap commit: 968a26a07f75377afbd4f7bb18ef587a1443c244 Best regards, -- Bjorn Andersson ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k

Re: [PATCH] firmware: qcom_scm: Use fixed width src vm bitmap

2023-03-14 Thread Bjorn Andersson
On Fri, Mar 03, 2023 at 01:09:08PM -0800, Elliot Berman wrote: > > > On 2/14/2023 10:52 AM, Elliot Berman wrote: > > > > > > On 2/14/2023 9:23 AM, Bjorn Andersson wrote: > > > On Tue, Feb 14, 2023 at 09:58:44AM +0100, Greg Kroah-Hartman wrote: > > &g

Re: [PATCH] firmware: qcom_scm: Use fixed width src vm bitmap

2023-02-14 Thread Bjorn Andersson
On Tue, Feb 14, 2023 at 09:58:44AM +0100, Greg Kroah-Hartman wrote: > On Mon, Feb 13, 2023 at 01:44:17PM -0800, Bjorn Andersson wrote: > > On Mon, Feb 13, 2023 at 10:18:29AM -0800, Elliot Berman wrote: > > > The maximum VMID for assign_mem is 63. Use a u64 to represent this &g

Re: [PATCH] firmware: qcom_scm: Use fixed width src vm bitmap

2023-02-13 Thread Bjorn Andersson
e Valo (ath10k) > Tested-by: Gokul krishna Krishnakumar > Signed-off-by: Elliot Berman Reviewed-by: Bjorn Andersson @Greg, would you mind taking this through your tree for v6.3, you already have a related change in fastrpc.c in your tree... Regards, Bjorn > --- > driver

Re: [PATCH] firmware: qcom_scm: Move qcom_scm.h to include/linux/firmware/qcom/

2023-02-08 Thread Bjorn Andersson
mware: qcom_scm: Move qcom_scm.h to include/linux/firmware/qcom/ commit: 3bf90eca76c98c55c975fa817799789b9176f9f3 Best regards, -- Bjorn Andersson ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k

Re: [PATCH 2/2] [v2] qcom_scm: hide Kconfig symbol

2021-09-29 Thread Bjorn Andersson
On Tue 28 Sep 02:50 CDT 2021, Arnd Bergmann wrote: > From: Arnd Bergmann > > Now that SCM can be a loadable module, we have to add another > dependency to avoid link failures when ipa or adreno-gpu are > built-in: > > aarch64-linux-ld: drivers/net/ipa/ipa_main.o: in function `ipa_probe': >

Re: [PATCH] [RFC] qcom_scm: hide Kconfig symbol

2021-09-29 Thread Bjorn Andersson
On Wed 29 Sep 05:04 CDT 2021, Arnd Bergmann wrote: > On Wed, Sep 29, 2021 at 11:51 AM Will Deacon wrote: > > On Mon, Sep 27, 2021 at 05:22:13PM +0200, Arnd Bergmann wrote: > > > > > > diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig > > > index 124c41adeca1..989c83acbfee 100644 > > >

Re: [PATCH] [RFC] qcom_scm: hide Kconfig symbol

2021-09-27 Thread Bjorn Andersson
On Mon 27 Sep 13:15 PDT 2021, Arnd Bergmann wrote: > On Mon, Sep 27, 2021 at 9:52 PM Bjorn Andersson > wrote: > > On Mon 27 Sep 08:22 PDT 2021, Arnd Bergmann wrote: > > > From: Arnd Bergmann > > > > > > - To avoid a circular depe

Re: [PATCH] [RFC] qcom_scm: hide Kconfig symbol

2021-09-27 Thread Bjorn Andersson
On Mon 27 Sep 08:22 PDT 2021, Arnd Bergmann wrote: > From: Arnd Bergmann > > Now that SCM can be a loadable module, we have to add another > dependency to avoid link failures when ipa or adreno-gpu are > built-in: > > aarch64-linux-ld: drivers/net/ipa/ipa_main.o: in function `ipa_probe': >

Re: [RFC PATCH 00/15] create power sequencing subsystem

2021-08-20 Thread Bjorn Andersson
On Fri 20 Aug 06:08 PDT 2021, Dmitry Baryshkov wrote: > Hi, > > On Thu, 19 Aug 2021 at 18:23, Marcel Holtmann wrote: > > > This is an RFC of the proposed power sequencer subsystem. This is a > > > generification of the MMC pwrseq code. The subsystem tries to abstract > > > the idea of complex

Re: [RFC PATCH 10/15] pwrseq: add support for QCA BT+WiFi power sequencer

2021-08-20 Thread Bjorn Andersson
On Fri 20 Aug 01:10 PDT 2021, Dmitry Baryshkov wrote: > Hi, > > On Fri, 20 Aug 2021 at 02:17, Bjorn Andersson > wrote: > > > > On Mon 16 Aug 17:55 PDT 2021, Dmitry Baryshkov wrote: > > [..] > > > diff --git a/drivers/power/pwrseq/pwrseq_qca.c > > &g

Re: [RFC PATCH 11/15] arm64: dts: qcom: sdm845-db845c: switch bt+wifi to qca power sequencer

2021-08-19 Thread Bjorn Andersson
On Mon 16 Aug 17:55 PDT 2021, Dmitry Baryshkov wrote: > Switch sdm845-db845c device tree to use new power sequencer driver > rather than separate regulators. > LGTM! > Signed-off-by: Dmitry Baryshkov > --- > arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 21 ++--- >

Re: [RFC PATCH 01/15] power: add power sequencer subsystem

2021-08-19 Thread Bjorn Andersson
On Mon 16 Aug 17:54 PDT 2021, Dmitry Baryshkov wrote: > Basing on MMC's pwrseq support code, add separate power sequencer > subsystem. It will be used by other drivers to handle device power up > requirements. > Some more background to why we need a pwrseq framework wouldn't hurt. [..] > diff

Re: [RFC PATCH 10/15] pwrseq: add support for QCA BT+WiFi power sequencer

2021-08-19 Thread Bjorn Andersson
On Mon 16 Aug 17:55 PDT 2021, Dmitry Baryshkov wrote: [..] > diff --git a/drivers/power/pwrseq/pwrseq_qca.c > b/drivers/power/pwrseq/pwrseq_qca.c > new file mode 100644 > index ..3421a4821126 > --- /dev/null > +++ b/drivers/power/pwrseq/pwrseq_qca.c > @@ -0,0 +1,290 @@ > +//

Re: [PATCH] ath10k: Introduce a devicetree quirk to skip host cap QMI requests

2021-02-08 Thread Bjorn Andersson
On Mon 08 Feb 11:21 CST 2021, Kalle Valo wrote: > Amit Pundir writes: > > > Hi Kalle, > > > > On Mon, 7 Dec 2020 at 22:25, Kalle Valo wrote: > >> > >> This is firmware version specific, right? There's also enum > >> ath10k_fw_features which is embedded within firmware-N.bin, we could add > >>

Re: [PATCH] ath10k: Introduce a devicetree quirk to skip host cap QMI requests

2020-11-24 Thread Bjorn Andersson
On Tue 03 Nov 01:48 CST 2020, Amit Pundir wrote: > Hi Rob, Bjorn, Kalle, > > On Thu, 29 Oct 2020 at 19:10, Bjorn Andersson > wrote: > > > > On Tue 29 Sep 14:08 CDT 2020, Rob Herring wrote: > > > > > On Fri, Sep 25, 2020 at 11:59:41PM +0530, Amit Pundir wro

Re: [PATCH v2] ath10k: qmi: Skip host capability request for Xiaomi Poco F1

2020-11-24 Thread Bjorn Andersson
On Mon 23 Nov 04:28 CST 2020, Amit Pundir wrote: > Workaround to get WiFi working on Xiaomi Poco F1 (sdm845) > phone. We get a non-fatal QMI_ERR_MALFORMED_MSG_V01 error > message in ath10k_qmi_host_cap_send_sync(), but we can still > bring up WiFi services successfully on AOSP if we ignore it. >

Re: [PATCH] ath10k: Introduce a devicetree quirk to skip host cap QMI requests

2020-10-29 Thread Bjorn Andersson
On Tue 29 Sep 14:08 CDT 2020, Rob Herring wrote: > On Fri, Sep 25, 2020 at 11:59:41PM +0530, Amit Pundir wrote: > > There are firmware versions which do not support host capability > > QMI request. We suspect either the host cap is not implemented or > > there may be firmware specific issues, but

Re: [PATCH] ath10k: Introduce a devicetree quirk to skip host cap QMI requests

2020-09-25 Thread Bjorn Andersson
QMI request for the firmware versions which do not support this > feature. > > Suggested-by: Bjorn Andersson > Signed-off-by: Amit Pundir > --- > .../devicetree/bindings/net/wireless/qcom,ath10k.txt| 5 + > drivers/net/wireless/ath/ath10k/qmi.c

Re: [PATCH] ath10k: qmi: Skip host capability request for Xiaomi Poco F1

2020-09-25 Thread Bjorn Andersson
On Thu 24 Sep 11:31 CDT 2020, Kalle Valo wrote: > Amit Pundir writes: > > > Workaround to get WiFi working on Xiaomi Poco F1 (sdm845) > > phone. We get a non-fatal QMI_ERR_MALFORMED_MSG_V01 error > > message in ath10k_qmi_host_cap_send_sync(), but we can still > > bring up WiFi services

Re: [PATCH] ath10k: qmi: Skip host capability request for Xiaomi Poco F1

2020-09-25 Thread Bjorn Andersson
On Mon 21 Sep 05:38 CDT 2020, Amit Pundir wrote: > On Thu, 17 Sep 2020 at 21:35, Bjorn Andersson > wrote: > > > > On Thu 17 Sep 02:41 CDT 2020, Amit Pundir wrote: > > > > > Workaround to get WiFi working on Xiaomi Poco F1 (sdm845) > > > phone. We get a

Re: [PATCH] ath10k: qmi: Skip host capability request for Xiaomi Poco F1

2020-09-17 Thread Bjorn Andersson
On Thu 17 Sep 02:41 CDT 2020, Amit Pundir wrote: > Workaround to get WiFi working on Xiaomi Poco F1 (sdm845) > phone. We get a non-fatal QMI_ERR_MALFORMED_MSG_V01 error > message in ath10k_qmi_host_cap_send_sync(), but we can still > bring up WiFi services successfully on AOSP if we ignore it. >

Re: [PATCH] soc: qmi: allow user to set handle wq to hiprio

2020-07-27 Thread Bjorn Andersson
On Mon 27 Jul 08:03 PDT 2020, ? wrote: > Currently the qmi_handle is initialized single threaded and strictly > ordered with the active set to 1. This is pretty simple and safe but > sometimes ineffency. So it is better to allow user to decide whether > a high priority workqueue should be

Re: [PATCH 0/2] ath10k: Enable QDSS clock on sm8150

2020-01-27 Thread Bjorn Andersson
On Mon 27 Jan 10:40 PST 2020, Stephen Boyd wrote: > Quoting Bjorn Andersson (2019-12-22 21:48:53) > > On SM8150 the WiFi firmware depends on the QDSS clock ticking, or the system > > will reset due to an NoC error. So this adds an optional clock to the ath10k > > bindin

Re: [PATCH 0/2] ath10k: Enable QDSS clock on sm8150

2020-01-15 Thread Bjorn Andersson
On Wed 15 Jan 01:04 PST 2020, Kalle Valo wrote: > Kalle Valo writes: > > > Bjorn Andersson writes: > > > >> On SM8150 the WiFi firmware depends on the QDSS clock ticking, or the > >> system > >> will reset due to an NoC error. So this adds an op

[PATCH 2/2] arm64: dts: qcom: sm8150: Specify qdss clock for wifi

2019-12-22 Thread Bjorn Andersson
The WiFi firmware on SM8150 requires the QDSS clock to be ticking, so specify this clock for the wifi node. Signed-off-by: Bjorn Andersson --- arch/arm64/boot/dts/qcom/sm8150.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b

[PATCH 0/2] ath10k: Enable QDSS clock on sm8150

2019-12-22 Thread Bjorn Andersson
On SM8150 the WiFi firmware depends on the QDSS clock ticking, or the system will reset due to an NoC error. So this adds an optional clock to the ath10k binding and makes sure it's enabled while the WiFi firmware needs it. Bjorn Andersson (2): ath10k: Add optional qdss clk arm64: dts: qcom

[PATCH 1/2] ath10k: Add optional qdss clk

2019-12-22 Thread Bjorn Andersson
The WiFi firmware found on sm8150 requires that the QDSS clock is ticking in order to operate, so add an optional clock to the binding to allow this to be specified in the sm8150 dts and add the clock to the list of clocks in the driver. Signed-off-by: Bjorn Andersson --- Documentation

[PATCH] ath10k: qmi: Sleep for a while before assigning MSA memory

2019-11-13 Thread Bjorn Andersson
Unless we sleep for a while before transitioning the MSA memory to WLAN the MPSS.AT.4.0.c2-01184-SDM845_GEN_PACK-1 firmware triggers a security violation fairly reliably. Unforutnately recovering from this failure always results in the entire system freezing. Signed-off-by: Bjorn Andersson

Re: [PATCH] ath10k: Handle when FW doesn't support QMI_WLFW_HOST_CAP_REQ_V01

2019-11-13 Thread Bjorn Andersson
is not fatal to the firmware nor the ath10k driver, lets catch > this particular scenario and ignore it so that we can still bring up > wifi services successfully. > Reviewed-by: Bjorn Andersson > Signed-off-by: Jeffrey Hugo > --- > drivers/net/wireless/ath/ath10k/qmi.c

[PATCH] ath10k: Revert "ath10k: add cleanup in ath10k_sta_state()"

2019-11-13 Thread Bjorn Andersson
ing commit for now. This reverts commit 334f5b61a6f29834e881923b98d1e27e5ce9620d. Signed-off-by: Bjorn Andersson --- drivers/net/wireless/ath/ath10k/mac.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/m

Re: [PATCH] ath10k: add cleanup in ath10k_sta_state()

2019-11-13 Thread Bjorn Andersson
On Thu 15 Aug 14:04 PDT 2019, Wenwen Wang wrote: > If 'sta->tdls' is false, no cleanup is executed, leading to memory/resource > leaks, e.g., 'arsta->tx_stats'. To fix this issue, perform cleanup before > go to the 'exit' label. > Unfortunately this patch consistently crashes all my msm8998,

Re: [PATCH] ath10k: Handle "invalid" BDFs for msm8998 devices

2019-11-12 Thread Bjorn Andersson
ut; > + if (!(req->end == 1 && > + resp.resp.result == QMI_ERR_MALFORMED_MSG_V01)) { Perhaps worth adding a comment in the code as well, to describe what scenario this relates to? Reviewed-by: Bjorn Ander

[PATCH v2] ath10k: Correct error handling of dma_map_single()

2019-10-11 Thread Bjorn Andersson
The return value of dma_map_single() should be checked for errors using dma_mapping_error() and the skb has been dequeued so it needs to be freed. Fixes: 1807da49733e ("ath10k: wmi: add management tx by reference support over wmi") Reported-by: Niklas Cassel Signed-off-by: Bjorn

Re: [PATCH] ath10k: Correct error check of dma_map_single()

2019-10-11 Thread Bjorn Andersson
On Fri 11 Oct 04:57 PDT 2019, Kalle Valo wrote: > Bjorn Andersson wrote: > > > The return value of dma_map_single() should be checked for errors using > > dma_mapping_error(), rather than testing for NULL. Correct this. > > > > Fixes: 1807da49733e ("ath10k:

[PATCH] ath10k: Correct error check of dma_map_single()

2019-10-10 Thread Bjorn Andersson
Signed-off-by: Bjorn Andersson --- drivers/net/wireless/ath/ath10k/mac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c index 3d2c8fcba952..a01868938692 100644 --- a/drivers/net/wireless/ath/ath10k/mac.c +++

Re: [PATCH 0/3] ath10k: Clean up regulator and clock handling

2019-08-05 Thread Bjorn Andersson
On Thu 25 Jul 23:52 PDT 2019, Govind Singh wrote: > On 2019-07-25 23:17, Bjorn Andersson wrote: > > The first patch in this series removes the regulator_set_voltage() of a > > fixed > > voltate, as fixed regulator constraints should be specified on a board > > leve

[PATCH 2/3] ath10k: Use standard regulator bulk API in snoc

2019-07-25 Thread Bjorn Andersson
bulk API provided by the regulator framework, so use these instead of rolling our own. Signed-off-by: Bjorn Andersson --- drivers/net/wireless/ath/ath10k/snoc.c | 184 - drivers/net/wireless/ath/ath10k/snoc.h | 13 +- 2 files changed, 27 insertions(+), 170 deletions

[PATCH 0/3] ath10k: Clean up regulator and clock handling

2019-07-25 Thread Bjorn Andersson
two patches cleans up regulator and clock usage by using the bulk API provided by the two frameworks. Bjorn Andersson (3): ath10k: snoc: skip regulator operations ath10k: Use standard regulator bulk API in snoc ath10k: Use standard bulk clock API in snoc drivers/net/wireless/ath/ath10k

[PATCH 3/3] ath10k: Use standard bulk clock API in snoc

2019-07-25 Thread Bjorn Andersson
to be reconsidered in the future. Signed-off-by: Bjorn Andersson --- drivers/net/wireless/ath/ath10k/snoc.c | 125 - drivers/net/wireless/ath/ath10k/snoc.h | 11 +-- 2 files changed, 21 insertions(+), 115 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/snoc.c b

[PATCH 1/3] ath10k: snoc: skip regulator operations

2019-07-25 Thread Bjorn Andersson
voltage requirements should just rely on the board configuration to provide the power at the required level, so this code should be removed. Signed-off-by: Bjorn Andersson --- This patch is required for Lenovo Yoga C630 to succeed in power on ath10k, it can be merged independently of the two

[PATCH] ath10k: Fix HOST capability QMI incompatibility

2019-07-25 Thread Bjorn Andersson
oduced in DeviceTree to indicate to the driver that the firmware requires the 8bit version of this message. Cc: sta...@vger.kernel.org Fixes: 768ec4c012ac ("ath10k: update HOST capability qmi message") Signed-off-by: Bjorn Andersson --- .../bindings/net/wireless/qcom,ath10k.txt | 6 +

Re: [PATCH 2/3] ath10k: Move regulator config to driver private data

2019-07-22 Thread Bjorn Andersson
On Tue 02 Jul 20:57 PDT 2019, Govind Singh wrote: > WCN3990 Regulator config is varying b/w different MSM platforms. > In order to have scalable config, move regulator config to driver > private data. > Regulators supplying clients with fixed voltage requirements should be specified in the

Re: [PATCH v2 1/1] ath10k: update HOST capability qmi message

2019-05-21 Thread Bjorn Andersson
On Mon 04 Feb 03:55 PST 2019, Govind Singh wrote: > HOST capability interface data structures are updated > in HL3.1 fw version. Update the qmi host capability > members for compatibility across different firmware > versions. > Since this change breaks backward compatibility with > HL2.0 fw,

Re: [PATCH v2] ath10k: Set DMA address mask to 35 bit for WCN3990

2019-01-31 Thread Bjorn Andersson
On Thu 31 Jan 05:51 PST 2019, Kalle Valo wrote: > Bjorn Andersson writes: > > > On Mon 03 Sep 09:37 PDT 2018, Rakesh Pillai wrote: > > > >> WCN3990 is a 37-bit target but can address memory range > >> only upto 35 bits. The 36th bit is used to con

Re: [PATCH v2] ath10k: Set DMA address mask to 35 bit for WCN3990

2019-01-30 Thread Bjorn Andersson
> > Tested HW: WCN3990 > Tested FW: WLAN.HL.2.0-01188-QCAHLSWMTPLZ-1 > > Signed-off-by: Rakesh Pillai This solves the problem I'm seeing on my SDM845, where I see a translation fault on a 32-bit address from the IOMMU, which we previously mapped the 36 bit version of (my dma-r

Re: [PATCH for-5.0] ath10k: correct bus type for WCN3990

2019-01-29 Thread Bjorn Andersson
On Tue 29 Jan 15:12 PST 2019, Brian Norris wrote: > WCN3990 is SNOC, not PCI. This prevents probing WCN3990. > > Fixes: 367c899f622c ("ath10k: add bus type check in ath10k_init_hw_params") > Signed-off-by: Brian Norris Reviewed-by: Bjorn Andersson > --- > T

Re: [PATCH v5 3/6] dt: bindings: add bindings for msa memory region

2018-10-09 Thread Bjorn Andersson
On Wed 15 Aug 02:26 PDT 2018, Govind Singh wrote: > Add device tree binding documentation details of msa > memory region for ath10k qmi client for SDM845/APQ8098 > SoC into "qcom,ath10k.txt". > Reviewed-by: Bjorn Andersson Regards, Bjorn > Signed-off-by: Govind Singh

Re: [PATCH v5 6/6] ath10k: Add QMI message handshake for wcn3990 client

2018-10-09 Thread Bjorn Andersson
M Interface(QMI) is a messaging format used to communicate > between components running between remote processors with underlying > transport layer based on integrated chipset(shared memory) or > discrete chipset(PCI/USB/SDIO/UART). > Reviewed-by: Bjorn Andersson Regards, Bjorn &g

Re: [PATCH v5 1/6] ath10k: Add qmi service helpers for wcn3990 qmi client

2018-10-09 Thread Bjorn Andersson
On Wed 15 Aug 02:26 PDT 2018, Govind Singh wrote: > WLAN qmi server running in Q6 exposes host to target > cold boot qmi handshakes. Add WLAN QMI service helpers > for ath10k wcn3990 qmi client. > Reviewed-by: Bjorn Andersson Regards, Bjorn > Signed-off-by: Govind Singh &

Re: [PATCH v5 4/6] firmware: qcom: scm: Add WLAN VMID for Qualcomm SCM interface

2018-10-09 Thread Bjorn Andersson
On Wed 15 Aug 02:26 PDT 2018, Govind Singh wrote: > Add WLAN related VMID's to support wlan driver to set up > the remote's permissions call via TrustZone. > Reviewed-by: Bjorn Andersson Regards, Bjorn > Signed-off-by: Govind Singh > --- > include/linux/qcom_scm.h

Re: [PATCH v3 0/6] *** Add support for wifi QMI client handshakes ***

2018-07-10 Thread Bjorn Andersson
On Tue 10 Jul 18:26 PDT 2018, Brian Norris wrote: > Hi, > Hi Brian, > On Fri, Jul 06, 2018 at 02:26:17PM +0530, Govind Singh wrote: [..] > > https://github.com/andersson/tqftpserv > > FWIW, as of today, the tqftpserv implementation is missing a few headers > (so it doesn't even build), Sorry

Re: [PATCH 11/12] ath10k: Add wlan mode on/off qmi message

2018-05-11 Thread Bjorn Andersson
On Sun 25 Mar 22:41 PDT 2018, Govind Singh wrote: > Add qmi message required for enabling and disabling > target to qmi server running in Q6. > > Signed-off-by: Govind Singh > --- > drivers/net/wireless/ath/ath10k/qmi.c | 226 > +- >

Re: [PATCH 10/12] ath10k: add bdf/cal indication support

2018-05-11 Thread Bjorn Andersson
On Sun 25 Mar 22:41 PDT 2018, Govind Singh wrote: > Add support for bdf download and cold boot > calibration trigger qmi message support. > > Signed-off-by: Govind Singh > --- > drivers/net/wireless/ath/ath10k/qmi.c | 195 > ++ >

Re: [PATCH 09/12] ath10k: Add QMI HOST CAP request support

2018-05-11 Thread Bjorn Andersson
On Sun 25 Mar 22:41 PDT 2018, Govind Singh wrote: > Add support for host capablity request > qmi message for wcn3990 target. > > Signed-off-by: Govind Singh > --- > drivers/net/wireless/ath/ath10k/qmi.c | 65 > +++ > 1 file changed, 65

Re: [PATCH 08/12] ath10k: Add QMI CAP request support

2018-05-11 Thread Bjorn Andersson
On Sun 25 Mar 22:40 PDT 2018, Govind Singh wrote: > Add support for target capablity request > qmi message for wcn3990 target. > > Signed-off-by: Govind Singh > --- > drivers/net/wireless/ath/ath10k/qmi.c | 91 > +++ >

Re: [PATCH 07/12] ath10k: Add MSA handshake QMI mgs support

2018-05-11 Thread Bjorn Andersson
On Sun 25 Mar 22:40 PDT 2018, Govind Singh wrote: > HOST allocates 2mb of region for modem and WCN3990 > secure access and provides the address and access > control to target for secure access. > Add MSA handshake request/response messages. > > Signed-off-by: Govind Singh

Re: [PATCH 05/12] ath10k: Add support of QMI indication message

2018-05-11 Thread Bjorn Andersson
On Sun 25 Mar 22:40 PDT 2018, Govind Singh wrote: > Add support of indication qmi message to communicate > with wlan qmi server. Indication message request > describes client capability and in response client > gets the state of wlan qmi service. > > Signed-off-by: Govind Singh

Re: [PATCH 04/12] ath10k: add support to start and stop qmi service

2018-05-11 Thread Bjorn Andersson
On Sun 25 Mar 22:39 PDT 2018, Govind Singh wrote: > Add support to start qmi service to configure the wlan > firmware component and register event notifier to communicate > with the WLAN firmware over qmi communication interface. > > Signed-off-by: Govind Singh > --- >

Re: [PATCH 03/12] ath10k: Add ath10k QMI client driver

2018-05-11 Thread Bjorn Andersson
On Sun 25 Mar 22:39 PDT 2018, Govind Singh wrote: > Add QMI client driver for Q6 integrated WLAN connectivity > subsystem. This module is responsible for communicating WLAN > control messages to FW over QUALCOMM MSM Interface (QMI). > > Signed-off-by: Govind Singh > ---

Re: [PATCH 02/12] dt: bindings: add bindings for ath10k qmi client

2018-05-11 Thread Bjorn Andersson
On Sun 25 Mar 22:39 PDT 2018, Govind Singh wrote: > Add device tree binding documentation details for ath10k > qmi client for SDM845/APQ8098 SoC into "qcom,ath10k.txt". > > Signed-off-by: Govind Singh > --- >

Re: [PATCH 01/12] ath10k: Add qmi service for wlan qmi client

2018-05-11 Thread Bjorn Andersson
On Sun 25 Mar 22:38 PDT 2018, Govind Singh wrote: > WLAN qmi server running in Q6 dsp exposes host > to target cold boot qmi handshake. > Add WLAN QMI service helpers for WLAN serivice. > > Signed-off-by: Govind Singh > --- >

Re: [PATCH v3 00/12] *** Add support for wifi QMI client driver ***

2018-05-08 Thread Bjorn Andersson
On Sun 25 Mar 22:37 PDT 2018, Govind Singh wrote: > Add QMI client driver for Q6 integrated WLAN connectivity subsystem. > This module is responsible for communicating WLAN control messages to FW > over QMI interface. > > “QUALCOMM Messaging Interface”(QMI) provides the control interface between

Re: [PATCH 06/12] firmware: qcom: scm: Add WLAN VMID for Qualcomm SCM interface

2018-05-07 Thread Bjorn Andersson
a hint about whom to send your patches to. While I think it's okay that Kalle picks it through his tree Andy should give his ack first. Acked-by: Bjorn Andersson <bjorn.anders...@linaro.org> Regards, Bjorn > --- > include/linux/qcom_scm.h | 4 +++- > 1 file changed, 3 insertions(