[PATCH] ath10k/ath11k: fix spelling mistake "requed" -> "requeued"

2021-04-23 Thread Colin King
From: Colin Ian King There are multiple occurrances of the misspelling of requeued in the drivers with symbol names and debug text. Fix these. Signed-off-by: Colin Ian King --- drivers/net/wireless/ath/ath10k/core.h | 2 +- drivers/net/wireless/ath/ath10k/debug.c | 4 +

[PATCH][next] ath10k: fix null dereference on pointer crash_data

2019-10-04 Thread Colin King
From: Colin Ian King Currently when pointer crash_data is null the present null check will also check that crash_data->ramdump_buf is null and will cause a null pointer dereference on crash_data. Fix this by using the || operator instead of &&. Fixes: 3f14b73c3843 ("ath10k: Enable MSA region dum

[PATCH] ath10k: fix spelling mistake "eanble" -> "enable"

2019-09-13 Thread Colin King
From: Colin Ian King There is a spelling mistake in a ath10k_warn warning message. Fix it. Signed-off-by: Colin Ian King --- drivers/net/wireless/ath/ath10k/mac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/a

[PATCH][next] ath: fix various spelling mistakes

2019-07-02 Thread Colin King
From: Colin Ian King There are a bunch of spelling mistakes in two ath drivers, fix these. Signed-off-by: Colin Ian King --- drivers/net/wireless/ath/ath10k/core.c | 2 +- drivers/net/wireless/ath/ath10k/mac.c | 2 +- drivers/net/wireless/ath/ath10k/qmi.c | 4 ++-- drivers/net/wireless/ath/w

[PATCH][ath10k-next] ath10k: fix some spelling mistakes

2018-10-18 Thread Colin King
From: Colin Ian King Trivial fix to some spelling mistakes in ath10k_err and ath10k_dbg messages: "capablity" -> "capability" "registed" -> "registered" Signed-off-by: Colin Ian King --- drivers/net/wireless/ath/ath10k/qmi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --g

[PATCH][next] ath10k: fix out of bound read on array ath10k_rates

2018-10-05 Thread Colin King
From: Colin Ian King An out-of-bounds read on array ath10k_rates is occurring because the maximum number of elements is currently based on the size of the array and not the number of elements in the array. Fix this by using ARRAY_SIZE instead of sizeof. Detected by CoverityScan, CID#1473918 ("Ou

[PATCH] ath10k: remove redundant pointers 'dev' and 'noa'

2018-07-09 Thread Colin King
From: Colin Ian King Pointers dev and noa are being assigned but are never used hence they are redundant and can be removed. Cleans up clang warnings: warning: variable 'dev' set but not used [-Wunused-but-set-variable] warning: variable 'noa' set but not used [-Wunused-but-set-variable] Signed

[PATCH] ath10k: fix memory leak of tpc_stats

2018-05-27 Thread Colin King
From: Colin Ian King Currently tpc_stats is allocated and is leaked on the return path if num_tx_chain is greater than WMI_TPC_TX_N_CHAIN. Avoid this leak by performing the check on num_tx_chain before the allocation of tpc_stats. Detected by CoverityScan, CID#1469422 ("Resource Leak") Fixes: 4b

[PATCH][next] ath10k: fix spelling mistake: "servive" -> "service"

2018-04-26 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake in ath10k_warn warning message text Signed-off-by: Colin Ian King --- drivers/net/wireless/ath/ath10k/wmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath

[PATCH] ath10k: fix spelling mistake: "tiggers" -> "triggers"

2018-03-29 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake in message text Signed-off-by: Colin Ian King --- drivers/net/wireless/ath/ath10k/wmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c index

[PATCH] ath10k: remove redundant -ve check against u32 integer size

2018-01-12 Thread Colin King
From: Colin Ian King Variable section_table.size is a u32 and so cannot be less than zero, hence the less than zero check is redundant and can be removed. Detected by CoverityScan, CID#1463855 ("Unsigned compared against 0") Signed-off-by: Colin Ian King --- drivers/net/wireless/ath/ath10k/pc

[PATCH][next] ath10k: fix spelling mistake: "addrress" -> "address"

2018-01-12 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake in warning message text. Signed-off-by: Colin Ian King --- drivers/net/wireless/ath/ath10k/pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci

[PATCH][next] ath10k: wmi: remove redundant integer fc

2017-12-18 Thread Colin King
From: Colin Ian King Variable fc is being assigned but never used, so remove it. Cleans up the clang warning: warning: Value stored to 'fc' is never read Signed-off-by: Colin Ian King --- drivers/net/wireless/ath/ath10k/wmi-tlv.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/ne

[PATCH][-next] ath10k: fix a bunch of spelling mistakes in messages

2017-06-25 Thread Colin King
From: Colin Ian King Fix the following spelling mistakes in messages: syncronise -> synchronize unusally -> unusually addrress -> address inverval -> interval Signed-off-by: Colin Ian King --- drivers/net/wireless/ath/ath10k/mac.c | 2 +- drivers/net/wireless/ath/ath10k/pci.c |

[PATCH] ath10k: remove redundant check of len with buf_len

2017-03-15 Thread Colin King
From: Colin Ian King The check of len > buf_len is redundant as len is initialized to 0 and buf_len to 4096, so this comparison is always false. Remove it. Signed-off-by: Colin Ian King --- drivers/net/wireless/ath/ath10k/debug.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/ne

[PATCH] ath10k: remove redundant error check

2017-02-28 Thread Colin King
From: Colin Ian King The check on ret for an error is redundant because it is already been checked for non-zero earlier on and ret is never non-zero at this point. Fix this by removing the redundant check and error message. Detected by CoverityScan, CID#1357170 ("Logically Dead Code") Signed-of

[PATCH][V2] ath10k: fix memory leak on caldata on error exit path

2016-09-03 Thread Colin King
From: Colin Ian King caldata is not being free'd on the error exit path, causing a memory leak and data definitely should not be freed. Free caldata instead of data. Thanks to Kalle Valo for spotting that data should not be free'd. Signed-off-by: Colin Ian King --- drivers/net/wireless/ath/at

[PATCH] ath10k: fix spelling mistake "montior" -> "monitor"

2016-08-26 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake in ath10k_warn message. Signed-off-by: Colin Ian King --- drivers/net/wireless/ath/ath10k/mac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.

[PATCH] ath10k: fix memory leak on caldata on error exit path

2016-08-15 Thread Colin King
From: Colin Ian King caldata is not being free'd on the error exit path, causing a memory leak. kfree it to fix the leak. Signed-off-by: Colin Ian King --- drivers/net/wireless/ath/ath10k/pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers