Re: [PATCH] ath10k: add cleanup in ath10k_sta_state()

2019-11-13 Thread Jeffrey Hugo
On Wed, Nov 13, 2019 at 12:28 PM Bjorn Andersson wrote: > > On Thu 15 Aug 14:04 PDT 2019, Wenwen Wang wrote: > > > If 'sta->tdls' is false, no cleanup is executed, leading to memory/resource > > leaks, e.g., 'arsta->tx_stats'. To fix this issue, perform cleanup before > > go to the 'exit' label. >

[PATCH v2] ath10k: Handle "invalid" BDFs for msm8998 devices

2019-11-13 Thread Jeffrey Hugo
drive by concidence, therefore there are production devices in the field where this issue needs to be handled otherwise we cannot support wifi on them. So, attempt to detect this scenario as best we can and treat it as non-fatal. Signed-off-by: Jeffrey Hugo Reviewed-by: Bjorn Andersson --- v2

[PATCH v2] ath10k: Fix qmi init error handling

2019-11-13 Thread Jeffrey Hugo
error handling. Fixes: ba94c753ccb4 ("ath10k: add QMI message handshake for wcn3990 client") Signed-off-by: Jeffrey Hugo --- v2: -Call power_off() as well drivers/net/wireless/ath/ath10k/snoc.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/a

Re: [PATCH] ath10k: Fix qmi init error handling

2019-11-13 Thread Jeffrey Hugo
On Tue, Nov 12, 2019 at 9:57 PM Kalle Valo wrote: > > Jeffrey Hugo writes: > > > On Tue, Nov 12, 2019 at 1:42 AM Simon Horman > > wrote: > >> > >> On Wed, Nov 06, 2019 at 03:16:50PM -0800, Jeffrey Hugo wrote: > >> > When ath10k_qmi_ini

Re: [PATCH] ath10k: Handle "invalid" BDFs for msm8998 devices

2019-11-12 Thread Jeffrey Hugo
On Tue, Nov 12, 2019 at 2:04 AM Simon Horman wrote: > > On Wed, Nov 06, 2019 at 03:47:12PM -0800, Jeffrey Hugo wrote: > > When the BDF download QMI message has the end field set to 1, it signals > > the end of the transfer, and triggers the firmware to do a CRC check. The &g

Re: [PATCH] ath10k: Fix qmi init error handling

2019-11-12 Thread Jeffrey Hugo
On Tue, Nov 12, 2019 at 1:42 AM Simon Horman wrote: > > On Wed, Nov 06, 2019 at 03:16:50PM -0800, Jeffrey Hugo wrote: > > When ath10k_qmi_init() fails, the error handling does not free the irq > > resources, which causes an issue if we EPROBE_DEFER as we'll attempt to >

[PATCH] ath10k: Handle "invalid" BDFs for msm8998 devices

2019-11-06 Thread Jeffrey Hugo
drive by concidence, therefore there are production devices in the field where this issue needs to be handled otherwise we cannot support wifi on them. So, attempt to detect this scenario as best we can and treat it as non-fatal. Signed-off-by: Jeffrey Hugo --- drivers/net/wireless/ath/ath10k

[PATCH] ath10k: Handle when FW doesn't support QMI_WLFW_HOST_CAP_REQ_V01

2019-11-06 Thread Jeffrey Hugo
particular scenario and ignore it so that we can still bring up wifi services successfully. Signed-off-by: Jeffrey Hugo --- drivers/net/wireless/ath/ath10k/qmi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/qmi.c b/drivers/net/wireless/ath

[PATCH] ath10k: Fix qmi init error handling

2019-11-06 Thread Jeffrey Hugo
When ath10k_qmi_init() fails, the error handling does not free the irq resources, which causes an issue if we EPROBE_DEFER as we'll attempt to (re-)register irqs which are already registered. Fixes: ba94c753ccb4 ("ath10k: add QMI message handshake for wcn3990 client") Signed-off-b