Re: [RFC 2/7] ath10k: Add support to process rx packet in thread

On 2020-07-22 06:00, Felix Fietkau wrote: On 2020-07-22 14:55, Johannes Berg wrote: On Wed, 2020-07-22 at 14:27 +0200, Felix Fietkau wrote: I'm considering testing a different approach (with mt76 initially): - Add a mac80211 rx function that puts processed skbs into a list instead of handing

Re: [RFC 2/7] ath10k: Add support to process rx packet in thread

On 2020-07-21 10:14, Rakesh Pillai wrote: NAPI instance gets scheduled on a CPU core on which the IRQ was triggered. The processing of rx packets can be CPU intensive and since NAPI cannot be moved to a different CPU core, to get better performance, its better to move the gist of rx packet

Re: [PATCH v5.8] ath10k: Fix NULL pointer dereference in AHB device probe

On 2020-07-14 13:58, Hauke Mehrtens wrote: This fixes a NULL pointer dereference in the probe path for AHB devices. There attr parameter in the ath10k_ce_alloc_pipe() function is not initialized, but accessed. This function is called by ath10k_pci_setup_resource() which is called by

Re: [PATCH v2] ath10k: Replace zero-length array with flexible-array

On 2020-05-06 21:11, Gustavo A. R. Silva wrote: [...] static inline struct htt_stats_conf_item *htt_stats_conf_next_item( @@ -1674,7 +1674,7 @@ struct htt_tx_fetch_ind { __le16 num_resp_ids; __le16 num_records; struct htt_tx_fetch_record records[0]; - __le32

Re: [PATCH 1/2] ath10k: use cumulative survey statistics

On 2020-05-05 00:55, Sven Eckelmann wrote: On Tuesday, 5 May 2020 09:49:46 CEST Sven Eckelmann wrote: [...] See also https://patchwork.kernel.org/patch/9701459/ And I completely forgot about this one: https://patchwork.kernel.org/patch/10417673/ _Me_too_ :) Hope this change is not needed

Re: [PATCH 1/2] ath10k: use cumulative survey statistics

On 2020-05-05 08:37, Markus Theil wrote: On 5/5/20 9:49 AM, Sven Eckelmann wrote: On Tuesday, 5 May 2020 09:01:34 CEST Sven Eckelmann wrote: On Tuesday, 5 May 2020 01:46:12 CEST Rajkumar Manoharan wrote: [...] IIRC this was fixed a while ago by below patch. Somehow it never landed in ath.git

Re: [PATCH 2/2] ath11k: use cumulative survey statistics

On 2020-05-04 23:53, Markus Theil wrote: Am 05.05.2020 um 01:37 schrieb Rajkumar Manoharan: On 2020-05-04 08:41, Markus Theil wrote: ath11k currently reports survey results for the last interval between each invocation of NL80211_CMD_GET_SURVEY. For concurrent invocations, this can lead

Re: [PATCH 1/2] ath10k: use cumulative survey statistics

On 2020-05-04 16:49, Ben Greear wrote: On 05/04/2020 04:46 PM, Rajkumar Manoharan wrote: On 2020-05-04 08:41, Markus Theil wrote: ath10k currently reports survey results for the last interval between each invocation of NL80211_CMD_GET_SURVEY. For concurrent invocations, this can lead

Re: [PATCH 1/2] ath10k: use cumulative survey statistics

On 2020-05-04 08:41, Markus Theil wrote: ath10k currently reports survey results for the last interval between each invocation of NL80211_CMD_GET_SURVEY. For concurrent invocations, this can lead to unexpectedly small results, e.g. when hostapd uses survey data and iw survey dump is invoked in

Re: [PATCH 2/2] ath11k: use cumulative survey statistics

On 2020-05-04 08:41, Markus Theil wrote: ath11k currently reports survey results for the last interval between each invocation of NL80211_CMD_GET_SURVEY. For concurrent invocations, this can lead to unexpectedly small results, e.g. when hostapd uses survey data and iw survey dump is invoked in

Re: [PATCH v5 5/6] ath10k: migrate to mac80211 txq scheduling

On 2018-12-19 05:24, Kalle Valo wrote: Rajkumar Manoharan writes: From: Toke Høiland-Jørgensen ath10k maintains common txqs list for all stations. This txq management can be removed by migrating to mac80211 txq APIs and let mac80211 handle txqs reordering based on reported airtime. By doing

[PATCH v5 6/6] ath10k: reporting estimated tx airtime for fairness

th10k: Implementing airtime fairness based TX scheduler") ref: https://chromium-review.googlesource.com/588190 Signed-off-by: Kan Yan [rmano...@codeaurora.org: ported only the airtime computation] Signed-off-by: Rajkumar Manoharan --- drivers/net/wireless/ath/ath10k/core.h | 2 ++ drivers/net/wi

[PATCH v5 5/6] ath10k: migrate to mac80211 txq scheduling

txq is removed. By adapting to mac80211 APIs, ath10k will support mac80211 based airtime fairness algorithm. Tested-by: Venkateswara Naralasetty Co-developed-by: Rajkumar Manoharan Signed-off-by: Toke Høiland-Jørgensen Signed-off-by: Rajkumar Manoharan --- drivers/net/wireless/ath/ath10k/core.c

[PATCH v5 0/6] Move TXQ scheduling and airtime fairness into mac80211

All, Sorry for the long delay. Here is the consolidated series of mac80211, ath9k and ath10k changes for moving TXQ scheduling and airtime fairness into mac80211 and support airtime fairness. Three main APIs are defined for TXQ scheduling. - ieee80211_next_txq - ieee80211_return_txq -

[PATCH v5 2/6] cfg80211: Add airtime statistics and settings

their weights. Signed-off-by: Toke Høiland-Jørgensen [rmano...@codeaurora.org: fixed checkpatch warnings] Signed-off-by: Rajkumar Manoharan --- include/net/cfg80211.h | 10 +- include/uapi/linux/nl80211.h | 15 +++ net/wireless/nl80211.c | 30

[PATCH v5 4/6] ath9k: Switch to mac80211 TXQ scheduling and airtime APIs

-by: Rajkumar Manoharan --- drivers/net/wireless/ath/ath9k/ath9k.h | 14 -- drivers/net/wireless/ath/ath9k/debug.c | 3 - drivers/net/wireless/ath/ath9k/debug.h | 8 - drivers/net/wireless/ath/ath9k/debug_sta.c | 70 - drivers/net/wireless/ath/ath9k/init.c | 3

[PATCH v5 3/6] mac80211: Add airtime accounting and scheduling to TXQs

are in sync. Co-developed-by: Rajkumar Manoharan Signed-off-by: Louie Lu [added debugfs write op to reset airtime counter] Signed-off-by: Toke Høiland-Jørgensen Signed-off-by: Rajkumar Manoharan --- include/net/mac80211.h | 59 ++ net/mac80211/cfg.c | 3

[PATCH v5 1/6] mac80211: Add TXQ scheduling API

From: Toke Høiland-Jørgensen This adds an API to mac80211 to handle scheduling of TXQs. The interface between driver and mac80211 for TXQ handling is changed by adding two new functions: ieee80211_next_txq(), which will return the next TXQ to schedule in the current round-robin rotation, and

[PATCH v4 5/6] ath10k: migrate to mac80211 txq scheduling

txq is removed. By adapting to mac80211 APIs, ath10k will support mac80211 based airtime fairness algorithm. Tested-by: Venkateswara Naralasetty Co-developed-by: Rajkumar Manoharan Signed-off-by: Toke Høiland-Jørgensen Signed-off-by: Rajkumar Manoharan --- drivers/net/wireless/ath/ath10k/core.c

[PATCH v4 6/6] ath10k: reporting estimated tx airtime for fairness

th10k: Implementing airtime fairness based TX scheduler") ref: https://chromium-review.googlesource.com/588190 Signed-off-by: Kan Yan [rmano...@codeaurora.org: ported only the airtime computation] Signed-off-by: Rajkumar Manoharan --- drivers/net/wireless/ath/ath10k/core.h | 2 ++ drivers/net/wi

[PATCH v4 4/6] ath9k: Switch to mac80211 TXQ scheduling and airtime APIs

-by: Rajkumar Manoharan --- drivers/net/wireless/ath/ath9k/ath9k.h | 14 -- drivers/net/wireless/ath/ath9k/debug.c | 3 - drivers/net/wireless/ath/ath9k/debug.h | 8 - drivers/net/wireless/ath/ath9k/debug_sta.c | 70 - drivers/net/wireless/ath/ath9k/init.c | 3

[PATCH v4 2/6] cfg80211: Add airtime statistics and settings

their weights. Signed-off-by: Toke Høiland-Jørgensen [rmano...@codeaurora.org: fixed checkpatch warnings] Signed-off-by: Rajkumar Manoharan --- include/net/cfg80211.h | 10 +- include/uapi/linux/nl80211.h | 15 +++ net/wireless/nl80211.c | 30

[PATCH v4 3/6] mac80211: Add airtime accounting and scheduling to TXQs

are in sync. Co-developed-by: Rajkumar Manoharan Signed-off-by: Louie Lu [added debugfs write op to reset airtime counter] Signed-off-by: Toke Høiland-Jørgensen Signed-off-by: Rajkumar Manoharan --- include/net/mac80211.h | 59 ++ net/mac80211/cfg.c | 3

[PATCH v4 1/6] mac80211: Add TXQ scheduling API

From: Toke Høiland-Jørgensen This adds an API to mac80211 to handle scheduling of TXQs. The interface between driver and mac80211 for TXQ handling is changed by adding two new functions: ieee80211_next_txq(), which will return the next TXQ to schedule in the current round-robin rotation, and

[PATCH v4 0/6] Move TXQ scheduling and airtime fairness into mac80211

All, Sorry for the long delay. Here is the consolidated series of mac80211, ath9k and ath10k changes for moving TXQ scheduling and airtime fairness into mac80211 and support airtime fairness. Three main APIs are defined for TXQ scheduling. - ieee80211_next_txq - ieee80211_return_txq -

[PATCH v3 5/6] ath10k: migrate to mac80211 txq scheduling

txq is removed. By adapting to mac80211 APIs, ath10k will support mac80211 based airtime fairness algorithm. Tested-by: Venkateswara Naralasetty Co-Developed-by: Rajkumar Manoharan Signed-off-by: Toke Høiland-Jørgensen Signed-off-by: Rajkumar Manoharan --- drivers/net/wireless/ath/ath10k/core.c

[PATCH v3 4/6] ath9k: Switch to mac80211 TXQ scheduling and airtime APIs

-by: Rajkumar Manoharan --- drivers/net/wireless/ath/ath9k/ath9k.h | 14 -- drivers/net/wireless/ath/ath9k/debug.c | 3 - drivers/net/wireless/ath/ath9k/debug.h | 8 - drivers/net/wireless/ath/ath9k/debug_sta.c | 70 - drivers/net/wireless/ath/ath9k/init.c | 3

[PATCH v3 6/6] ath10k: reporting estimated tx airtime for fairness

th10k: Implementing airtime fairness based TX scheduler") ref: https://chromium-review.googlesource.com/588190 Signed-off-by: Kan Yan [rmano...@codeaurora.org: ported only the airtime computation] Signed-off-by: Rajkumar Manoharan --- drivers/net/wireless/ath/ath10k/core.h | 2 ++ drivers/net/wi

[PATCH v3 2/6] cfg80211: Add airtime statistics and settings

their weights. Signed-off-by: Toke Høiland-Jørgensen [rmano...@codeaurora.org: fixed checkpatch warnings] Signed-off-by: Rajkumar Manoharan --- include/net/cfg80211.h | 10 +- include/uapi/linux/nl80211.h | 15 +++ net/wireless/nl80211.c | 30

[PATCH v3 3/6] mac80211: Add airtime accounting and scheduling to TXQs

are in sync. Co-Developed-by: Rajkumar Manoharan Signed-off-by: Toke Høiland-Jørgensen Signed-off-by: Rajkumar Manoharan --- include/net/mac80211.h | 59 ++ net/mac80211/cfg.c | 3 ++ net/mac80211/debugfs.c | 3 ++ net/mac80211/debugfs_sta.c | 50

[PATCH v3 1/6] mac80211: Add TXQ scheduling API

From: Toke Høiland-Jørgensen This adds an API to mac80211 to handle scheduling of TXQs. The interface between driver and mac80211 for TXQ handling is changed by adding two new functions: ieee80211_next_txq(), which will return the next TXQ to schedule in the current round-robin rotation, and

[PATCH v3 0/6] Move TXQ scheduling and airtime fairness into mac80211

Here is the consolidated series of mac80211, ath9k and ath10k changes for moving TXQ scheduling and airtime fairness into mac80211 and support airtime fairness. Three main APIs are defined for TXQ scheduling. - ieee80211_next_txq - ieee80211_return_txq - ieee80211_txq_may_transmit and two

[PATCH v2 0/6] Move TXQ scheduling and airtime fairness into mac80211

From: Rajkumar Manoharan Here is the consolidated series of mac80211, ath9k and ath10k changes for moving TXQ scheduling and airtime fairness into mac80211 and support airtime fairness. Three main APIs are defined for TXQ scheduling. - ieee80211_next_txq - ieee80211_return_txq

[PATCH v2 4/6] ath9k: Switch to mac80211 TXQ scheduling and airtime APIs

From: Toke Høiland-Jørgensen This moves the ath9k driver to use the mac80211 TXQ scheduling and airtime accounting APIs, removing the corresponding state tracking inside the driver. Signed-off-by: Toke Høiland-Jørgensen --- drivers/net/wireless/ath/ath9k/ath9k.h | 14 --

[PATCH v2 2/6] cfg80211: Add airtime statistics and settings

From: Toke Høiland-Jørgensen This adds TX airtime statistics to the cfg80211 station dump (to go along with the RX info already present), and adds a new parameter to set the airtime weight of each station. The latter allows userspace to implement policies for different stations by varying their

[PATCH v2 3/6] mac80211: Add airtime accounting and scheduling to TXQs

are in sync. Co-Developed-by: Rajkumar Manoharan Signed-off-by: Toke Høiland-Jørgensen Signed-off-by: Rajkumar Manoharan --- include/net/mac80211.h | 59 ++ net/mac80211/cfg.c | 3 ++ net/mac80211/debugfs.c | 3 ++ net/mac80211/debugfs_sta.c | 50

[PATCH v2 5/6] ath10k: migrate to mac80211 txq scheduling

txq is removed. By adapting to mac80211 APIs, ath10k will support mac80211 based airtime fairness algorithm. Tested-by: Venkateswara Naralasetty Co-Developed-by: Rajkumar Manoharan Signed-off-by: Toke Høiland-Jørgensen Signed-off-by: Rajkumar Manoharan --- drivers/net/wireless/ath/ath10k/core.c

[PATCH v2 6/6] ath10k: reporting estimated tx airtime for fairness

th10k: Implementing airtime fairness based TX scheduler") ref: https://chromium-review.googlesource.com/588190 Signed-off-by: Kan Yan [rmano...@codeaurora.org: ported only the airtime computation] Signed-off-by: Rajkumar Manoharan --- drivers/net/wireless/ath/ath10k/core.h | 2 ++ drivers/net/wi

[PATCH v2 0/6] Move TXQ scheduling and airtime fairness into mac80211

Here is the consolidated series of mac80211, ath9k and ath10k changes for moving TXQ scheduling and airtime fairness into mac80211 and support airtime fairness. Three main APIs are defined for TXQ scheduling. - ieee80211_next_txq - ieee80211_return_txq - ieee80211_txq_may_transmit and two

[PATCH v2 1/6] mac80211: Add TXQ scheduling API

From: Toke Høiland-Jørgensen This adds an API to mac80211 to handle scheduling of TXQs. The interface between driver and mac80211 for TXQ handling is changed by adding two new functions: ieee80211_next_txq(), which will return the next TXQ to schedule in the current round-robin rotation, and

Re: [PATCH REGRESSION] Revert "ath10k: add quiet mode support for QCA6174/QCA9377"

On 2018-11-08 09:30, Brian Norris wrote: On Wed, Nov 7, 2018 at 8:32 PM Govind Singh wrote: On 2018-11-08 03:00, Rajkumar Manoharan wrote: > > The change "ath10k: add quiet mode support for QCA6174/QCA9377" was > merged even > before full WCN3990 device support was add

Re: [PATCH 3/6] mac80211: Add airtime accounting and scheduling to TXQs

On 2018-11-07 06:53, Toke Høiland-Jørgensen wrote: Rajkumar Manoharan writes: Meanwhile we did some more experiments with both modes. The experiment was done in open environment and fixed rate and UDP traffic ran for 60 seconds. Seems like push mode not honoring the configured weight. Always

Re: [PATCH REGRESSION] Revert "ath10k: add quiet mode support for QCA6174/QCA9377"

On 2018-11-07 10:56, Brian Norris wrote: This reverts commit cfb353c0dc058bc1619cc226d3cbbda1f360bdd3. WCN3990 firmware does not yet implement this feature, and so it crashes like this: fatal error received: err_qdi.c:456:EX:wlan_process:1:WLAN RT:207a:PC=b001b4f0 This feature can be

Re: [PATCH 3/6] mac80211: Add airtime accounting and scheduling to TXQs

On 2018-11-02 03:30, Toke Høiland-Jørgensen wrote: Rajkumar Manoharan writes: On 2018-10-28 15:01, Rajkumar Manoharan wrote: On 2018-10-28 08:48, Toke Høiland-Jørgensen wrote: Rajkumar Manoharan writes: 4ms 223 (40%) 214 (40%)109 (10%) 94 (10%) 4ms 337

Re: [PATCH 3/6] mac80211: Add airtime accounting and scheduling to TXQs

On 2018-10-28 15:01, Rajkumar Manoharan wrote: On 2018-10-28 08:48, Toke Høiland-Jørgensen wrote: Rajkumar Manoharan writes: 4ms 223 (40%) 214 (40%)109 (10%) 94 (10%) 4ms 337 (90%) 182 (8%) 23 (1%)30 (1%) So this looks like it's

Re: [PATCH 3/6] mac80211: Add airtime accounting and scheduling to TXQs

On 2018-10-28 08:48, Toke Høiland-Jørgensen wrote: Rajkumar Manoharan writes: Yes. I do understand the user can change airtime at anytime but It must be noted that different airtime weight will result in different throughput. IMHO the defaults should not impact current benchmark. Otherwise

Re: [PATCH 3/6] mac80211: Add airtime accounting and scheduling to TXQs

On 2018-10-26 07:16, Toke Høiland-Jørgensen wrote: Rajkumar Manoharan writes: From: Toke Høiland-Jørgensen [...] u8 max_nan_de_entries; u8 tx_sk_pacing_shift; + u32 airtime_weight; }; This doesn't make sense. Airtime weights can be set by userspace, so even

Re: [PATCH 5/6] ath10k: migrate to mac80211 txq scheduling

On 2018-10-24 01:33, Kalle Valo wrote: Rajkumar Manoharan writes: ath10k maintains common txqs list for all stations. This txq management can be removed by migrating to mac80211 txq APIs and let mac80211 handle txqs reordering based on reported airtime. By doing this, txq fairness maintained

[PATCH 4/6] ath9k: Switch to mac80211 TXQ scheduling and airtime APIs

From: Toke Høiland-Jørgensen This moves the ath9k driver to use the mac80211 TXQ scheduling and airtime accounting APIs, removing the corresponding state tracking inside the driver. Signed-off-by: Toke Høiland-Jørgensen --- drivers/net/wireless/ath/ath9k/ath9k.h | 14 --

[PATCH 1/6] mac80211: Add TXQ scheduling API

From: Toke Høiland-Jørgensen This adds an API to mac80211 to handle scheduling of TXQs. The interface between driver and mac80211 for TXQ handling is changed by adding two new functions: ieee80211_next_txq(), which will return the next TXQ to schedule in the current round-robin rotation, and

[PATCH 3/6] mac80211: Add airtime accounting and scheduling to TXQs

are in sync. Signed-off-by: Toke Høiland-Jørgensen Signed-off-by: Rajkumar Manoharan --- include/net/mac80211.h | 58 ++ net/mac80211/cfg.c | 3 ++ net/mac80211/debugfs.c | 3 ++ net/mac80211/debugfs_sta.c | 50 -- net

[PATCH 6/6] ath10k: reporting estimated tx airtime for fairness

Transmit airtime will be estimated from last tx rate used. Firmware report tx rate by peer stats. Airtime is computed on tx path and the same will be reported to mac80211 upon tx completion. Signed-off-by: Kan Yan Signed-off-by: Rajkumar Manoharan --- drivers/net/wireless/ath/ath10k/core.h

[PATCH 5/6] ath10k: migrate to mac80211 txq scheduling

to mac80211 APIs, ath10k will support mac80211 based airtime fairness algorithm. Signed-off-by: Toke Høiland-Jørgensen Signed-off-by: Rajkumar Manoharan --- drivers/net/wireless/ath/ath10k/core.c | 2 - drivers/net/wireless/ath/ath10k/core.h | 6 +- drivers/net/wireless/ath/ath10k/htc.h| 1

[PATCH 0/6] Move TXQ scheduling and airtime fairness into mac80211

option to configure driver specific default airtime. - Bundled ath10k changes along with this series. -Rajkumar Rajkumar Manoharan (2): ath10k: migrate to mac80211 txq scheduling ath10k: reporting estimated tx airtime for fairness Toke Høiland-Jørgensen (4): mac80211: Add TXQ scheduling

[PATCH 2/6] cfg80211: Add airtime statistics and settings

From: Toke Høiland-Jørgensen This adds TX airtime statistics to the cfg80211 station dump (to go along with the RX info already present), and adds a new parameter to set the airtime weight of each station. The latter allows userspace to implement policies for different stations by varying their

Re: [RFC v2 1/2] ath10k: migrate to mac80211 txq scheduling

On 2018-09-29 03:06, Toke Høiland-Jørgensen wrote: Rajkumar Manoharan writes: - ath10k_htt_tx_txq_update(hw, f_txq); + if (ret == -EBUSY) { + ieee80211_txq_schedule_start(hw, ac); + ieee80211_return_txq(hw, txq

[RFC v2 2/2] ath10k: reporting estimated tx airtime for fairness

Transmit airtime will be estimated from last tx rate used. Firmware report tx rate by peer stats. Airtime is computed on tx path and the same will be reported to mac80211 upon tx completion. Signed-off-by: Kan Yan Signed-off-by: Rajkumar Manoharan --- drivers/net/wireless/ath/ath10k/core.h

Re: [RFC 2/2] ath10k: reporting estimated tx airtime for fairness

On 2018-09-28 12:57, Ben Greear wrote: On 09/28/2018 12:47 PM, Rajkumar Manoharan wrote: On 2018-09-28 08:25, Toke Høiland-Jørgensen wrote: So this just uses the calculated airtime based on rate and size? Wasn't there supposed to be an airtime usage value reported by the firmware

Re: [RFC 1/2] ath10k: migrate to mac80211 txq scheduling

On 2018-09-26 17:41, Rajkumar Manoharan wrote: @@ -4293,32 +4281,7 @@ static void ath10k_mac_op_tx(struct ieee80211_hw *hw, static void ath10k_mac_op_wake_tx_queue(struct ieee80211_hw *hw, struct ieee80211_txq *txq) { - struct ath10k *ar = hw

Re: [RFC 2/2] ath10k: reporting estimated tx airtime for fairness

On 2018-09-28 08:25, Toke Høiland-Jørgensen wrote: So this just uses the calculated airtime based on rate and size? Wasn't there supposed to be an airtime usage value reported by the firmware? :) Firmware interface changes are in progress. Airtime for sta/tid will be reported via htt

[RFC 2/2] ath10k: reporting estimated tx airtime for fairness

Transmit airtime will be estimated from last tx rate used. Firmware report tx rate by peer stats. Airtime is computed on tx path and the same will be reported to mac80211 upon tx completion. Signed-off-by: Kan Yan Signed-off-by: Rajkumar Manoharan --- drivers/net/wireless/ath/ath10k/core.h

[RFC 1/2] ath10k: migrate to mac80211 txq scheduling

to mac80211 APIs, ath10k will support mac80211 based airtime fairness algorithm. Signed-off-by: Toke Høiland-Jørgensen Signed-off-by: Rajkumar Manoharan --- drivers/net/wireless/ath/ath10k/core.c | 2 - drivers/net/wireless/ath/ath10k/core.h | 3 -- drivers/net/wireless/ath/ath10k/htc.h| 1

Re: [PATCH] ath10k: Don't allow tx logic when state is not ON.

On 2018-06-20 11:51, Ben Greear wrote: On 06/20/2018 11:48 AM, Rajkumar Manoharan wrote: On 2018-06-20 10:42, Ben Greear wrote: On 06/20/2018 10:37 AM, Manikanta Pubbisetty wrote: [...] This case should not be dealt in ath10k, rather we should make sure packets does not reach the driver

Re: [PATCH] ath10k: Don't allow tx logic when state is not ON.

On 2018-06-20 10:42, Ben Greear wrote: On 06/20/2018 10:37 AM, Manikanta Pubbisetty wrote: [...] This case should not be dealt in ath10k, rather we should make sure packets does not reach the driver during hardware restart after the firmware crash. Can you please try the RFC patch and see

Re: [PATCH v2] ath10k: transmit queued frames after waking queues

On 2018-05-23 09:25, Erik Stromdahl wrote: On 05/22/2018 11:15 PM, Niklas Cassel wrote: [...] Perhaps it would be possible to call ath10k_mac_tx_push_pending() from the equivalent to ath10k_htt_txrx_compl_task(), but from SDIO's point of view. An equivalent for SDIO would most likely be

Re: [PATCH v2] ath10k: transmit queued frames after waking queues

On 2018-05-22 14:15, Niklas Cassel wrote: On Mon, May 21, 2018 at 04:11:38PM -0700, Rajkumar Manoharan wrote: On 2018-05-21 13:43, Niklas Cassel wrote: > The following problem was observed when running iperf: [...] Sorry for the late response. ath10k_mac_tx_push_pending is already cal

Re: [PATCH v2] ath10k: transmit queued frames after waking queues

On 2018-05-21 13:43, Niklas Cassel wrote: The following problem was observed when running iperf: [...] In order to avoid trying to flush the queue every time we free a frame, only do this when there are 3 or less frames pending, and while we actually have frames in the queue. This logic was

[PATCH] ath10k: fix vdev stats for 10.4 firmware

vdev stats, appropriate feature bit will be set on extended resource config. As FTM related counters are available only on newer 10.4 based firmware, these counters will be displayed only on valid data. Signed-off-by: Rajkumar Manoharan <rmano...@codeaurora.org> --- drivers/net/wireless/ath/

RE: [PATCH] ath10k: unify rx processing in napi_poll

> I'm wondering if this patch is related to kernel crash due to ath10k napi. > > Do you think this patch helps the crash below? > > This crash happened ath10k v4.14 (10/04/2017, commit id c09dbd7) + > 3.14.43 kernel backports. > > [ 6866.655419] [ cut here ] > [

[PATCH] ath10k: unify rx processing in napi_poll

in napi poll routine. Signed-off-by: Rajkumar Manoharan <rmano...@qti.qualcomm.com> --- drivers/net/wireless/ath/ath10k/core.h | 1 - drivers/net/wireless/ath/ath10k/htt.h| 2 +- drivers/net/wireless/ath/ath10k/htt_rx.c | 121 --- 3 files changed, 63 inse

RE: [Make-wifi-fast] [PATCH] ath10k: Re-enable TXQs for all devices

> > > > The issue that seems to point to has been fixed a while ago; I'll send > > and updated patch with a better commit message (also forgot to cc the > > ath10k list, I see). > > > > -Toke > > Hmm. I remember that thread. I thought we'd basically resolved that issue (45% > of the time spent in

RE: [PATCH] ath10k: add new cipher suite support

> Am 22.09.2017 um 23:17 schrieb Rajkumar Manoharan: > > - ar->hw->wiphy->n_cipher_suites = ARRAY_SIZE(cipher_suites); > > + > > + /* QCA988x and QCA6174 family chips do not support CCMP-256, > GCMP-128 > > +* and GCMP-256 ciphers i

[PATCH] ath10k: add new cipher suite support

QCA99x0 and QCA4019 family chips support CCMP-256, GCMP-128, and GCMP-256 ciphers in hardware, so advertise support for these. As firmware does not support group management frame ciphers (BIP), handle them in software (mac80211). Cc: Jouni Malinen <jo...@qca.qualcomm.com> Signed-off-by: Ra

Re: QCA4019: calibration files and board files

On 2017-02-27 23:58, Sven Eckelmann wrote: It looks to me now that this information is contradicting your implementation (which now loads the data from 0:ART partition [1] like pre-cal data [2] and then loads the board-2.bin [3]). Both reading from ART and loading pre-cal data file are same.

[PATCH] ath10k: fix monitor vdev for receiving other bss frames

rxfilters by default for mesh vdev during vdev creation. This change fixes monitor vdev creation based on firmware IE Signed-off-by: Rajkumar Manoharan <rmano...@qca.qualcomm.com> --- drivers/net/wireless/ath/ath10k/core.c | 1 + drivers/net/wireless/ath/ath10k/core.h | 7 +++ drivers/net/wi

[PATCH] ath10k: fix copy engine 5 destination ring stuck

less than read index which means that full ring is available for receiving data. Cc: sta...@vger.kernel.org Tested-by: Tamizh chelvam <c_tr...@qti.qualcomm.com> Signed-off-by: Rajkumar Manoharan <rmano...@qti.qualcomm.com> --- drivers/net/wireless/ath/ath10k/ce.c | 7 +++ 1 fil

[PATCH] ath10k: advertize hardware packet loss mechanism

rate table, mac80211 might send out low_ack event to hostapd. This is causing frequent connect and disconnect iteration under noisy environment or when station is roaming around. Signed-off-by: Rajkumar Manoharan <rmano...@qti.qualcomm.com> --- drivers/net/wireless/ath/ath10k/mac.c | 1 +

[PATCH] ath10k: fix throughput regression in multi client mode

it "ath10k: improve tx scheduling". Processing pending txqs after all skbs tx completion will yeild enough room to burst tx frames. Fixes: 7a0adc83f34d ("ath10k: improve tx scheduling") Signed-off-by: Rajkumar Manoharan <rmano...@qti.qualcomm.com> --- drivers/net/wireless

Re: [PATCH v3] ath10k: implement NAPI support

On 2016-08-26 17:19, Dave Taht wrote: On Fri, Aug 26, 2016 at 4:12 AM, Johannes Berg wrote: On Fri, 2016-08-26 at 03:48 -0700, Dave Taht wrote: I'm always rather big on people testing latency under load, and napi tends to add some. That's a completely useless

[PATCH v3] ath10k: implement NAPI support

(49%) UDP UL 720 Mbps (28%)717 Mbps (11%) Signed-off-by: Rajkumar Manoharan <rmano...@qti.qualcomm.com> --- v2: rebased change v3: napi_synchronize and napi_disable should be called on deinit. Otherwise it is causing invalid memory access. Thanks to Kalle for reporting th

[PATCH] ath10k: improve wake_tx_queue ops performance

mit support. So reducing spin lock contention is helping in Mesh. TOT +change TCP DL 545 Mbps595 Mbps TCP UL 555 Mbps585 Mbps Signed-off-by: Rajkumar Manoharan <rmano...@qti.qualcomm.com> --- drivers/net/wireless/ath/ath10k/m

[PATCH v2] ath10k: fix group privacy action frame decryption for qca4019

ose frames is breaking mesh connection establishment. Signed-off-by: Rajkumar Manoharan <rmano...@qti.qualcomm.com> --- v2: is_broadcast_ether_addr check not needed drivers/net/wireless/ath/ath10k/core.c | 4 drivers/net/wireless/ath/ath10k/core.h | 5 + drivers/net/wireless/ath/at

[PATCH] ath10k: fix group privacy action frame decryption for qca4019

ose frames is breaking mesh connection establishment. Signed-off-by: Rajkumar Manoharan <rmano...@qti.qualcomm.com> --- drivers/net/wireless/ath/ath10k/core.c | 4 drivers/net/wireless/ath/ath10k/core.h | 5 + drivers/net/wireless/ath/ath10k/wmi.c | 30 +- 3 f

[PATCH v2] ath10k: implement NAPI support

(49%) UDP UL 720 Mbps (28%)717 Mbps (11%) Signed-off-by: Rajkumar Manoharan <rmano...@qti.qualcomm.com> --- v2: rebased change drivers/net/wireless/ath/ath10k/ahb.c| 6 +- drivers/net/wireless/ath/ath10k/core.c | 2 + drivers/net/wireless/ath/ath10k/core.h | 8 ++ dr

Re: Regression in qca99x0 on x86 platform (kernel: 4.7.0-rc1-wt-ath

On 2016-06-14 19:14, Ben Greear wrote: On 06/13/2016 11:21 PM, Rajkumar Manoharan wrote: On 2016-06-02 23:22, Ben Greear wrote: At the time, I bisected to this commit as well, but I decided to just live with it since it seemed it fixed some other bug and we had a work-around. My

Re: Regression in qca99x0 on x86 platform (kernel: 4.7.0-rc1-wt-ath

On 2016-06-02 23:22, Ben Greear wrote: On 06/02/2016 10:46 AM, Rajkumar Manoharan wrote: On 2016-06-02 22:57, Ben Greear wrote: On 06/02/2016 10:20 AM, Manoharan, Rajkumar wrote: Found a regression in ath.git TOT that system hangs while probing qca99x0 device on x86_64 platform. It seems

[PATCH] ath10k: fix system hang at qca99x0 probe on x86 platform

while DMA mapping bigger memory chunks (689816/865444 bytes). Fix this by limiting maximum memory chunk size to 256 KiB per request. Cc: Felix Fietkau <n...@nbd.name> Fixes: b057886524be ("ath10k: do not use coherent memory for allocated device memory chunks") Signed-off-by:

[PATCH] ath10k: fix deadlock while processing rx_in_ord_ind

sing lock nesting notation 1 lock held by swapper/3/0: #0: (&(>rx_ring.lock)->rlock){+.-...}, at: [] ath10k_htt_txrx_compl_task+0x21b/0x250 [ath10k_core] Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=119151 Fixes: 5c86d97bcc1d ("ath10k: combine txrx and replenish task"

Re: Bug 119151 - [regression] ath10k no longer authenitcates and freezes system

On 2016-06-02 23:03, Mike Lothian wrote: I've just tried those two changes, the machine now locks up before X has even started Mike, Sorry for the delay. Found root cause for dead lock. Can you please give a try with below change? diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c

Re: [PATCH 2/2] ath10k: remove 10.1 firmware support

On 2016-06-03 21:18, Ben Greear wrote: On 06/03/2016 08:33 AM, Rajkumar Manoharan wrote: Earlier qca9888 device was brought up using 10.1 firmware and then later all firmware fixes and new features are migrated to 10.2/10.2.x firmware branch. As all of 10.1 funtionalities are supported in 10.2

[PATCH 2/2] ath10k: remove 10.1 firmware support

Earlier qca9888 device was brought up using 10.1 firmware and then later all firmware fixes and new features are migrated to 10.2/10.2.x firmware branch. As all of 10.1 funtionalities are supported in 10.2 based firmware, removing 10.1 firmware support for qca9888 device. Signed-off-by: Rajkumar

[PATCH 1/2] ath10k: handle testmode events for 10.2 based firmware

Currently testmode events for 10.x firmware are processed from 10.1 wmi event processing. In order to remove 10.1 firmware support, testmode events should be handled from 10.2 event processing. Signed-off-by: Rajkumar Manoharan <rmano...@qti.qualcomm.com> --- drivers/net/wireless/ath/

[PATCH 5/5] ath10k: add pdev param support to enable/disable btcoex

10.4 firmware has support to enable or disable btcoex functionality without reloading firmware via wmi pdev param. Add provision to send pdev param command via existing btcoex knob. Signed-off-by: Rajkumar Manoharan <rmano...@qti.qualcomm.com> --- drivers/net/wireless/ath/ath10k/core.c

[PATCH 4/5] ath10k: add new ATH10K_FW_FEATURE_BTCOEX_PARAM

. Signed-off-by: Rajkumar Manoharan <rmano...@qti.qualcomm.com> --- drivers/net/wireless/ath/ath10k/core.c | 1 + drivers/net/wireless/ath/ath10k/core.h | 7 +++ 2 files changed, 8 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/

[PATCH 3/5] ath10k: update module description

Update module description to advertise all supported QCA 802.11ac devices. Signed-off-by: Rajkumar Manoharan <rmano...@qti.qualcomm.com> --- drivers/net/wireless/ath/ath10k/core.c | 2 +- drivers/net/wireless/ath/ath10k/pci.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff

[PATCH 2/5] ath10k: remove unused phy_mode_to_band

Remove unused inline function phy_mode_to_band. Signed-off-by: Rajkumar Manoharan <rmano...@qti.qualcomm.com> --- drivers/net/wireless/ath/ath10k/htt_rx.c | 28 1 file changed, 28 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c b/drive

[PATCH 1/5] ath10k: fix operating irq mode for ahb device

is failed during probe. Fixes: cfe9011a05a8 ("ath10k: remove MSI range support") Signed-off-by: Rajkumar Manoharan <rmano...@qti.qualcomm.com> --- drivers/net/wireless/ath/ath10k/ahb.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/ahb.c

Re: ath10k performance, master branch from 20160407

On 2016-05-16 04:29, Roman Yeryomin wrote: On 9 May 2016 at 15:26, Michal Kazior wrote: Hi Roman, On 22 April 2016 at 19:05, Roman Yeryomin wrote: On 19 April 2016 at 18:35, Valo, Kalle wrote: Michal Kazior

[PATCH v2 4/4] ath10k: update bss channel survey information

counters b/w two survey requests. Signed-off-by: Yanbo Li <yan...@qca.qualcomm.com> Signed-off-by: Rajkumar Manoharan <rmano...@qti.qualcomm.com> --- v2: fixed sparse warnings drivers/net/wireless/ath/ath10k/core.c | 5 + drivers/net/wireless/ath/ath10k/core.h | 1 + drivers/

[PATCH v2 2/4] ath10k: implement wmi_pdev_bss_chan_info_request

Add WMI ops to send pdev_bss_chan_info_request command to target. This command will be used to retrieve updated cycle counters and noise floor value of current operating channel (bss channel). Signed-off-by: Rajkumar Manoharan <rmano...@qti.qualcomm.com> --- drivers/net/wireless/ath/ath1

  1   2   3   >