[PATCH] ath10k: Modify macros to fix style issues

2017-02-22 Thread Marcin Rokicki
Both macros are used internally to convert incomming parameters to strings in a switch case statement. Current implementation gives following output from checkpatch.pl: - ERROR: Macros with complex values should be enclosed in parentheses - WARNING: Macros with flow control statements should be

Re: [PATCH] ath10k: Modify macros to fix style issues

2017-02-22 Thread Joe Perches
On Wed, 2017-02-22 at 09:15 +0100, Marcin Rokicki wrote: > Both macros are used internally to convert incomming parameters > to strings in a switch case statement. > > Current implementation gives following output from checkpatch.pl: > - ERROR: Macros with complex values should be enclosed in par

Re: [PATCH] ath10k: Modify macros to fix style issues

2017-02-22 Thread Joe Perches
(fyi Marcin, the reason this isn't getting on the list is because your 3 tries have all included text and html) On Wed, 2017-02-22 at 14:31 +0100, Marcin Rokicki wrote: > > > > Here is an alternate style used a few times in the kernel > > > > Maybe it'd be nicer to change the macros to somethin