Re: [PATCH] ath10k: add cleanup in ath10k_sta_state()

2019-11-13 Thread Kalle Valo
Bjorn Andersson writes: > On Thu 15 Aug 14:04 PDT 2019, Wenwen Wang wrote: > >> If 'sta->tdls' is false, no cleanup is executed, leading to memory/resource >> leaks, e.g., 'arsta->tx_stats'. To fix this issue, perform cleanup before >> go to the 'exit' label. >> > > Unfortunately this patch

Re: [PATCH] ath10k: add cleanup in ath10k_sta_state()

2019-11-13 Thread Jeffrey Hugo
On Wed, Nov 13, 2019 at 12:28 PM Bjorn Andersson wrote: > > On Thu 15 Aug 14:04 PDT 2019, Wenwen Wang wrote: > > > If 'sta->tdls' is false, no cleanup is executed, leading to memory/resource > > leaks, e.g., 'arsta->tx_stats'. To fix this issue, perform cleanup before > > go to the 'exit' label.

Re: [PATCH] ath10k: add cleanup in ath10k_sta_state()

2019-11-13 Thread Bjorn Andersson
On Thu 15 Aug 14:04 PDT 2019, Wenwen Wang wrote: > If 'sta->tdls' is false, no cleanup is executed, leading to memory/resource > leaks, e.g., 'arsta->tx_stats'. To fix this issue, perform cleanup before > go to the 'exit' label. > Unfortunately this patch consistently crashes all my msm8998,

Re: [PATCH] ath10k: add cleanup in ath10k_sta_state()

2019-09-17 Thread Kalle Valo
Wenwen Wang wrote: > If 'sta->tdls' is false, no cleanup is executed, leading to memory/resource > leaks, e.g., 'arsta->tx_stats'. To fix this issue, perform cleanup before > go to the 'exit' label. > > Signed-off-by: Wenwen Wang > Signed-off-by: Kalle Valo Patch applied to ath-next branch

Re: [PATCH] ath10k: add cleanup in ath10k_sta_state()

2019-09-17 Thread Kalle Valo
Wenwen Wang wrote: > If 'sta->tdls' is false, no cleanup is executed, leading to memory/resource > leaks, e.g., 'arsta->tx_stats'. To fix this issue, perform cleanup before > go to the 'exit' label. > > Signed-off-by: Wenwen Wang > Signed-off-by: Kalle Valo Patch applied to ath-next branch

Re: [PATCH] ath10k: add cleanup in ath10k_sta_state()

2019-08-16 Thread Sebastian Gottschall
this patch will kick our any peer each time you call for statistics.so it will not solve anything. it creates a massive bug. usually just kfree is enough here but even this will maybe just kill existing stats Am 15.08.2019 um 23:04 schrieb Wenwen Wang: If 'sta->tdls' is false, no cleanup is

[PATCH] ath10k: add cleanup in ath10k_sta_state()

2019-08-15 Thread Wenwen Wang
If 'sta->tdls' is false, no cleanup is executed, leading to memory/resource leaks, e.g., 'arsta->tx_stats'. To fix this issue, perform cleanup before go to the 'exit' label. Signed-off-by: Wenwen Wang --- drivers/net/wireless/ath/ath10k/mac.c | 6 +- 1 file changed, 5 insertions(+), 1