RE: [PATCH] ath10k: fix wmi mgmt tx queue full due to race condition

2021-01-19 Thread miaoqing
> Please address Brian's comments and send v2. > > Patch set to Changes Requested. Updated. https://patchwork.kernel.org/project/linux-wireless/patch/1608618887-8857-1-git-send-email-miaoq...@codeaurora.org/ ___ ath10k mailing list ath10k@lists.infrad

Re: [PATCH] ath10k: fix wmi mgmt tx queue full due to race condition

2021-01-18 Thread Kalle Valo
Miaoqing Pan wrote: > Failed to transmit wmi management frames: > > [84977.840894] ath10k_snoc a00.wifi: wmi mgmt tx queue is full > [84977.840913] ath10k_snoc a00.wifi: failed to transmit packet, dropping: > -28 > [84977.840924] ath10k_snoc a00.wifi: failed to submit frame: -28 > [

Re: [PATCH] ath10k: fix wmi mgmt tx queue full due to race condition

2020-12-21 Thread Brian Norris
On Mon, Dec 21, 2020 at 11:53 AM Kalle Valo wrote: > Brian Norris writes: > > On Sun, Dec 20, 2020 at 5:53 PM Miaoqing Pan > > wrote: > >> if (skb_queue_len(q) == ATH10K_MAX_NUM_MGMT_PENDING) { > > > > I believe you should be switching this to use skb_queue_len_lockless() > > too. > > W

Re: [PATCH] ath10k: fix wmi mgmt tx queue full due to race condition

2020-12-21 Thread Kalle Valo
Brian Norris writes: > Hi, > > On Sun, Dec 20, 2020 at 5:53 PM Miaoqing Pan wrote: >> >> Failed to transmit wmi management frames: >> >> [84977.840894] ath10k_snoc a00.wifi: wmi mgmt tx queue is full >> [84977.840913] ath10k_snoc a00.wifi: failed to transmit packet, >> dropping: -28 >>

Re: [PATCH] ath10k: fix wmi mgmt tx queue full due to race condition

2020-12-21 Thread Brian Norris
Hi, On Sun, Dec 20, 2020 at 5:53 PM Miaoqing Pan wrote: > > Failed to transmit wmi management frames: > > [84977.840894] ath10k_snoc a00.wifi: wmi mgmt tx queue is full > [84977.840913] ath10k_snoc a00.wifi: failed to transmit packet, dropping: > -28 > [84977.840924] ath10k_snoc a00.

[PATCH] ath10k: fix wmi mgmt tx queue full due to race condition

2020-12-20 Thread Miaoqing Pan
Failed to transmit wmi management frames: [84977.840894] ath10k_snoc a00.wifi: wmi mgmt tx queue is full [84977.840913] ath10k_snoc a00.wifi: failed to transmit packet, dropping: -28 [84977.840924] ath10k_snoc a00.wifi: failed to submit frame: -28 [84977.840932] ath10k_snoc a00.wi