Re: [PATCH 0/3] wifi: Un-embed ath10k and ath11k dummy netdev

2024-04-09 Thread Kalle Valo
Breno Leitao writes: > On Tue, Apr 09, 2024 at 01:03:21PM +0300, Kalle Valo wrote: > >> Breno Leitao writes: >> >> >> > Reading the issue, I am afraid that freeing netdev explicitly >> >> > (free_netdev()) might not be the best approach at the exit path. >> >> > >> >> > I would like to try to l

Re: [PATCH 0/3] wifi: Un-embed ath10k and ath11k dummy netdev

2024-04-09 Thread Breno Leitao
On Tue, Apr 09, 2024 at 01:03:21PM +0300, Kalle Valo wrote: > Breno Leitao writes: > > >> > Reading the issue, I am afraid that freeing netdev explicitly > >> > (free_netdev()) might not be the best approach at the exit path. > >> > > >> > I would like to try to leverage the ->needs_free_netdev n

Re: [PATCH 0/3] wifi: Un-embed ath10k and ath11k dummy netdev

2024-04-09 Thread Kalle Valo
Breno Leitao writes: >> > Reading the issue, I am afraid that freeing netdev explicitly >> > (free_netdev()) might not be the best approach at the exit path. >> > >> > I would like to try to leverage the ->needs_free_netdev netdev >> > mechanism to do the clean-up, if that makes sense. I've updat

Re: [PATCH 0/3] wifi: Un-embed ath10k and ath11k dummy netdev

2024-04-08 Thread Breno Leitao
On Mon, Apr 08, 2024 at 07:43:42PM +0300, Kalle Valo wrote: > Breno Leitao writes: > > On Fri, Apr 05, 2024 at 06:15:05PM +0300, Kalle Valo wrote: > >> Breno Leitao writes: > >> > >> > struct net_device shouldn't be embedded into any structure, instead, > >> > the owner should use the private sp

Re: [PATCH 0/3] wifi: Un-embed ath10k and ath11k dummy netdev

2024-04-08 Thread Kalle Valo
Breno Leitao writes: > Hello Kalle, > > On Fri, Apr 05, 2024 at 06:15:05PM +0300, Kalle Valo wrote: >> Breno Leitao writes: >> >> > struct net_device shouldn't be embedded into any structure, instead, >> > the owner should use the private space to embed their state into >> > net_device. >> > >>

Re: [PATCH 0/3] wifi: Un-embed ath10k and ath11k dummy netdev

2024-04-08 Thread Breno Leitao
Hello Kalle, On Fri, Apr 05, 2024 at 06:15:05PM +0300, Kalle Valo wrote: > Breno Leitao writes: > > > struct net_device shouldn't be embedded into any structure, instead, > > the owner should use the private space to embed their state into > > net_device. > > > > This patch set fixes the problem

Re: [PATCH 0/3] wifi: Un-embed ath10k and ath11k dummy netdev

2024-04-05 Thread Kalle Valo
Breno Leitao writes: > struct net_device shouldn't be embedded into any structure, instead, > the owner should use the private space to embed their state into > net_device. > > This patch set fixes the problem above for ath10k and ath11k. This also > fixes the conversion of qtnfmac driver to the

[PATCH 0/3] wifi: Un-embed ath10k and ath11k dummy netdev

2024-04-05 Thread Breno Leitao
struct net_device shouldn't be embedded into any structure, instead, the owner should use the private space to embed their state into net_device. This patch set fixes the problem above for ath10k and ath11k. This also fixes the conversion of qtnfmac driver to the new helper. This patch set depend