Re: [PATCH 1/2] dt-bindings: ath10k: Add vdd-smps supply

2023-03-03 Thread Kalle Valo
Konrad Dybcio writes: > On 3.03.2023 08:12, Krzysztof Kozlowski wrote: >> On 03/03/2023 03:42, Konrad Dybcio wrote: >>> Mention the newly added vdd-smps supply. >> >> There is no explanation here, but looking at your driver change it >> suggests name is not correct. You named it based on

Re: [PATCH 1/2] dt-bindings: ath10k: Add vdd-smps supply

2023-03-03 Thread Konrad Dybcio
On 3.03.2023 08:12, Krzysztof Kozlowski wrote: > On 03/03/2023 03:42, Konrad Dybcio wrote: >> Mention the newly added vdd-smps supply. > > There is no explanation here, but looking at your driver change it > suggests name is not correct. You named it based on regulator (so the > provider), not

Re: [PATCH 1/2] dt-bindings: ath10k: Add vdd-smps supply

2023-03-02 Thread Krzysztof Kozlowski
On 03/03/2023 03:42, Konrad Dybcio wrote: > Mention the newly added vdd-smps supply. There is no explanation here, but looking at your driver change it suggests name is not correct. You named it based on regulator (so the provider), not the consumer. Best regards, Krzysztof

[PATCH 1/2] dt-bindings: ath10k: Add vdd-smps supply

2023-03-02 Thread Konrad Dybcio
Mention the newly added vdd-smps supply. Signed-off-by: Konrad Dybcio --- Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt