Re: [PATCH 4/4] ath10k: snoc: fix unbalanced clock error handling

2018-11-06 Thread Kalle Valo
Doug Anderson writes: > Hi, > On Fri, Oct 12, 2018 at 5:55 PM Brian Norris wrote: >> >> Similar to regulator error handling, we should only start tearing down >> the 'i - 1' clock when clock 'i' fails to enable. Otherwise, we might >> end up with an unbalanced clock, where we never successfully

Re: [PATCH 4/4] ath10k: snoc: fix unbalanced clock error handling

2018-10-16 Thread Doug Anderson
Hi, On Fri, Oct 12, 2018 at 5:55 PM Brian Norris wrote: > > Similar to regulator error handling, we should only start tearing down > the 'i - 1' clock when clock 'i' fails to enable. Otherwise, we might > end up with an unbalanced clock, where we never successfully enabled the > clock, but we try

[PATCH 4/4] ath10k: snoc: fix unbalanced clock error handling

2018-10-12 Thread Brian Norris
Similar to regulator error handling, we should only start tearing down the 'i - 1' clock when clock 'i' fails to enable. Otherwise, we might end up with an unbalanced clock, where we never successfully enabled the clock, but we try to disable it anyway. Signed-off-by: Brian Norris --- drivers/ne