Re: [PATCH 4/4] mac80211: Sync airtime weight sum with per AC synced sta airtime weight together

2019-12-17 Thread Toke Høiland-Jørgensen
Johannes Berg writes: > I'm going to assume that Toke will review all of this and there will be > changes, so you'd resend anyway ... Yeah, this series doesn't even apply in its current form. I'll try to fix that, and do a few other updates that are needed while I'm at it. And to answer your

Re: [PATCH 4/4] mac80211: Sync airtime weight sum with per AC synced sta airtime weight together

2019-12-13 Thread Johannes Berg
I'm going to assume that Toke will review all of this and there will be changes, so you'd resend anyway ... > - * @airtime_weight: station weight for airtime fairness calculation purposes > + * @airtime_weight: station per-AC weight for airtime fairness calculation > + * purposes If you do,

[PATCH 4/4] mac80211: Sync airtime weight sum with per AC synced sta airtime weight together

2019-12-12 Thread Yibo Zhao
Global airtime weight sum is updated only when txq is added/removed from rbtree. If upper layer configures sta weight during high load, airtime weight sum will not be updated since txq is most likely on the tree. It could a little late for upper layer to reconfigure sta weight when txq is already

Re: [PATCH 4/4] mac80211: Sync airtime weight sum with per AC synced sta airtime weight together

2019-09-18 Thread Yibo Zhao
On 2019-09-18 05:24, Toke Høiland-Jørgensen wrote: Yibo Zhao writes: Global airtime weight sum is updated only when txq is added/removed from rbtree. If upper layer configures sta weight during high load, airtime weight sum will not be updated since txq is most likely on the tree. It could a

Re: [PATCH 4/4] mac80211: Sync airtime weight sum with per AC synced sta airtime weight together

2019-09-17 Thread Toke Høiland-Jørgensen
Yibo Zhao writes: > Global airtime weight sum is updated only when txq is added/removed > from rbtree. If upper layer configures sta weight during high load, > airtime weight sum will not be updated since txq is most likely on the > tree. It could a little late for upper layer to reconfigure sta

[PATCH 4/4] mac80211: Sync airtime weight sum with per AC synced sta airtime weight together

2019-09-16 Thread Yibo Zhao
Global airtime weight sum is updated only when txq is added/removed from rbtree. If upper layer configures sta weight during high load, airtime weight sum will not be updated since txq is most likely on the tree. It could a little late for upper layer to reconfigure sta weight when txq is already