Re: [PATCH net-next v6 03/10] net: create a dummy net_device allocator

2024-04-17 Thread Randy Dunlap
On 4/17/24 4:19 AM, Alexander Lobakin wrote: > From: Johannes Berg > Date: Wed, 17 Apr 2024 13:11:38 +0200 > >> On Wed, 2024-04-17 at 12:51 +0200, Alexander Lobakin wrote: >>> Just FYI: kdoc accepts only this pattern: >>> >>> * @last_param: blah >>> * >>> * Return: blah >>> >>> NOT >>> >>>

Re: [PATCH net-next v6 03/10] net: create a dummy net_device allocator

2024-04-17 Thread Alexander Lobakin
From: Johannes Berg Date: Wed, 17 Apr 2024 13:11:38 +0200 > On Wed, 2024-04-17 at 12:51 +0200, Alexander Lobakin wrote: >> Just FYI: kdoc accepts only this pattern: >> >> * @last_param: blah >> * >> * Return: blah >> >> NOT >> >> * Returns: blah > > Actually, it does accept that, the regex

Re: [PATCH net-next v6 03/10] net: create a dummy net_device allocator

2024-04-17 Thread Johannes Berg
On Wed, 2024-04-17 at 12:51 +0200, Alexander Lobakin wrote: > Just FYI: kdoc accepts only this pattern: > > * @last_param: blah > * > * Return: blah > > NOT > > * Returns: blah Actually, it does accept that, the regex is "returns?". It's just documented only as "Return" . IMHO it sometimes

Re: [PATCH net-next v6 03/10] net: create a dummy net_device allocator

2024-04-17 Thread Alexander Lobakin
From: Jakub Kicinski Date: Fri, 12 Apr 2024 19:16:26 -0700 > On Thu, 11 Apr 2024 06:59:27 -0700 Breno Leitao wrote: >> +/** >> + * alloc_netdev_dummy - Allocate and initialize a dummy net device. >> + * @sizeof_priv: size of private data to allocate space for >> + */ >> +struct net_device

Re: [PATCH net-next v6 03/10] net: create a dummy net_device allocator

2024-04-12 Thread Jakub Kicinski
On Thu, 11 Apr 2024 06:59:27 -0700 Breno Leitao wrote: > +/** > + * alloc_netdev_dummy - Allocate and initialize a dummy net device. > + * @sizeof_priv: size of private data to allocate space for > + */ > +struct net_device *alloc_netdev_dummy(int sizeof_priv) Sorry, one more round :) We started

[PATCH net-next v6 03/10] net: create a dummy net_device allocator

2024-04-11 Thread Breno Leitao
It is impossible to use init_dummy_netdev together with alloc_netdev() as the 'setup' argument. This is because alloc_netdev() initializes some fields in the net_device structure, and later init_dummy_netdev() memzero them all. This causes some problems as reported here: