On Sun, 2020-07-26 at 21:49 +0530, Rakesh Pillai wrote:
> We do have the usage of napi_gro_receive and netif_receive_skb in mac80211.
> /* deliver to local stack */
> if (rx->napi)
> napi_gro_receive(rx->napi, skb);
> else
>
27;kv...@codeaurora.org' ; 'da...@davemloft.net'
> ; 'k...@kernel.org' ;
> 'net...@vger.kernel.org' ;
> 'diand...@chromium.org' ;
> 'evgr...@chromium.org'
> Subject: RE: [RFC 1/7] mac80211: Add check for napi handle before
> W
et...@vger.kernel.org; diand...@chromium.org; evgr...@chromium.org
> Subject: Re: [RFC 1/7] mac80211: Add check for napi handle before
> WARN_ON
>
> On Thu, 2020-07-23 at 23:56 +0530, Rakesh Pillai wrote:
>
> > > > - WARN_ON_ONCE(softirq_count() == 0);
> >
On Thu, 2020-07-23 at 23:56 +0530, Rakesh Pillai wrote:
> > > - WARN_ON_ONCE(softirq_count() == 0);
> > > + WARN_ON_ONCE(napi && softirq_count() == 0);
> >
> > FWIW, I'm pretty sure this is incorrect - we make assumptions on
> > softirqs being disabled in mac80211 for serialization and in place o
@kernel.org;
> net...@vger.kernel.org; diand...@chromium.org; evgr...@chromium.org
> Subject: Re: [RFC 1/7] mac80211: Add check for napi handle before
> WARN_ON
>
> On Tue, 2020-07-21 at 22:44 +0530, Rakesh Pillai wrote:
> > The function ieee80211_rx_napi can be now called
> > fro
On Tue, 2020-07-21 at 22:44 +0530, Rakesh Pillai wrote:
> The function ieee80211_rx_napi can be now called
> from a thread context as well, with napi context
> being NULL.
>
> Hence add the napi context check before giving out
> a warning for softirq count being 0.
>
> Tested-on: WCN3990 hw1.0 SN
The function ieee80211_rx_napi can be now called
from a thread context as well, with napi context
being NULL.
Hence add the napi context check before giving out
a warning for softirq count being 0.
Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1
Signed-off-by: Rakesh Pillai
---
