Re: [PATCH v3] ath10k: support NET_DETECT WoWLAN feature

2019-10-02 Thread Brian Norris
Hi Kalle, Sorry, I failed to follow up on some of this. On Fri, Sep 20, 2019 at 12:32 AM Kalle Valo wrote: > But I mixed up the flags. I meant that can we enable > NL80211_FEATURE_SCAN_RANDOM_MAC_ADDR in ath10k? Does the firmware > releases which have WMI_SERVICE_NLO support >

RE: [PATCH v3] ath10k: support NET_DETECT WoWLAN feature

2019-09-20 Thread Wen Gong
> -Original Message- > From: Kalle Valo > Sent: Friday, September 20, 2019 3:32 PM > To: Wen Gong > Cc: Brian Norris ; linux-wireless wirel...@vger.kernel.org>; Linux Kernel ; > ath10k@lists.infradead.org; Wen Gong > Subject: [EXT] Re: [PATCH v3] ath10k: s

Re: [PATCH v3] ath10k: support NET_DETECT WoWLAN feature

2019-09-20 Thread Kalle Valo
>> >> Subject: [EXT] Re: [PATCH v3] ath10k: support NET_DETECT WoWLAN feature >> >> So essentially the problem is that with firmwares supporting both >> WMI_SERVICE_NLO and WMI_SERVICE_SPOOF_MAC_SUPPORT ath10k >> enables >> NL80211_FEATURE_SCAN_RANDOM_MAC_A

RE: [PATCH v3] ath10k: support NET_DETECT WoWLAN feature

2019-09-19 Thread Wen Gong
> -Original Message- > From: ath10k On Behalf Of Kalle Valo > Sent: Wednesday, September 18, 2019 10:03 PM > To: Brian Norris > Cc: linux-wireless ; Linux Kernel ker...@vger.kernel.org>; ath10k@lists.infradead.org; Wen Gong > > Subject: [EXT] Re: [PATCH v3] at

Re: [PATCH v3] ath10k: support NET_DETECT WoWLAN feature

2019-09-19 Thread Brian Norris
(I realize I replied to the v3, not the v4 which was merged.) On Wed, Sep 18, 2019 at 7:03 AM Kalle Valo wrote: > Brian Norris writes: > > Since Wen has once again suggested I use this patch in other forums, > > I'll ping here to note: > > > > On Wed, Nov 14, 2018 at 2:59 PM Brian Norris > >

Re: [PATCH v3] ath10k: support NET_DETECT WoWLAN feature

2019-09-18 Thread Kalle Valo
Brian Norris writes: > Since Wen has once again suggested I use this patch in other forums, > I'll ping here to note: > > On Wed, Nov 14, 2018 at 2:59 PM Brian Norris wrote: >> You've introduced a regression in 4.20-rc1: > > This regression still survives in the latest tree. Is it fair to just

Re: [PATCH v3] ath10k: support NET_DETECT WoWLAN feature

2019-09-17 Thread Brian Norris
Since Wen has once again suggested I use this patch in other forums, I'll ping here to note: On Wed, Nov 14, 2018 at 2:59 PM Brian Norris wrote: > You've introduced a regression in 4.20-rc1: This regression still survives in the latest tree. Is it fair to just submit a revert? Brian

Re: [PATCH v3] ath10k: support NET_DETECT WoWLAN feature

2018-11-14 Thread Brian Norris
Hi Wen, You've introduced a regression in 4.20-rc1: On Thu, Aug 16, 2018 at 02:48:33PM +0800, Wen Gong wrote: > For WoWLAN support, it expect to support wake up based on discovery of > one or more known SSIDs. This is the WIPHY_WOWLAN_NET_DETECT feature, > which shows up as an NL80211 feature

Re: [PATCH v3] ath10k: support NET_DETECT WoWLAN feature

2018-10-13 Thread Kalle Valo
Wen Gong wrote: > For WoWLAN support it is expected to support wake up based on discovery of > one or more known SSIDs. This is the WIPHY_WOWLAN_NET_DETECT feature, > which shows up as an NL80211 feature flag. > > This shows up in 'iw phy' as: > > WoWLAN support: > * wake up on network

Re: [PATCH v3] ath10k: support NET_DETECT WoWLAN feature

2018-10-12 Thread Kalle Valo
Wen Gong writes: > On 2018-09-04 19:43, Kalle Valo wrote: >> Wen Gong writes: >> > +enum wmi_nlo_cipher_algorithm { > +WMI_NLO_CIPHER_ALGO_NONE = 0x00, > +WMI_NLO_CIPHER_ALGO_WEP40 = 0x01, > +WMI_NLO_CIPHER_ALGO_TKIP =

Re: [PATCH v3] ath10k: support NET_DETECT WoWLAN feature

2018-09-04 Thread Wen Gong
On 2018-09-04 19:43, Kalle Valo wrote: Wen Gong writes: > +enum wmi_nlo_cipher_algorithm { > + WMI_NLO_CIPHER_ALGO_NONE = 0x00, > + WMI_NLO_CIPHER_ALGO_WEP40 = 0x01, > + WMI_NLO_CIPHER_ALGO_TKIP = 0x02, > + WMI_NLO_CIPHER_ALGO_CCMP = 0x04, > +

Re: [EXTERNAL] Re: [PATCH v3] ath10k: support NET_DETECT WoWLAN feature

2018-09-04 Thread Kalle Valo
Wen Gong writes: >> > +enum wmi_nlo_cipher_algorithm { >> > + WMI_NLO_CIPHER_ALGO_NONE = 0x00, >> > + WMI_NLO_CIPHER_ALGO_WEP40 = 0x01, >> > + WMI_NLO_CIPHER_ALGO_TKIP = 0x02, >> > + WMI_NLO_CIPHER_ALGO_CCMP = 0x04, >> > + WMI_NLO_CIPHER_ALGO_WEP104

RE: [EXTERNAL] Re: [PATCH v3] ath10k: support NET_DETECT WoWLAN feature

2018-09-04 Thread Wen Gong
> -Original Message- > From: ath10k On Behalf Of Kalle Valo > Sent: Tuesday, September 4, 2018 5:15 PM > To: Wen Gong > Cc: linux-wirel...@vger.kernel.org; ath10k@lists.infradead.org > Subject: [EXTERNAL] Re: [PATCH v3] ath10k: support NET_DETECT WoWLAN > feature

Re: [PATCH v3] ath10k: support NET_DETECT WoWLAN feature

2018-09-04 Thread Kalle Valo
Wen Gong writes: > For WoWLAN support, it expect to support wake up based on discovery of > one or more known SSIDs. This is the WIPHY_WOWLAN_NET_DETECT feature, > which shows up as an NL80211 feature flag. > > With an upgrade iw, this shows up in 'iw phy' as: > WoWLAN support: > * wake up on