Re: [PATCH 5/5] ath10k: pull_svc_rdy code-style fix

2019-10-04 Thread Jeff Johnson
On 2019-09-24 00:49, Tom Psyborg wrote: On 24/09/2019, Kalle Valo wrote: Tomislav Požega writes: Actually I prefer the original style, so that we first check the data in skb is valid and only then assign the data to ev. -- Kalle Valo It came to my mind that this might be the reason why t

Re: [PATCH 5/5] ath10k: pull_svc_rdy code-style fix

2019-09-24 Thread Tom Psyborg
On 24/09/2019, Kalle Valo wrote: > Tomislav Požega writes: > >> Drop unneeded lines by moving skb data in both main and 10x WMI >> pull service ready event operations. >> >> Signed-off-by: Tomislav Požega >> --- >> drivers/net/wireless/ath/ath10k/wmi.c |6 ++ >> 1 files changed, 2 inser

Re: [PATCH 5/5] ath10k: pull_svc_rdy code-style fix

2019-09-23 Thread Kalle Valo
Tomislav Požega writes: > Drop unneeded lines by moving skb data in both main and 10x WMI > pull service ready event operations. > > Signed-off-by: Tomislav Požega > --- > drivers/net/wireless/ath/ath10k/wmi.c |6 ++ > 1 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/dr