Re: regression in ath10k dma allocation

2019-08-20 Thread Tobias Klausmann
On 20.08.19 09:12, Christoph Hellwig wrote: On Tue, Aug 20, 2019 at 02:58:33PM +0800, Hillf Danton wrote: On Tue, 20 Aug 2019 05:05:14 +0200 Christoph Hellwig wrote: Tobias, plase try this patch: New version below: --- From b8a805e93be5a5662323b8ac61fe686df839c4ac Mon Sep 17 00:00:00

Re: regression in ath10k dma allocation

2019-08-20 Thread Christoph Hellwig
On Tue, Aug 20, 2019 at 02:58:33PM +0800, Hillf Danton wrote: > > On Tue, 20 Aug 2019 05:05:14 +0200 Christoph Hellwig wrote: > > > > Tobias, plase try this patch: > > New version below: --- >From b8a805e93be5a5662323b8ac61fe686df839c4ac Mon Sep 17 00:00:00 2001 From: Christoph Hellwig Date:

Re: regression in ath10k dma allocation

2019-08-20 Thread Hillf Danton
On Tue, 20 Aug 2019 05:05:14 +0200 Christoph Hellwig wrote: > > Tobias, plase try this patch: > A minute! > -- > >From 88c590a2ecafc8279388f25bfbe1ead8ea3507a6 Mon Sep 17 00:00:00 2001 > From: Christoph Hellwig > Date: Tue, 20 Aug 2019 11:45:49 +0900 > Subject: dma-direct: fix zone selection

Re: regression in ath10k dma allocation

2019-08-19 Thread Christoph Hellwig
Tobias, plase try this patch: -- >From 88c590a2ecafc8279388f25bfbe1ead8ea3507a6 Mon Sep 17 00:00:00 2001 From: Christoph Hellwig Date: Tue, 20 Aug 2019 11:45:49 +0900 Subject: dma-direct: fix zone selection after an unaddressable CMA allocation The new dma_alloc_contiguous hides if we allocate

Re: regression in ath10k dma allocation

2019-08-19 Thread Hillf Danton
On Tue, 20 Aug 2019 10:15:01 +0800 Christoph Hellwig wrote: > On Mon, Aug 19, 2019 at 06:58:52PM -0700, Nicolin Chen wrote: > > Right...the condition was in-between. However, not every caller > > of dma_alloc_contiguous() is supposed to have a coherent check. > > So we either add a 'bool

Re: regression in ath10k dma allocation

2019-08-19 Thread Christoph Hellwig
On Mon, Aug 19, 2019 at 06:58:52PM -0700, Nicolin Chen wrote: > Right...the condition was in-between. However, not every caller > of dma_alloc_contiguous() is supposed to have a coherent check. > So we either add a 'bool coherent_ok' to the API or revert the > dma-direct part back to the original.

Re: regression in ath10k dma allocation

2019-08-19 Thread Nicolin Chen
Hello Hillf, On Mon, Aug 19, 2019 at 12:38:38AM +0200, Tobias Klausmann wrote: > > On 18.08.19 05:13, Hillf Danton wrote: > > On Sat, 17 Aug 2019 00:42:48 +0200 Tobias Klausmann wrote: > > > Hi Nicolin, > > > > > > On 17.08.19 00:25, Nicolin Chen wrote: > > > > Hi Tobias > > > > > > > > On

Re: regression in ath10k dma allocation

2019-08-18 Thread Tobias Klausmann
On 18.08.19 05:13, Hillf Danton wrote: On Sat, 17 Aug 2019 00:42:48 +0200 Tobias Klausmann wrote: Hi Nicolin, On 17.08.19 00:25, Nicolin Chen wrote: Hi Tobias On Fri, Aug 16, 2019 at 10:16:45PM +0200, Tobias Klausmann wrote: do you have CONFIG_DMA_CMA set in your config? If not please

Re: regression in ath10k dma allocation

2019-08-17 Thread Hillf Danton
On Sat, 17 Aug 2019 00:42:48 +0200 Tobias Klausmann wrote: >Hi Nicolin, > >On 17.08.19 00:25, Nicolin Chen wrote: >> Hi Tobias >> >> On Fri, Aug 16, 2019 at 10:16:45PM +0200, Tobias Klausmann wrote: do you have CONFIG_DMA_CMA set in your config? If not please make sure you have this

Re: regression in ath10k dma allocation

2019-08-16 Thread Tobias Klausmann
Hi Nicolin, On 17.08.19 00:25, Nicolin Chen wrote: Hi Tobias On Fri, Aug 16, 2019 at 10:16:45PM +0200, Tobias Klausmann wrote: do you have CONFIG_DMA_CMA set in your config? If not please make sure you have this commit in your testing tree, and if the problem still persists it would be a

Re: regression in ath10k dma allocation

2019-08-16 Thread Nicolin Chen
Hi Tobias On Fri, Aug 16, 2019 at 10:16:45PM +0200, Tobias Klausmann wrote: > > do you have CONFIG_DMA_CMA set in your config? If not please make sure > > you have this commit in your testing tree, and if the problem still > > persists it would be a little odd and we'd have to dig deeper: > > >

Re: regression in ath10k dma allocation

2019-08-16 Thread Christoph Hellwig
Hi Tobias, do you have CONFIG_DMA_CMA set in your config? If not please make sure you have this commit in your testing tree, and if the problem still persists it would be a little odd and we'd have to dig deeper: commit dd3dcede9fa0a0b661ac1f24843f4a1b1317fdb6 Author: Nicolin Chen Date: Wed

regression in ath10k dma allocation

2019-08-16 Thread Tobias Klausmann
Hello all, within the current development cycle i noted the ath10k driver failing to setup: [    3.185660] ath10k_pci :02:00.0: failed to alloc CE dest ring 1: -12 [    3.185664] ath10k_pci :02:00.0: failed to allocate copy engine pipe 1: -12 [    3.185667] ath10k_pci :02:00.0: