Re: [ath5k-devel] ath5k_tasklet_rx BUG_ON(bf->skb == NULL)

2009-01-10 Thread Bob Copeland
On Sat, Jan 10, 2009 at 11:47:05AM -0500, Bob Copeland wrote: > Well I got a lockup doing that, I'll try again later but anyway I see > the bug already, read on if interested. I should have a patch shortly. Err, of course I would get a lockup, it's a BUG_ON. This patch seems to fix it for me.

Re: [ath5k-devel] ath5k_tasklet_rx BUG_ON(bf->skb == NULL)

2009-01-10 Thread Bob Copeland
On Fri, Jan 09, 2009 at 02:10:50PM +, Hugh Dickins wrote: > Good, that should be a lot quicker. Well I got a lockup doing that, I'll try again later but anyway I see the bug already, read on if interested. I should have a patch shortly. ath5k_tasklet_rx creates a new skb for every packet tha

Re: [ath5k-devel] [PATCH] ath5k: Add debug code for EEPROM

2009-01-10 Thread Jiri Slaby
Nick Kossifidis napsal(a): > Hello Jiri and thanks a lot for the review ;-) > > 2009/1/4 Jiri Slaby : >>> +/* debugfs: EEPROM stuff */ >>> + >>> +/* EEPROM Header (common) */ >>> +static ssize_t read_file_eeprom_header(struct file *file, char __user >>> *user_buf, >>> +

Re: [ath5k-devel] [PATCH] ath5k: Add debug code for EEPROM

2009-01-10 Thread Kalle Valo
"Nick Kossifidis" writes: >>> + struct ath5k_eeprom_info ee = ah->ah_capabilities.cap_eeprom; >>> + unsigned int len = 0; >>> + char buf[2000]; >> >> dtto >> > > What does dtto mean ? A typo from ditto: >From WordNet (r) 3.0 (2006) [wn]: ditto n 1: a mark used to indicate t