[ath5k-devel] [PATCH 7/7] ath5k: Don't call reset on config_interface

2009-02-08 Thread Nick Kossifidis
* We call reset too often and this can result various PHY problems. On config_interface we don't need to reset the whole device. TODO: Create a function hw_fast_reset that only resets the PCU (tx/rx stuff) and not the whole device so that we can use this for stuck beacons etc. Signed-o

[ath5k-devel] [PATCH 6/7] ath5k: Disable BMISS interrupts

2009-02-08 Thread Nick Kossifidis
* Don't enable BMISS interrupts as we don't handle them yet Signed-off-by: Nick Kossifidis diff --git a/drivers/net/wireless/ath5k/base.c b/drivers/net/wireless/ath5k/base.c index 697450d..685c19c 100644 --- a/drivers/net/wireless/ath5k/base.c +++ b/drivers/net/wireless/ath5k/base.c @@ -2196,

[ath5k-devel] [PATCH 5/7] ath5k: Update reset code

2009-02-08 Thread Nick Kossifidis
* Update reset and sync with HALs * Clean up eeprom settings and tweaking of initvals and put them on separate functions * Set/Restore 32KHz ref clk operation * Add some more documentation TODO: Spur mitigation, tpc, half/quarter rate, compression etc v2: Address comments from Bob and

[ath5k-devel] [PATCH 3/7] ath5k: Update RF Buffer handling

2009-02-08 Thread Nick Kossifidis
* Use the new way to modify rf buffer and put some rf buffer documentation on rfbufer.h * Merge all rf regs functions to one * Sync with legacy HAL and Sam's HAL * Set gain_F settings so that gain_F optimization engine works on RF5111/RF5112 (note that both HALs only use step 0 for RF5

[ath5k-devel] [PATCH 2/7] ath5k: Update gain_F calibration code and add documentation

2009-02-08 Thread Nick Kossifidis
* Update and cleanup rf gain optimization code * Add comments and refferences to docs and use sane function names * Use only step index on ath5k_gain, no need to have a pointer to the current step since we can determine te step from it's index, this also allows us to put all other st

Re: [ath5k-devel] ath5k_tasklet_rx BUG_ON(bf->skb == NULL)

2009-02-08 Thread Bob Copeland
On Fri, Feb 06, 2009 at 01:44:46PM -0500, John W. Linville wrote: > Hmmm...well it is a little big, but I guess it is OK. Do you have > an example of the stack trace? Or a link to a bugzilla or somesuch > would be even better... Here's an oops I captured by forcing an skb alloc to fail (transcri

Re: [ath5k-devel] [PATCH 5/5] ath5k: Update reset code

2009-02-08 Thread John W. Linville
On Sat, Feb 07, 2009 at 06:13:55PM +0200, Nick Kossifidis wrote: > 2009/2/7 Bob Copeland : > > On Sat, Feb 07, 2009 at 07:20:52AM +0200, Nick Kossifidis wrote: > >> O.K. do you want me to put these fixes on this patch or post a separate ? > > > > I think a separate patch is fine, it's a valid chang

Re: [ath5k-devel] [PATCH 5/5] ath5k: Update reset code

2009-02-08 Thread Nick Kossifidis
2009/2/8 John W. Linville : > On Sat, Feb 07, 2009 at 06:13:55PM +0200, Nick Kossifidis wrote: >> 2009/2/7 Bob Copeland : >> > On Sat, Feb 07, 2009 at 07:20:52AM +0200, Nick Kossifidis wrote: >> >> O.K. do you want me to put these fixes on this patch or post a separate ? >> > >> > I think a separat