Re: [ath5k-devel] [PATCH 1/3] ath5k: add support for radio LED

2009-05-20 Thread Tobias Doerffel
Hi, Am Mittwoch, 20. Mai 2009 22:08:57 schrieb Jiri Slaby: > From: Tobias Doerffel > > I found these patches on the web not being merged since Jan. Was > there any reason why they shouldn't be accepted? Yes - they needed further work. The approach was wrong because the GPIO does not control the

[ath5k-devel] [PATCH 3/3] ath5k: added support for radio LED on Samsung NC10

2009-05-20 Thread Jiri Slaby
From: Tobias Doerffel From: Tobias Doerffel Add support for a radio led on devices with subvendor 0x144f. That means don't register rx and tx leds for this particular device. Add a flag for that into driver_data. Signed-off-by: Tobias Doerffel Signed-off-by: Jiri Slaby [rebase] --- drivers

[ath5k-devel] [PATCH 1/3] ath5k: add support for radio LED

2009-05-20 Thread Jiri Slaby
From: Tobias Doerffel I found these patches on the web not being merged since Jan. Was there any reason why they shouldn't be accepted? As there were no replies to this version of them, I'm resending them for review and comments :). I rebased them and moved to the current approach in the led file

[ath5k-devel] [PATCH 2/3] ath5k: led, cleanup and prepare macros

2009-05-20 Thread Jiri Slaby
From: Jiri Slaby We need to use driver_data for more than pin and polaroty data. Remove driver_data designator from ATH_LED definition and write it explicitly. Signed-off-by: Jiri Slaby --- drivers/net/wireless/ath/ath5k/led.c | 33 + 1 files changed, 21 inser

Re: [ath5k-devel] [PATCH 1/3] ath5k: add support for radio LED

2009-05-20 Thread Bob Copeland
On Wed, May 20, 2009 at 4:33 PM, Tobias Doerffel wrote: > Should be rebased against wireless-testing branch (with the changed directory > structure), right? That would be ideal (if it still applies somewhat cleanly, you can just edit the patch paths directly). -- Bob Copeland %% www.bobcopeland

Re: [ath5k-devel] [PATCH 1/3] ath5k: add support for radio LED

2009-05-20 Thread Jiri Slaby
On 05/20/2009 10:16 PM, Tobias Doerffel wrote: > Hi, > > Am Mittwoch, 20. Mai 2009 22:08:57 schrieb Jiri Slaby: >> From: Tobias Doerffel >> >> I found these patches on the web not being merged since Jan. Was >> there any reason why they shouldn't be accepted? > Yes - they needed further work. The

Re: [ath5k-devel] [PATCH 1/3] ath5k: add support for radio LED

2009-05-20 Thread Tobias Doerffel
Am Mittwoch, 20. Mai 2009 22:29:42 schrieb Bob Copeland: > On Wed, 20 May 2009 22:16:42 +0200, Tobias Doerffel wrote > > > If there's interest, I'll prepare a new patch which represents the > > current state. > > I'm definitely interested in seeing rfkill gpio support getting in, > it's overdue.

Re: [ath5k-devel] [PATCH 1/3] ath5k: add support for radio LED

2009-05-20 Thread Bob Copeland
On Wed, 20 May 2009 22:16:42 +0200, Tobias Doerffel wrote > If there's interest, I'll prepare a new patch which represents the > current state. I'm definitely interested in seeing rfkill gpio support getting in, it's overdue. So I say repost it and we can fasttrack that. Digging up your last pa

[ath5k-devel] ath5k eeprom patch of linux2.6.30-rc6

2009-05-20 Thread forr...@hifulltech
Dear Bob, Another patch of ath5k FYI. Sincerely, Forrest - Original Message - From: "Bob Copeland" To: Cc: "Nick Kossifidis" ; Sent: Tuesday, May 12, 2009 10:46 PM Subject: RFC phy timing register bug > Hi all, > > Someone pointed out to me a change in the code with the reset rewor