[ath5k-devel] [PATCH 5/5] ath5k: write PCU registers on initial reset

2009-07-04 Thread Bob Copeland
Commit d7dc100374df0c21afd8a198336ecd7999697159, "Ath5k: unify resets" introduced a regression into 2.6.28 where the PCU registers are never initialized, due to ath5k_reset() always passing true for change_channel. We subsequently program a lot of these registers but several may start in an unknown

Re: [ath5k-devel] [PATCH 5/5] ath5k: write PCU registers on initial reset

2009-07-04 Thread Bob Copeland
>>       } >> -     ret = ath5k_hw_reset(ah, sc->opmode, sc->curchan, true); >> +     ret = ath5k_hw_reset(ah, sc->opmode, sc->curchan, chan == NULL); > > Shouldn't this be chan != NULL? I'd assume that chan is NULL the first > time and change_channel thus should be false to initialize all the > re

Re: [ath5k-devel] [PATCH 4/5] ath5k: do not release irq across suspend/resume

2009-07-04 Thread Rafael J. Wysocki
On Saturday 04 July 2009, Jiri Slaby wrote: > On 07/04/2009 06:59 PM, Bob Copeland wrote: > > Paraphrasing Rafael J. Wysocki: "drivers should not release PCI IRQs > > in suspend." Doing so causes a warning during suspend/resume on some > > platforms. > > Hmm, I added it because I was told an irq

Re: [ath5k-devel] [PATCH 4/5] ath5k: do not release irq across suspend/resume

2009-07-04 Thread Jiri Slaby
On 07/04/2009 06:59 PM, Bob Copeland wrote: > Paraphrasing Rafael J. Wysocki: "drivers should not release PCI IRQs > in suspend." Doing so causes a warning during suspend/resume on some > platforms. Hmm, I added it because I was told an irq can change over suspend (or at least it could in the pas

Re: [ath5k-devel] [PATCH 5/5] ath5k: write PCU registers on initial reset

2009-07-04 Thread Felix Fietkau
Bob Copeland wrote: > Commit d7dc100374df0c21afd8a198336ecd7999697159, "Ath5k: unify resets" > introduced a regression into 2.6.28 where the PCU registers are never > initialized, due to ath5k_reset() always passing true for change_channel. > We subsequently program a lot of these registers but sev

[ath5k-devel] [PATCH 4/5] ath5k: do not release irq across suspend/resume

2009-07-04 Thread Bob Copeland
Paraphrasing Rafael J. Wysocki: "drivers should not release PCI IRQs in suspend." Doing so causes a warning during suspend/resume on some platforms. Cc: Rafael J. Wysocki Reported-by: Alan Jenkins Signed-off-by: Bob Copeland --- drivers/net/wireless/ath/ath5k/base.c | 11 --- 1 file

[ath5k-devel] [PATCH 5/5] ath5k: write PCU registers on initial reset

2009-07-04 Thread Bob Copeland
Commit d7dc100374df0c21afd8a198336ecd7999697159, "Ath5k: unify resets" introduced a regression into 2.6.28 where the PCU registers are never initialized, due to ath5k_reset() always passing true for change_channel. We subsequently program a lot of these registers but several may start in an unknown

[ath5k-devel] [PATCH 1/5] ath5k: send buffered frames after the beacon

2009-07-04 Thread Bob Copeland
Enable the "Content" After Beacon queue and utilize it to send any buffered frames for power-saving clients. Signed-off-by: Bob Copeland --- drivers/net/wireless/ath/ath5k/base.c | 35 drivers/net/wireless/ath/ath5k/base.h |9 +++ drivers/net/wireless/a

[ath5k-devel] [PATCH 0/5] ath5k updates

2009-07-04 Thread Bob Copeland
I've been sitting on these patches for much too long. But anyway, here are some updates for ath5k. 1-2 fix beacon issues, 3 is just minor cleanup that I had sitting around forever, 4 is a reported suspend/resume issue from Alan Jenkins, and 5 is a reported initialization issue from Forrest Zhang.

[ath5k-devel] [PATCH 3/5] ath: remove unnecessary return in ath_regd_get_band_ctl

2009-07-04 Thread Bob Copeland
'default' case already returns NO_CTL Signed-off-by: Bob Copeland --- drivers/net/wireless/ath/regd.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/regd.c b/drivers/net/wireless/ath/regd.c index eef370b..f37c832 100644 --- a/drivers/net/wirele

[ath5k-devel] [PATCH 2/5] ath5k: rework beacon configuration

2009-07-04 Thread Bob Copeland
Using the enable_beacon flag allows some simplifications and fixes some corner cases in beacon handling. This change adds a state variable for beaconing in ath5k_beacon_config and handles both enabling and disabling, thus eliminating the need for ath5k_beacon_disable. We also now configure the be