[ath5k-devel] Ath5k and proprietary extensions

2009-08-28 Thread Nick Kossifidis
Since we started the discussion about ath5k and proprietary features i started a new thread to continue. So this is what we have... a) X.R.: eXtended Range is a set of proprietary rates and some extra techniques (various hw tweaks etc) to enable long distance, low bandwidth links. This feature wa

Re: [ath5k-devel] [PATCH 1/2] ath5k: fix uninitialized value use in ath5k_eeprom_read_turbo_modes()

2009-08-28 Thread Felix Fietkau
John W. Linville wrote: > I think I am on the side of removing the non-standard extensions. > FWIW, I'll need a patch posted with a proper Subject and > Signed-off-by... > > I think Nick has some valid points. His position sounds similar to > that expressed to me by Felix and some others that it

Re: [ath5k-devel] [PATCH 1/2] ath5k: fix uninitialized value use in ath5k_eeprom_read_turbo_modes()

2009-08-28 Thread John W. Linville
On Thu, Aug 27, 2009 at 04:14:56PM -0700, Luis R. Rodriguez wrote: > On Thu, Aug 27, 2009 at 2:39 PM, Bob Copeland wrote: > > On Thu, Aug 27, 2009 at 11:25:03AM -0700, Luis R. Rodriguez wrote: > >> > Well, we also don't use the turbo modes at all and that's where the > >> > error is (IIRC) so it sh

Re: [ath5k-devel] [PATCH 1/2] ath5k: fix uninitialized value use in ath5k_eeprom_read_turbo_modes()

2009-08-28 Thread Nick Kossifidis
2009/8/28 Luis R. Rodriguez : > On Thu, Aug 27, 2009 at 9:17 PM, Nick Kossifidis wrote: > >> Many people use turbo mode and it's not an ugly proprietary extension, static >> turbo mode is close to just having 40MHz channels, > > Its not following any spec and I suspect it will create pretty noise >