[ath5k-devel] [PATCH 3/4] ath5k: remove ah_mac_revision

it's not used, and we have ah_mac_srev. Signed-off-by: Bruno Randolf --- drivers/net/wireless/ath/ath5k/ath5k.h |1 - drivers/net/wireless/ath/ath5k/attach.c |1 - 2 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k/ath5k.h b/drivers/net/wirel

[ath5k-devel] [PATCH 4/4] ath5k: remove ah_gpio_npins

it's never used and we have a newer implementation in gpio.c. Signed-off-by: Bruno Randolf --- drivers/net/wireless/ath/ath5k/ath5k.h |2 -- drivers/net/wireless/ath/ath5k/caps.c |3 --- 2 files changed, 0 insertions(+), 5 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k/ath5k

[ath5k-devel] [PATCH 1/4] ath5k: remove double opmode definition

opmode (operating mode) was defined in struct ath5k_hw and struct ath5k_softc. remove it from ath5k_hw and use only from ath5k_softc (sc->opmode). (btw: what's the meaning of opmode when we have multiple interfaces?) Signed-off-by: Bruno Randolf --- drivers/net/wireless/ath/ath5k/ath5k.h |

[ath5k-devel] [PATCH 2/4] ath5k: remove ah_magic

it's never used. probably a leftover from the old OpenHAL days... Signed-off-by: Bruno Randolf --- drivers/net/wireless/ath/ath5k/ath5k.h |1 - drivers/net/wireless/ath/ath5k/desc.c |6 -- drivers/net/wireless/ath/ath5k/eeprom.h |3 --- 3 files changed, 0 insertions(+), 10 de

[ath5k-devel] [PATCH 0/4] ath5k cleanup

hi! this is a series of cleanup patches for ath5k. as the beginning of a larger initiative to merge ath5k_hw and ath5k_softc i have removed the double use of 'opmode' and removed some unused variables in ath5k_hw. please check if anyone still needs these definitions... thanks, bruno --- Bruno R

[ath5k-devel] [PATCH v2] ath5k: fix injection in monitor mode

injected frames have to use AR5K_PKT_TYPE_NORMAL, otherwise the hardware thinks it can mess with the contents of the frame - e.g. update the TSF of an injected beacon. injected frames should be sent as they are provided. Signed-off-by: Bruno Randolf --- drivers/net/wireless/ath/ath5k/base.c |

Re: [ath5k-devel] [PATCH 1/5] ath5k: fix injection in monitor mode

Actually, the right thing to check is info->flags & IEEE80211_TX_CTL_INJECTED - you shouldn't check the mode to determine injectedness. On Tue, Mar 2, 2010 at 2:17 AM, Bruno Randolf wrote: > On Tuesday 02 March 2010 06:26:48 Benoit PAPILLAULT wrote: >> Bruno Randolf a écrit : >> > please ignore t

Re: [ath5k-devel] [PATCH 1/5] ath5k: fix injection in monitor mode

On Tuesday 02 March 2010 06:26:48 Benoit PAPILLAULT wrote: > Bruno Randolf a écrit : > > please ignore this one, sorry ;( > > > > bruno > > This one is cool & needed for testing IBSS merges. I have pretty much > the same in my tree. yes - only sc->opmode is never set. i'll come up with a patch t

Re: [ath5k-devel] [PATCH 1/5] ath5k: fix injection in monitor mode

Bruno Randolf a écrit : > please ignore this one, sorry ;( > > bruno > This one is cool & needed for testing IBSS merges. I have pretty much the same in my tree. Regards, Benoit > On Monday 01 March 2010 20:59:03 Bruno Randolf wrote: > >> injected frames have to use AR5K_PKT_TYPE_NORMAL, ot

Re: [ath5k-devel] ath5k development status

Bruno Randolf a écrit : > hi! > > i think we don't need to worry too much about one or two register reads more > or less. (in my tests on a pretty slow board, one TSF register read needed > about 1,3us in average thru 1000 reads). > > also i can reproduce the wrap problems here on a 5414 chip. >

Re: [ath5k-devel] [PATCH 1/5] ath5k: fix injection in monitor mode

please ignore this one, sorry ;( bruno On Monday 01 March 2010 20:59:03 Bruno Randolf wrote: > injected frames have to use AR5K_PKT_TYPE_NORMAL, otherwise the hardware > thinks it can mess with the contents of the frame - e.g. update the TSF of > an injected beacon. injected frames should be sent

[ath5k-devel] [PATCH 5/5] ath5k: fix TSF reset

to reset the TSF, AR5K_BEACON_RESET_TSF has to be 1, not 0. also we have a function for that so use it. Signed-off-by: Bruno Randolf --- drivers/net/wireless/ath/ath5k/reset.c |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k/reset.c

[ath5k-devel] [PATCH 4/5] ath5k: preserve antenna settings

save antenna settings and preserve across resets. Signed-off-by: Bruno Randolf --- drivers/net/wireless/ath/ath5k/attach.c |1 + drivers/net/wireless/ath/ath5k/base.c |2 +- drivers/net/wireless/ath/ath5k/phy.c|1 + 3 files changed, 3 insertions(+), 1 deletions(-) diff --git

[ath5k-devel] [PATCH 3/5] ath5k: use fixed antenna for tx descriptors

when using a fixed antenna we should use the antenna number in all tx descriptors, otherwise the hardware will sometimes send the frame out on the other antenna. it seems like the hardware does not always respect the default antenna and diversity settings (esp. AR5K_STA_ID1_DEFAULT_ANTENNA). also

[ath5k-devel] [PATCH 1/5] ath5k: fix injection in monitor mode

injected frames have to use AR5K_PKT_TYPE_NORMAL, otherwise the hardware thinks it can mess with the contents of the frame - e.g. update the TSF of an injected beacon. injected frames should be sent as they are provided. Signed-off-by: Bruno Randolf --- drivers/net/wireless/ath/ath5k/base.c |

[ath5k-devel] [PATCH 2/5] ath5k: add antenna statistics and debugfs file for antenna settings

keep statistics about which antenna was used for TX and RX. this is used only for debugging right now, but might have other applications later. add a new file 'antenna' in debugfs (/sys/kernel/debug/ath5k/phy0/antenna) to show antenna use statistics and antenna diversity related register values.