Re: [ath5k-devel] [PATCH 05/13] ath5k: remove double opmode definition

2010-03-09 Thread Nick Kossifidis
2010/3/9 Bruno Randolf b...@einfach.org: opmode (operating mode) was defined in struct ath5k_hw and struct ath5k_softc. remove it from ath5k_hw and use only from ath5k_softc (sc-opmode). (btw: what's the meaning of opmode when we have multiple interfaces?) Signed-off-by: Bruno Randolf

Re: [ath5k-devel] [PATCH 11/13] ath5k: read eeprom IQ calibration values correctly for G mode

2010-03-09 Thread Nick Kossifidis
2010/3/9 Bruno Randolf b...@einfach.org: we read the IQ correction values (i_cal and q_cal) for G mode from a wrong location (the same shifts as for A mode is applied which is incorrect). use correct locations, matching the docs and HAL sources. also we should write IQ correction only when we

Re: [ath5k-devel] [PATCH 06/13] ath5k: remove ah_magic

2010-03-09 Thread Nick Kossifidis
2010/3/9 Bruno Randolf b...@einfach.org: it's never used. probably a leftover from the old OpenHAL days... Signed-off-by: Bruno Randolf b...@einfach.org ---  drivers/net/wireless/ath/ath5k/ath5k.h  |    1 -  drivers/net/wireless/ath/ath5k/desc.c   |    6 --  

[ath5k-devel] Stopping RTS/CTS packets

2010-03-09 Thread Raptor Victor
HI For my implementations where the whole network is in close vicinity of each other, i need to enable/disable the RTS/CTS packets to observe bandwidth behavior with or w/o RTS/CTS. The standard mention that for individually addressed MPDU, the value of RTS threshold can specify if one wants to

Re: [ath5k-devel] [PATCH 10/13] ath5k: fix I/Q calibration (for real)

2010-03-09 Thread Nick Kossifidis
2010/3/9 Bruno Randolf b...@einfach.org: I/Q calibration was completely broken, resulting in a high number of CRC errors on received packets. before i could see around 10% to 20% CRC errors, with this patch they are between 0% and 3%. 1.) the removal of the mask in commit ath5k: Fix I/Q

Re: [ath5k-devel] [PATCH 02/13] ath5k: use fixed antenna for tx descriptors

2010-03-09 Thread Nick Kossifidis
2010/3/9 Bruno Randolf b...@einfach.org: when using a fixed antenna we should use the antenna number in all tx descriptors, otherwise the hardware will sometimes send the frame out on the other antenna. it seems like the hardware does not always respect the default antenna and diversity

Re: [ath5k-devel] AP mode support in ath5k

2010-03-09 Thread Bob Copeland
On Tue, Mar 9, 2010 at 8:53 AM, Joerg Pommnitz pommn...@yahoo.com wrote: Hello all, seeing that there is a new burst of activity in ath5k I'd like to know whether there is any hope for reliable AP mode support. No, no hope at all! :) So, any ideas? What kind of client? What does 'iwconfig

Re: [ath5k-devel] Stopping RTS/CTS packets

2010-03-09 Thread Bob Copeland
On Tue, Mar 9, 2010 at 7:12 AM, Raptor Victor vrapt...@gmail.com wrote: I do remmeber hostapd giving an option of setting RTS threshold but i am not sure if we can use a value of zero to indicate that we do not need RTS/CTS. You can set the threshold with iwconfig. Usually it is disabled by

Re: [ath5k-devel] [PATCH 07/13] ath5k: remove ah_mac_revision

2010-03-09 Thread Nick Kossifidis
2010/3/9 Bruno Randolf b...@einfach.org: it's not used, and we have ah_mac_srev. Signed-off-by: Bruno Randolf b...@einfach.org ---  drivers/net/wireless/ath/ath5k/ath5k.h  |    1 -  drivers/net/wireless/ath/ath5k/attach.c |    1 -  2 files changed, 0 insertions(+), 2 deletions(-) diff

Re: [ath5k-devel] [PATCH 09/13] ath5k: add debugfs file frameerrors

2010-03-09 Thread Nick Kossifidis
2010/3/9 Bruno Randolf b...@einfach.org: add a debugfs file to see different RX and TX errors as reported in our status descriptors. this can help to diagnose driver problems. statistics can be cleared by writing 'clear' into the frameerrors file. example: # cat