[ath5k-devel] HAL style 0 ;)

2010-03-14 Thread Bruno Randolf
hey! look at that funky piece of code found in the HAL and also ath9k/ani.c: #define AR_MIBC_COW 0x0001 #define AR_MIBC_FMC 0x0002 #define AR_MIBC_CMC 0x0004 #define AR_MIBC_MCS 0x0008 REG_WRITE(ah, AR_MIBC, ~(AR_MIBC_COW | AR_MIBC_FM

[ath5k-devel] [AR2425] TX death on high load - are there hardware/software races?

2010-03-14 Thread Maxim Levitsky
One thing I noticed is racy behaviour of ath5k_txbuf_setup. ... spin_lock_bh(&txq->lock); list_add_tail(&bf->list, &txq->q); if (txq->link == NULL) /* is this first packet? */ ath5k_hw_set_txdp(ah, txq->qnum, bf->daddr); else /* no, so only link it

[ath5k-devel] [AR2425] TX death on high load

2010-03-14 Thread Maxim Levitsky
Hi, I have some interesting results in regard to long transmission blackouts I experience with my ath5k based wifi card (AR2424 inside aspire one). This is very old issue, and unfortunately I didn't have time to debug it properly. Fortunately, and strangely card works OK, if only used to surf the