Re: [ath5k-devel] HAL style 0 ;)

2010-03-16 Thread Luis R. Rodriguez
On Tue, Mar 16, 2010 at 03:46:57PM -0700, Benoit PAPILLAULT wrote: > Bruno Randolf a écrit : > > hey! > > > > look at that funky piece of code found in the HAL and also ath9k/ani.c: > > > > #define AR_MIBC_COW 0x0001 > > #define AR_MIBC_FMC 0x0002 > > #define AR_MIBC_CMC

Re: [ath5k-devel] HAL style 0 ;)

2010-03-16 Thread Benoit PAPILLAULT
Bruno Randolf a écrit : > hey! > > look at that funky piece of code found in the HAL and also ath9k/ani.c: > > #define AR_MIBC_COW 0x0001 > #define AR_MIBC_FMC 0x0002 > #define AR_MIBC_CMC 0x0004 > #define AR_MIBC_MCS 0x0008 > REG_WRITE(ah,

Re: [ath5k-devel] [AR2425] TX death on high load - are there hardware/software races?

2010-03-16 Thread Benoit PAPILLAULT
Bob Copeland a écrit : > On Sun, Mar 14, 2010 at 08:43:02PM +0200, Maxim Levitsky wrote: > >> One thing I noticed is racy behaviour of ath5k_txbuf_setup. >> >> .. >> >> spin_lock_bh(&txq->lock); >> list_add_tail(&bf->list, &txq->q); >> if (txq->link == NULL) /* is this first packe

[ath5k-devel] bug report: ath5k range checking

2010-03-16 Thread Dan Carpenter
drivers/net/wireless/ath/ath5k/phy.c +2603 ath5k_combine_pwr_to_pdadc_curves(66) 2587 /* If pdadc_0 is negative, we need to extrapolate 2588 * below this pdgain by a number of pwr_steps */ 2589 while ((pdadc_0 < 0) && (pdadc_i < 128)) {

Re: [ath5k-devel] [AR2425] TX death on high load - are there hardware/software races?

2010-03-16 Thread Bob Copeland
On Sun, Mar 14, 2010 at 08:43:02PM +0200, Maxim Levitsky wrote: > One thing I noticed is racy behaviour of ath5k_txbuf_setup. > > .. > > spin_lock_bh(&txq->lock); > list_add_tail(&bf->list, &txq->q); > if (txq->link == NULL) /* is this first packet? */ > ath5k_hw_s