Re: [ath5k-devel] [PATCH 3/5] ath5k: clean up queue manipulation

2010-03-30 Thread Bruno Randolf
On Wednesday 31 March 2010 12:58:47 Bob Copeland wrote: > On Wed, Mar 31, 2010 at 11:02:32AM +0900, Bruno Randolf wrote: > > we have to stop TX while NF calibration. also we need to lock it against > > other uses of reset / calibration. i think this is what gives us the > > problems with 'warm rese

Re: [ath5k-devel] [PATCH] ath5k: Use high bitrates for ACK/CTS

2010-03-30 Thread Duy Nguyen
oh i see, setting ack/cts to use high bit rates means the highest in the control basic rates group. Thanks. Duy On Tue, Mar 30, 2010 at 6:08 PM, Bruno Randolf wrote: > On Wednesday 31 March 2010 01:25:51 Duy Nguyen wrote: >> Hi, I am still a bit confused.  Hope you can help me clarify a bit. >

Re: [ath5k-devel] [PATCH 3/5] ath5k: clean up queue manipulation

2010-03-30 Thread Bob Copeland
On Wed, Mar 31, 2010 at 11:02:32AM +0900, Bruno Randolf wrote: > we have to stop TX while NF calibration. also we need to lock it against > other > uses of reset / calibration. i think this is what gives us the problems with > 'warm reset'. afaik other calibration can run in parallel. nick gave

Re: [ath5k-devel] [PATCH 3/5] ath5k: clean up queue manipulation

2010-03-30 Thread Bruno Randolf
On Tuesday 30 March 2010 21:42:30 Bob Copeland wrote: > > > In both cases the first reset works at cross purposes to the > > > goal of pausing transmissions, so nix them. > > > > i don't understand this sentence... > > Instead of "reset" I meant "the first wake_queues". Maybe this is clearer: >

Re: [ath5k-devel] [PATCH] ath5k: Use high bitrates for ACK/CTS

2010-03-30 Thread Bruno Randolf
On Wednesday 31 March 2010 01:25:51 Duy Nguyen wrote: > Hi, I am still a bit confused. Hope you can help me clarify a bit. > Shouldn't ACK/CTS always be sent at the low bit rate, in this case > 6MB, for reliability according to the spec? control frames have to be sent at one of the lower bitrates

[ath5k-devel] [014/116] ath5k: dont use external sleep clock in AP mode

2010-03-30 Thread Greg KH
2.6.32-stable review patch. If anyone has any objections, please let us know. -- From: Bob Copeland commit 5d6ce628f986d1a3c523cbb0a5a52095c48cc332 upstream When using the external sleep clock in AP mode, the TSF increments too quickly, causing beacon interval to be much lower

Re: [ath5k-devel] [AR2425] TX death on high load

2010-03-30 Thread Maxim Levitsky
On Sat, 2010-03-20 at 19:41 +0200, Maxim Levitsky wrote: > On Sun, 2010-03-14 at 18:33 +0200, Maxim Levitsky wrote: > > Hi, > > > > I have some interesting results in regard to long transmission blackouts > > I experience with my ath5k based wifi card (AR2424 inside aspire one). > > > > This is

Re: [ath5k-devel] [PATCH] ath5k: Use high bitrates for ACK/CTS

2010-03-30 Thread Duy Nguyen
Hi, I am still a bit confused. Hope you can help me clarify a bit. Shouldn't ACK/CTS always be sent at the low bit rate, in this case 6MB, for reliability according to the spec? Duy On Tue, Mar 30, 2010 at 3:59 AM, Bruno Randolf wrote: > There was a confusion in the usage of the bits AR5K_STA_I

Re: [ath5k-devel] [PATCH 3/5] ath5k: clean up queue manipulation

2010-03-30 Thread Bob Copeland
On Tue, Mar 30, 2010 at 02:40:57PM +0900, Bruno Randolf wrote: > On Monday 29 March 2010 10:42:11 Bob Copeland wrote: > > Review spotted a couple of strange invocations to > > ieee80211_wake_queues that could potentially cause problems: > > > > - queues are awakened in the calibration tasklet bef

[ath5k-devel] [PATCH] ath5k: Use high bitrates for ACK/CTS

2010-03-30 Thread Bruno Randolf
There was a confusion in the usage of the bits AR5K_STA_ID1_ACKCTS_6MB and AR5K_STA_ID1_BASE_RATE_11B. If they are set (1), we will get lower bitrates for ACK and CTS. Therefore ath5k_hw_set_ack_bitrate_high(ah, false) actually resulted in high bitrates, which i think is what we want anyways. Clear