Re: [ath5k-devel] corrupted data

2010-06-06 Thread Bob Copeland
On Sat, Jun 5, 2010 at 3:16 PM, Robert Brown robert.br...@gmail.com wrote: I transferred 1 Gb of data twice while executing the scan command as above. I got 3 corrupted blocks on the first transfer and 2 on the second, which is more than I normally expect.  Usually, I have to transfer 2 or 3 Gb

Re: [ath5k-devel] corrupted data

2010-06-06 Thread Nick Kossifidis
2010/6/6 Nick Kossifidis mickfl...@gmail.com: 2010/6/5 Benoit Papillault benoit.papilla...@free.fr: My feeling is that both RXDP TXDP registers are not properly initialized after a reset causing duplicate in both directions. So I believe you should see duplicate on the TX side as well.

Re: [ath5k-devel] corrupted data

2010-06-06 Thread Benoit Papillault
We read-and-clear RXDP on hw_nic_reset (actually we do that for any pending register writes -we need to ensure that all pending register writes are complete by doing a DMA register read, docs suggest RXDP and that's what we are doing on nic_reset, we need to change that comment-) and restore

Re: [ath5k-devel] corrupted data

2010-06-06 Thread Robert Brown
Sure, but I only see one place in ath5k_rxbuf_setup where it returns an error value (-ENOMEM). I'm using a 5/18/2010 snapshot. Should I grab a later version? Are there any cache issues when dealing with hardware devices like the Atheros chip? For instance, ath5k_rxbuf_setup sets up descriptors

[ath5k-devel] [PATCH 0/5] Series short description

2010-06-06 Thread Bruno Randolf
here i resend the missing ath5k patches rebased against current wireless-testing. bruno --- Bruno Randolf (5): ath5k: fix NULL pointer in antenna configuration ath5k: update AR5K_PHY_RESTART_DIV_GC values to match masks ath5k: new function for setting the antenna switch table

[ath5k-devel] [PATCH 1/5] ath5k: fix NULL pointer in antenna configuration

2010-06-06 Thread Bruno Randolf
If the channel is not set yet and we configure the antennas just store the setting. It will be activated during the next reset, when the channel is set. Signed-off-by: Bruno Randolf b...@einfach.org --- drivers/net/wireless/ath/ath5k/phy.c |7 +++ 1 files changed, 7 insertions(+), 0

[ath5k-devel] [PATCH 2/5] ath5k: update AR5K_PHY_RESTART_DIV_GC values to match masks

2010-06-06 Thread Bruno Randolf
#define AR5K_PHY_RESTART_DIV_GC 0x001c is 3 bit wide. The previous values of 0xc and 0x8 are 4bit wide and bigger than the mask. Writing 0 and 1 to AR5K_PHY_RESTART_DIV_GC is consistent with the comments and initvals we have in the HAL. Signed-off-by: Bruno Randolf

[ath5k-devel] [PATCH 3/5] ath5k: new function for setting the antenna switch table

2010-06-06 Thread Bruno Randolf
Collect all pieces concering the antenna switch table into one function. Previously it was split up between ath5k_hw_reset() and ath5k_hw_commit_eeprom_settings(). Also we need to set the antenna switch table when ath5k_hw_set_antenna_mode() is called manually (by iw phy0 antenna set, for

[ath5k-devel] [PATCH 5/5] ath5k: add debugfs file for queue debugging

2010-06-06 Thread Bruno Randolf
Signed-off-by: Bruno Randolf b...@einfach.org --- drivers/net/wireless/ath/ath5k/debug.c | 66 drivers/net/wireless/ath/ath5k/debug.h |1 2 files changed, 67 insertions(+), 0 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k/debug.c