[ath5k-devel] [PATCH v3 3/3] ath5k: Add support for antenna configuration

2010-06-07 Thread Bruno Randolf
Support setting the antenna configuration via cfg/mac80211. At the moment only allow the simple pre-defined configurations we already have (fixed antenna A/B or diversity), but more advanced settings are possible to implement. Signed-off-by: Bruno Randolf b...@einfach.org ---

Re: [ath5k-devel] [PATCH v3 1/3] cfg80211: Add nl80211 antenna configuration

2010-06-07 Thread Johannes Berg
On Mon, 2010-06-07 at 15:58 +0900, Bruno Randolf wrote: +static int nl80211_get_antenna(struct sk_buff *skb, struct genl_info *info) +{ + struct cfg80211_registered_device *rdev; + struct sk_buff *msg; + void *hdr; + int res; + u8 tx_ant, rx_ant; You should probably

Re: [ath5k-devel] [PATCH] [ath5k][leds] Ability to disable leds support. If leds support enabled do not force mac802.11 leds layer selection.

2010-06-07 Thread Dmytro Milinevskyy
Pavel, thank you for the response here. I agree with all your comments and will adjust the patch according to them. I'm new to the submitting patches into the community and I appreciate telling criticism so that in future I will not cause that much troubles. Regards, -- Dima On Fri, Jun 4,

Re: [ath5k-devel] corrupted data

2010-06-07 Thread Robert Brown
I think corruption of received data can happen whenever ath5k_reset is called when there are pending instances of ath5k_tasklet_rx scheduled, but not yet executed. ath5k_reset calls ath5k_rx_start to initialize the rxbuf queue, then sets RXDP to the head of the queue and turns DMA back on. At