Re: [ath5k-devel] [PATCH] ath5k: reorder base.c to remove fwd decls

2010-09-11 Thread Bob Copeland
On Sat, Sep 11, 2010 at 3:06 PM, Bob Copeland wrote: > This change reorganizes the main ath5k file in order to re-group > related functions and remove most of the forward declarations > (from 61 down to 3).  This is, unfortunately, a lot of churn, but > there should be no functional changes. Forg

Re: [ath5k-devel] [PATCH 0/8] ath: Move key cache functions to ath common

2010-09-11 Thread bob
On Wed, Sep 08, 2010 at 04:04:28PM +0900, Bruno Randolf wrote: > The following series moves the key cache management functions from ath9k to > the common ath/key.c so we can also use them from ath5k. Both ath5k and > ath9k are changed to use the common key functions. Nice, I always wanted us to do

Re: [ath5k-devel] [PATCH 6/8] ath5k: Use common crypt capabilities flags

2010-09-11 Thread bob
On Wed, Sep 08, 2010 at 04:04:59PM +0900, Bruno Randolf wrote: > Replace ah_aes_support and ah_combined_mic with common ath_crypt_caps > ATH_CRYPT_CAP_CIPHER_AESCCM and ATH_CRYPT_CAP_MIC_COMBINED. > > Signed-off-by: Bruno Randolf > --- a/drivers/net/wireless/ath/ath5k/base.c > +++ b/drivers/net/

Re: [ath5k-devel] [PATCH 5/8] ath/ath9k: Replace common->splitmic with a flag

2010-09-11 Thread bob
On Wed, Sep 08, 2010 at 04:04:54PM +0900, Bruno Randolf wrote: > Replace common->splitmic with ATH_CRYPT_CAP_MIC_COMBINED flag. > > splitmic has to be used when the ATH_CRYPT_CAP_MIC_COMBINED capability flag is > not set. > > Signed-off-by: Bruno Randolf Acked-by: Bob Copeland -- Bob Copelan

Re: [ath5k-devel] [PATCH 4/8] ath5k: Remove old ath5k key handling functions

2010-09-11 Thread bob
On Wed, Sep 08, 2010 at 04:04:49PM +0900, Bruno Randolf wrote: > Remove the old ath5k key handling functions, since we now use the key > management in ath common. > > Signed-off-by: Bruno Randolf Acked-by: Bob Copeland ___ ath5k-devel mailing list a

Re: [ath5k-devel] [PATCH 3/8] ath5k: Use common ath key management functions

2010-09-11 Thread me
On Wed, Sep 08, 2010 at 04:04:43PM +0900, Bruno Randolf wrote: > Use common ath key management functions in ath5k. This fixes problems with HW > encryption in AP mode, which was broken in the ath5k implementation. We went from this: > - key->flags |= (IEEE80211_KEY_FLAG_GENERATE_IV |