Re: [ath5k-devel] ATH5K diag register definition typos?

2010-09-26 Thread Jonathan Guerin
Changing the SIFS time (and hence the DIFS time) will not affect CCA - the card will still not transmit if it detects a carrier... Cheers, -- Jonathan Guerin On Mon, Sep 27, 2010 at 2:40 PM, shashi raj singh wrote: > Hi Ryan, > > I am also trying to stop CCA ... after some research, I found t

Re: [ath5k-devel] ATH5K diag register definition typos?

2010-09-26 Thread shashi raj singh
Hi Ryan, I am also trying to stop CCA ... after some research, I found these values. You can try these values and let me know if it works.(last time I saw, these values were not defined in ath5k reg.h) DIAG_FORCE_RXCLR(1<<20) DIAG_IGNORE_NAV (1<<21) code: you

[ath5k-devel] [PATCH] ath5k: Fix bitmasks and typos for PCU Diagnostic register

2010-09-26 Thread Bruno Randolf
As reported by Ryan Niemi, some bitmasks in the register definition for the PCU Diagnostic register (DIAG_SW) were missing a zero at the end. While at it fix some typos and add more comments. Signed-off-by: Bruno Randolf --- drivers/net/wireless/ath/ath5k/dma.c |4 ++-- drivers/net/wireless/

[ath5k-devel] [PATCH 4/4] ath5k: Disable interrupts in ath5k_hw_get_tsf64

2010-09-26 Thread Bruno Randolf
The code in ath5k_hw_get_tsf64() is time critical and will return wrong results if we get interrupted, so disable local interrupts. Signed-off-by: Bruno Randolf --- drivers/net/wireless/ath/ath5k/pcu.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/drivers/net/wire

[ath5k-devel] [PATCH 3/4] ath5k: Increase "fudge" for beacon timers

2010-09-26 Thread Bruno Randolf
We use FUDGE to make sure the next TBTT is ahead of the current TU. Since we later substract AR5K_TUNE_SW_BEACON_RESP (10) in the timer configuration we need to make sure it is bigger than that. Signed-off-by: Bruno Randolf --- drivers/net/wireless/ath/ath5k/base.c |7 +-- 1 files change

[ath5k-devel] [PATCH 2/4] ath5k: Check and fix ATIM window

2010-09-26 Thread Bruno Randolf
This patch adds sanity-checks for the beacon timers and especially the ATIM window to ath5k. It is basically the same what i did for madwifi two years ago and fixes a problem in IBSS mode which has been described as "ramping" pings. See the code comments for a more detailed description and these l

[ath5k-devel] [PATCH 1/4] ath5k: Remove unused variable for atim window

2010-09-26 Thread Bruno Randolf
It's not used and it's unlikely we will ever implement ATIM. Signed-off-by: Bruno Randolf --- drivers/net/wireless/ath/ath5k/ath5k.h |1 - drivers/net/wireless/ath/ath5k/attach.c |1 - drivers/net/wireless/ath/ath5k/pcu.c|2 +- 3 files changed, 1 insertions(+), 3 deletions(-) d

[ath5k-devel] [PATCH 0/4] ath5k: ATIM and timer fixes

2010-09-26 Thread Bruno Randolf
The following series adds a check for a hardware condition which can cause an unwanted ATIM window configuration and some other smaller improvements for TSF related things. --- Bruno Randolf (4): ath5k: Remove unused variable for atim window ath5k: Check and fix ATIM window ath5

Re: [ath5k-devel] ATH5K diag register definition typos?

2010-09-26 Thread Bruno Randolf
On Fri September 24 2010 08:00:23 Ryan Niemi wrote: > Hello, > > While investigating ways to disable CCA on a AR5212, I observed what may be > a couple typos in ath5k/reg.h (in the 2.6.35 kernel version at least): > > #define AR5K_DIAG_SW_RX_CLEAR_HIGH 0x001 /* Force RX Clear > hig