> From: "Dr. David Alan Gilbert" <li...@treblig.org> > To: n...@openwrt.org, "Wojciech Dubowik" <wojciech.dubo...@neratec.com>, > linvi...@tuxdriver.com > Cc: ath5k-devel@lists.ath5k.org > Sent: Sunday, January 9, 2011 1:13:13 AM > Subject: ath5k_pci_eeprom_read return values > Hi, > I've been running 'sparse' on the kernel and it spotted that in the > patch: > 'ath5k: Use generic eeprom read from common ath_bus_opts struct.' > > the function > bool ath5k_pci_eeprom_read(struct ath_common *common, u32 offset, u16 > *data) > > is declared 'bool' yet it returns 0, -EIO, or -ETIMEDOUT ; sparse > is saying that the -EIO/-ETIMEDOUT's will get truncated - so you > probably aren't getting what's expected.
That's correct. I will come up with the patch which cleans this part up. Wojtek > > Dave > > > -- > -----Open up your eyes, open up your mind, open up your code ------- > / Dr. David Alan Gilbert | Running GNU/Linux | Happy \ > \ gro.gilbert @ treblig.org | | In Hex / > \ _________________________|_____ http://www.treblig.org |_______/ _______________________________________________ ath5k-devel mailing list ath5k-devel@lists.ath5k.org https://lists.ath5k.org/mailman/listinfo/ath5k-devel
