Re: [ath5k-devel] Fwd: [PATCH 5/7] ath5k: remove ts_retry from ath5k_tx_status

2011-04-11 Thread Takayuki Kaiso
Hi, Let me ask one question. Isn't there any chance in which info->status.rates[x].count has different retry-count value from the one which the firmware actually did. For example, driver requests invalid retry count value and firmware rejects it. Such exceptional cases should be rare or

Re: [ath5k-devel] [PATCH 1/7] ath5k: optimize tx descriptor setup

2011-04-11 Thread Kalle Valo
Felix Fietkau writes: > Use local variables to reduce the number of load/store operations on uncached > memory. A comment in the code would be nice as well. Otherwise later on someone decides to "optimise" and remove the local variables :) > /* Clear descriptor */ > - memset(&desc->ud