On Wed, Apr 13, 2011 at 12:07 AM, Felix Fietkau wrote:
> Use local variables to reduce the number of load/store operations on uncached
> memory.
>
> Signed-off-by: Felix Fietkau
> ---
> drivers/net/wireless/ath/ath5k/desc.c | 45
> +++--
> 1 files changed, 26 inser
On 2011-04-12 9:04 AM, 海藻敬之 wrote:
> Hi,
>
> Isn't there any chance in which info->status.rates[x].count has
>different retry-count value from the one which the firmware actually did.
>
>For example, driver requests invalid value of retry count and firmware
> rejects it (take other value).
Use local variables to reduce the number of load/store operations on uncached
memory.
Signed-off-by: Felix Fietkau
---
drivers/net/wireless/ath/ath5k/desc.c | 45 +++--
1 files changed, 26 insertions(+), 19 deletions(-)
diff --git a/drivers/net/wireless/ath/ath5k/d
Use local variables to reduce the number of load/store operations on uncached
memory.
Signed-off-by: Felix Fietkau
---
drivers/net/wireless/ath/ath5k/desc.c | 45 +++--
1 files changed, 26 insertions(+), 19 deletions(-)
diff --git a/drivers/net/wireless/ath/ath5k/d
On 2011-04-11 8:29 AM, Kalle Valo wrote:
> Felix Fietkau writes:
>
>> Use local variables to reduce the number of load/store operations on
>> uncached
>> memory.
>
> A comment in the code would be nice as well. Otherwise later on
> someone decides to "optimise" and remove the local variables :)
Hi,
Isn't there any chance in which info->status.rates[x].count has
different retry-count value from the one which the firmware actually did.
For example, driver requests invalid value of retry count and firmware
rejects it (take other value).
no such chance ?
Thanks
Takayuki Kaiso
> Re