Re: [ath5k-devel] [PATCH v2 1/8] ath5k: add missing checks for rfgain probe

2011-07-04 Thread Felix Fietkau
On 2011-07-05 11:46 AM, Nick Kossifidis wrote: > 2011/7/5 Felix Fietkau: >> rfgain probe is only necessary for OFDM operation on AR5111 and AR5112. >> >> Signed-off-by: Felix Fietkau >> --- >>drivers/net/wireless/ath/ath5k/phy.c | 10 ++ >>1 files changed, 6 insertions(+), 4 del

Re: [ath5k-devel] [PATCH v2 1/8] ath5k: add missing checks for rfgain probe

2011-07-04 Thread Nick Kossifidis
2011/7/5 Felix Fietkau : > rfgain probe is only necessary for OFDM operation on AR5111 and AR5112. > > Signed-off-by: Felix Fietkau > --- >  drivers/net/wireless/ath/ath5k/phy.c |   10 ++ >  1 files changed, 6 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath5k/ph

Re: [ath5k-devel] WARNING: at kernel/timer.c:1011 del_timer_sync+0xa9/0xc4()

2011-07-04 Thread Mohammed Shafi
> > > FWIW below is my .config that I am using that seems to be having this > warning message show up. > > latest pull of the Mainline dmesg: >  http://fpaste.org/ > hello Justin, we doubt whether this patch is there in your linux-kernel tree you are using, even though it is there in wireless-tes

[ath5k-devel] [PATCH v2 7/8] ath5k: disable 32KHz sleep clock operation by default

2011-07-04 Thread Felix Fietkau
While 32 KHz sleep clock might provide some power saving benefits, it is also a major source of stability issues, on OpenWrt it produced some reproducible data bus errors on register accesses on several different MIPS platforms. All the Atheros drivers that I can find do not enable this feature, s

[ath5k-devel] [PATCH v2 6/8] ath5k: fix reference clock usec duration setting restore

2011-07-04 Thread Felix Fietkau
enabling the sleep clock alters the AR5K_USEC_32 field, but disabling it didn't restore it. Signed-off-by: Felix Fietkau Acked-by: Nick Kossifidis --- drivers/net/wireless/ath/ath5k/reset.c | 12 +++- 1 files changed, 11 insertions(+), 1 deletions(-) diff --git a/drivers/net/wireless

[ath5k-devel] [PATCH v2 5/8] ath5k: delay full calibration after reset

2011-07-04 Thread Felix Fietkau
During scans the full calibration usually does not make much sense, PAPD probing and IQ calibration should be deferred until there is enough time to complete them. Adding 100 ms to the initial full calibration delay should be enough to do this. Signed-off-by: Felix Fietkau Acked-by: Nick Kossifid

[ath5k-devel] [PATCH v2 8/8] ath5k: do not call ieee80211_stop_queue for queues not managed by mac80211

2011-07-04 Thread Felix Fietkau
Instead of using ieee80211_stop_queue, check the configured tx queue limit before calling ieee80211_get_buffered_bc. Signed-off-by: Felix Fietkau --- drivers/net/wireless/ath/ath5k/base.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/drivers/net/wireless/ath/ath5

[ath5k-devel] [PATCH v2 4/8] ath5k: initialize common->clockrate

2011-07-04 Thread Felix Fietkau
Fixes a division by zero when setting distance before activating the device for the first time. Signed-off-by: Felix Fietkau Acked-by: Nick Kossifidis --- drivers/net/wireless/ath/ath5k/base.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/net/wireless/ath/ath5

[ath5k-devel] [PATCH v2 3/8] ath5k: fix reference clock frequency for spur mitigation on AR2413

2011-07-04 Thread Felix Fietkau
AR2413 uses the same reference clock as AR5413 Signed-off-by: Felix Fietkau --- drivers/net/wireless/ath/ath5k/phy.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k/phy.c b/drivers/net/wireless/ath/ath5k/phy.c index a28ef9e..b6085d0 100644

[ath5k-devel] [PATCH v2 2/8] ath5k: apply the synth voltage tweak only on AR5112 rev 2

2011-07-04 Thread Felix Fietkau
Might fix some stability issues on newer chips Signed-off-by: Felix Fietkau Acked-by: Nick Kossifidis --- drivers/net/wireless/ath/ath5k/phy.c | 19 +++ 1 files changed, 11 insertions(+), 8 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k/phy.c b/drivers/net/wireless

[ath5k-devel] [PATCH v2 1/8] ath5k: add missing checks for rfgain probe

2011-07-04 Thread Felix Fietkau
rfgain probe is only necessary for OFDM operation on AR5111 and AR5112. Signed-off-by: Felix Fietkau --- drivers/net/wireless/ath/ath5k/phy.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k/phy.c b/drivers/net/wireless/ath/ath5k/p

Re: [ath5k-devel] [PATCH 7/8] ath5k: disable 32KHz sleep clock operation

2011-07-04 Thread Nick Kossifidis
2011/7/4 Kalle Valo : > Nick Kossifidis writes: > >> O.K. let's comment it out then and add some information that it's >> disabled by default on available HALs... > > Leaving dead code lying around is bad. Why not add a comment with some > pointers how to get the old code if someone wants to do th

Re: [ath5k-devel] [PATCH 7/8] ath5k: disable 32KHz sleep clock operation

2011-07-04 Thread Kalle Valo
Nick Kossifidis writes: > O.K. let's comment it out then and add some information that it's > disabled by default on available HALs... Leaving dead code lying around is bad. Why not add a comment with some pointers how to get the old code if someone wants to do that? For example git commit id is

Re: [ath5k-devel] [PATCH 4/8] ath5k: initialize common->clockrate

2011-07-04 Thread Nick Kossifidis
2011/7/4 Felix Fietkau : > On 2011-07-04 5:40 PM, Nick Kossifidis wrote: >> >> 2011/7/4 Felix Fietkau: >>> >>>  Fixes a division by zero when setting distance before activating the >>>  device for the first time. >>> >>>  Signed-off-by: Felix Fietkau >>>  --- >>>   drivers/net/wireless/ath/ath5k/ba

Re: [ath5k-devel] [PATCH 4/8] ath5k: initialize common->clockrate

2011-07-04 Thread Felix Fietkau
On 2011-07-04 5:40 PM, Nick Kossifidis wrote: > 2011/7/4 Felix Fietkau: >> Fixes a division by zero when setting distance before activating the >> device for the first time. >> >> Signed-off-by: Felix Fietkau >> --- >>drivers/net/wireless/ath/ath5k/base.c |1 + >>1 files changed, 1 i

Re: [ath5k-devel] [PATCH 4/8] ath5k: initialize common->clockrate

2011-07-04 Thread Nick Kossifidis
2011/7/4 Felix Fietkau : > Fixes a division by zero when setting distance before activating the > device for the first time. > > Signed-off-by: Felix Fietkau > --- >  drivers/net/wireless/ath/ath5k/base.c |    1 + >  1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/net/wir

Re: [ath5k-devel] [PATCH 5/8] ath5k: delay full calibration after reset

2011-07-04 Thread Nick Kossifidis
2011/7/4 Felix Fietkau : > During scans the full calibration usually does not make much sense, > PAPD probing and IQ calibration should be deferred until there is > enough time to complete them. Adding 100 ms to the initial full > calibration delay should be enough to do this. > > Signed-off-by: Fe

Re: [ath5k-devel] [PATCH 2/8] ath5k: apply the synth voltage tweak only on AR5112 rev 2

2011-07-04 Thread Nick Kossifidis
2011/7/4 Felix Fietkau : > Might fix some stability issues on newer chips > > Signed-off-by: Felix Fietkau > --- >  drivers/net/wireless/ath/ath5k/phy.c |   19 +++ >  1 files changed, 11 insertions(+), 8 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath5k/phy.c > b/driver

Re: [ath5k-devel] [PATCH 7/8] ath5k: disable 32KHz sleep clock operation

2011-07-04 Thread Nick Kossifidis
2011/7/4 Felix Fietkau : > While 32 KHz sleep clock might provide some power saving benefits, > it is also a major source of stability issues, on OpenWrt it produced > some reproducible data bus errors on register accesses on several > different MIPS platforms. > > All the Atheros drivers that I ca

Re: [ath5k-devel] [PATCH 3/8] ath5k: fix reference clock frequency for spur mitigation on AR2413

2011-07-04 Thread Nick Kossifidis
2011/7/4 Felix Fietkau : > AR2413 uses the same reference clock as AR5413 > > Signed-off-by: Felix Fietkau > --- >  drivers/net/wireless/ath/ath5k/phy.c |    1 + >  1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath5k/phy.c > b/drivers/net/wireless/ath/

Re: [ath5k-devel] [PATCH 6/8] ath5k: fix reference clock usec duration setting restore

2011-07-04 Thread Nick Kossifidis
2011/7/4 Felix Fietkau : > enabling the sleep clock alters the AR5K_USEC_32 field, but disabling > it didn't restore it. > > Signed-off-by: Felix Fietkau > --- >  drivers/net/wireless/ath/ath5k/reset.c |   11 ++- >  1 files changed, 10 insertions(+), 1 deletions(-) > > diff --git a/drivers

Re: [ath5k-devel] [PATCH 1/8] ath5k: add missing checks for rfgain probe

2011-07-04 Thread Nick Kossifidis
2011/7/4 Felix Fietkau : > rfgain probe is only necessary for OFDM operation on AR5112 and no other > radio chips > It's also available on RF5111 (with AR5211 or AR5212)... -- GPG ID: 0xD21DB2DB As you read this post global entropy rises. Have Fun ;-) Nick ___

Re: [ath5k-devel] [PATCH 7/8] ath5k: disable 32KHz sleep clock operation

2011-07-04 Thread Nick Kossifidis
2011/7/4 Felix Fietkau : > On 2011-07-04 4:58 PM, Nick Kossifidis wrote: >> >> 2011/7/4 Felix Fietkau: >>> >>>  While 32 KHz sleep clock might provide some power saving benefits, >>>  it is also a major source of stability issues, on OpenWrt it produced >>>  some reproducible data bus errors on reg

Re: [ath5k-devel] [PATCH 7/8] ath5k: disable 32KHz sleep clock operation

2011-07-04 Thread Felix Fietkau
On 2011-07-04 4:58 PM, Nick Kossifidis wrote: > 2011/7/4 Felix Fietkau: >> While 32 KHz sleep clock might provide some power saving benefits, >> it is also a major source of stability issues, on OpenWrt it produced >> some reproducible data bus errors on register accesses on several >> differen

Re: [ath5k-devel] [PATCH 1/8] ath5k: add missing checks for rfgain probe

2011-07-04 Thread Felix Fietkau
On 2011-07-04 4:48 PM, Nick Kossifidis wrote: > 2011/7/4 Felix Fietkau: >> rfgain probe is only necessary for OFDM operation on AR5112 and no other >> radio chips >> > > It's also available on RF5111 (with AR5211 or AR5212)... Oh, right, missed that. Will send a v2. - Felix _