[ath5k-devel] [PATCH 2/3] ath5k: remove most references to XR

2011-07-23 Thread Pavel Roskin
XR is a proprietary feature of the chipset. It's not supported and should not be supported. Signed-off-by: Pavel Roskin pro...@gnu.org --- drivers/net/wireless/ath/ath5k/ath5k.h | 26 -- drivers/net/wireless/ath/ath5k/eeprom.c |1 -

[ath5k-devel] [PATCH 1/3] ath5k: remove unused and write-only structures and fields

2011-07-23 Thread Pavel Roskin
struct ath5k_avg_val is unused. In struct ath5k_hw, lladdr, ah_radar and ah_mac_revision are write-only, rxbufsize is unused, ah_phy is write-only and referenced by unused macros. In struct ath5k_vif, lladdr is write-only. Remove AR5K_TUNE_RADAR_ALERT, which has no effect. Signed-off-by: Pavel

[ath5k-devel] [PATCH 3/3] ath5k: eliminate CHANNEL_* macros, use AR5K_MODE_* in channel-hw_value

2011-07-23 Thread Pavel Roskin
When checking for the band, use channel-band. Change ath5k_hw_nic_wakeup() and ath5k_channel_ok() to take ieee80211_channel. Change ath5k_hw_radio_revision() to take ieee80211_band. Signed-off-by: Pavel Roskin pro...@gnu.org --- drivers/net/wireless/ath/ath5k/ath5k.h | 32 +--

Re: [ath5k-devel] [PATCH] ath5k: remove duplicated #include

2011-07-23 Thread Sedat Dilek
On Sat, Jul 23, 2011 at 10:21 AM, Huang Weiyi weiyi.hu...@gmail.com wrote: Remove duplicated #include('s) in  drivers/net/wireless/ath/ath5k/ahb.c Signed-off-by: Huang Weiyi weiyi.hu...@gmail.com ---  drivers/net/wireless/ath/ath5k/ahb.c |    1 -  1 files changed, 0 insertions(+), 1

Re: [ath5k-devel] [PATCH 1/3] ath5k: remove unused and write-only structures and fields

2011-07-23 Thread Sedat Dilek
On Sat, Jul 23, 2011 at 9:21 AM, Pavel Roskin pro...@gnu.org wrote: struct ath5k_avg_val is unused. In struct ath5k_hw, lladdr, ah_radar and ah_mac_revision are write-only, rxbufsize is unused, ah_phy is write-only and referenced by unused macros. In struct ath5k_vif, lladdr is write-only.

Re: [ath5k-devel] [PATCH 3/3] ath5k: eliminate CHANNEL_* macros, use AR5K_MODE_* in channel-hw_value

2011-07-23 Thread Sedat Dilek
On Sat, Jul 23, 2011 at 9:21 AM, Pavel Roskin pro...@gnu.org wrote: When checking for the band, use channel-band. Change ath5k_hw_nic_wakeup() and ath5k_channel_ok() to take ieee80211_channel.  Change ath5k_hw_radio_revision() to take ieee80211_band. Signed-off-by: Pavel Roskin

Re: [ath5k-devel] [PATCH 2/3] ath5k: remove most references to XR

2011-07-23 Thread Nick Kossifidis
Could we leave the comments on ath5k.h and the rate code definitions ? I believe we should leave them there as reference... 2011/7/23 Pavel Roskin pro...@gnu.org: XR is a proprietary feature of the chipset.  It's not supported and should not be supported. Signed-off-by: Pavel Roskin

[ath5k-devel] [PATCH 2 1/3] ath5k: remove unused and write-only structures and fields

2011-07-23 Thread Pavel Roskin
struct ath5k_avg_val is unused. In struct ath5k_hw, lladdr, ah_radar and ah_mac_revision are write-only, rxbufsize is unused, ah_phy is write-only and referenced by unused macros. In struct ath5k_vif, lladdr is write-only. Remove AR5K_TUNE_RADAR_ALERT, which has no effect. Signed-off-by: Pavel

[ath5k-devel] [PATCH 2 2/3] ath5k: remove most references to XR

2011-07-23 Thread Pavel Roskin
XR is a proprietary feature of the chipset. It's not supported and should not be supported. Signed-off-by: Pavel Roskin pro...@gnu.org Tested-by: Sedat Dilek sedat.di...@gmail.com --- drivers/net/wireless/ath/ath5k/ath5k.h |4 drivers/net/wireless/ath/ath5k/eeprom.c |1 -

[ath5k-devel] [PATCH 2 3/3] ath5k: eliminate CHANNEL_* macros, use AR5K_MODE_* in channel-hw_value

2011-07-23 Thread Pavel Roskin
When checking for the band, use channel-band. Change ath5k_hw_nic_wakeup() and ath5k_channel_ok() to take ieee80211_channel. Change ath5k_hw_radio_revision() to take ieee80211_band. Signed-off-by: Pavel Roskin pro...@gnu.org Tested-by: Sedat Dilek sedat.di...@gmail.com ---

Re: [ath5k-devel] [PATCH 2 2/3] ath5k: remove most references to XR

2011-07-23 Thread Nick Kossifidis
2011/7/23 Pavel Roskin pro...@gnu.org: XR is a proprietary feature of the chipset.  It's not supported and should not be supported. Signed-off-by: Pavel Roskin pro...@gnu.org Tested-by: Sedat Dilek sedat.di...@gmail.com ---  drivers/net/wireless/ath/ath5k/ath5k.h  |    4  

Re: [ath5k-devel] [PATCH 2 1/3] ath5k: remove unused and write-only structures and fields

2011-07-23 Thread Nick Kossifidis
2011/7/23 Pavel Roskin pro...@gnu.org: struct ath5k_avg_val is unused. In struct ath5k_hw, lladdr, ah_radar and ah_mac_revision are write-only, rxbufsize is unused, ah_phy is write-only and referenced by unused macros. In struct ath5k_vif, lladdr is write-only. Remove

Re: [ath5k-devel] [PATCH 2 3/3] ath5k: eliminate CHANNEL_* macros, use AR5K_MODE_* in channel-hw_value

2011-07-23 Thread Nick Kossifidis
2011/7/23 Pavel Roskin pro...@gnu.org: When checking for the band, use channel-band. Change ath5k_hw_nic_wakeup() and ath5k_channel_ok() to take ieee80211_channel.  Change ath5k_hw_radio_revision() to take ieee80211_band. Signed-off-by: Pavel Roskin pro...@gnu.org Tested-by: Sedat Dilek

Re: [ath5k-devel] [PATCH 2/3] ath5k: remove most references to XR

2011-07-23 Thread Nick Kossifidis
2011/7/23 Pavel Roskin pro...@gnu.org: Quoting Nick Kossifidis mickfl...@gmail.com: Could we leave the comments on ath5k.h and the rate code definitions ? I believe we should leave them there as reference... Sure.  Version 2 has been sent. Thanks a lot ;-) -- GPG ID: 0xD21DB2DB As you

Re: [ath5k-devel] [PATCH v2] ath5k: merge ath5k_hw and ath5k_softc

2011-07-23 Thread Sedat Dilek
On Wed, Jul 20, 2011 at 11:59 PM, Pavel Roskin pro...@gnu.org wrote: Quoting John W. Linville linvi...@tuxdriver.com: I already merged a version that incorporated Sedat's change on top of your.  If that isn't what you want, please post your change as a patch on top. The remaining changes