Re: [ath5k-devel] [PATCH 1/5] ath: add common function ath_is_mybeacon

2014-01-16 Thread Antonio Quartulli
On 15/01/14 17:07, Oleksij Rempel wrote: > this function is used by most ath driver, so it can be moved here. > > Signed-off-by: Oleksij Rempel > --- > drivers/net/wireless/ath/ath.h | 2 ++ > drivers/net/wireless/ath/main.c | 11 +++ > 2 files changed, 13 insertions(+) > > diff --git

Re: [ath5k-devel] [PATCH 1/5] ath: add common function ath_is_mybeacon

2014-01-16 Thread Kalle Valo
Oleksij Rempel writes: > +bool ath_is_mybeacon(struct ath_common *common, struct ieee80211_hdr *hdr) Would a static inline be better? At least on ath9k I suspect the compiler automatically inlines the static function, after your patch there's an extra function call. -- Kalle Valo _