Re: [ath5k-devel] [PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use

2014-07-20 Thread David Miller
From: Benoit Taine Date: Fri, 18 Jul 2014 17:26:47 +0200 > We should prefer `const struct pci_device_id` over > `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines. > This issue was reported by checkpatch. > > A simplified version of the semantic patch that makes this change is as >

Re: [ath5k-devel] [PATCH 1/3] drivers/net: Convert compare_ether_addr to ether_addr_equal

2012-05-10 Thread David Miller
From: Joe Perches Date: Wed, 9 May 2012 20:17:46 -0700 > Use the new bool function ether_addr_equal to add > some clarity and reduce the likelihood for misuse > of compare_ether_addr for sorting. > > Done via cocci script: ... > Signed-off-by: Joe Perches Applied. ___

Re: [ath5k-devel] [PATCH 1/3] drivers/net: Convert compare_ether_addr to ether_addr_equal

2012-05-10 Thread David Miller
Never, EVER, quote an entire large patch just to make a comment on one small hunk. I very nearly missed what you had to say because when scrolling through it it appeared as if you made no comments at all. Again, NEVER, EVER, do this. It's extremely anti-social. Edit out the irrelevant quoted c

Re: [ath5k-devel] [PATCH 00/62] drivers/net: Use static const

2010-11-23 Thread David Miller
From: Joe Perches Date: Mon, 22 Nov 2010 14:40:05 -0800 > I'll see who picks up or acks what and send a pull request to > you for the remainder of these patches mid December or so. Thanks. > Do you want micro patches or a single patch? You can group them by directory or similar if you like. F

Re: [ath5k-devel] [PATCH 00/62] drivers/net: Use static const

2010-11-22 Thread David Miller
From: Joe Perches Date: Mon, 22 Nov 2010 14:10:46 -0800 > btw: it doesn't seem that, other than John Linville for wireless, > you currently pull from many (any?) other people. Do let me know > if you'd consider pulling these sorts of changes from me. Expand your horizon beyond drivers/net/ and

Re: [ath5k-devel] [PATCH 00/62] drivers/net: Use static const

2010-11-20 Thread David Miller
From: Joe Perches Date: Sat, 20 Nov 2010 18:38:01 -0800 > Using static const generally increases object text and decreases data size. > It also generally decreases overall object size. Joe, I'm going to be frank and say that I'm not going to review and apply such a large chunk of networking patc