On Sun, 2014-02-09 at 19:47 +0100, Richard Weinberger wrote:
The symbol is an orphan, get rid of it.
This description seems very incomplete as the symbol
is being used quite a bit and the code the symbol
controls is being deleted as well as the symbol.
On Thu, 2013-11-07 at 07:32 +, Eugene Krasnikov wrote:
Hi Joe,
Hi Eugene.
I personally like the idea of making some kind of framework on top of
printing because all ath drivers are using the same printing approach
and combining all that code in one place will reduce amount of code in
(a, b) == 0
+ !ether_addr_equal(a, b)
@@
expression a,b;
@@
- ether_addr_equal(a, b) != 0
+ ether_addr_equal(a, b)
@@
expression a,b;
@@
- !!ether_addr_equal(a, b)
+ ether_addr_equal(a, b)
Signed-off-by: Joe Perches j...@perches.com
---
drivers/net/bonding/bond_main.c
On Sun, 2012-03-18 at 21:36 -0700, Adrian Chadd wrote:
Hi,
Hi Adrian.
So the reason this is a macro in the FreeBSD HAL is so that the args
aren't evaluated unless the level (or debug bitmap in my case) fires
off.
Otherwise compiling in debugging will cause a _lot_ of spurious
register
Signed-off-by: Joe Perches j...@perches.com
---
drivers/net/wireless/ath/ath5k/desc.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/net/wireless/ath/ath5k/desc.c
b/drivers/net/wireless/ath/ath5k/desc.c
index 62172d5..f82383b 100644
--- a/drivers/net/wireless
Found by grep. Uncompiled/untested.
Joe Perches (5):
gpio-tps65910.c: Add missing breaks in switch/case
tps65910-irq: Add missing breaks in switch/case
ath5k: Add missing breaks in switch/case
fusb300_udc: Add missing breaks in switch/case
dbri: Add missing breaks in switch/case
On Wed, 2011-01-05 at 14:22 -0500, John W. Linville wrote:
diff --git a/drivers/net/wireless/ath/ath.h b/drivers/net/wireless/ath/ath.h
[]
+ bool nohwcrypt;
diff --git a/drivers/net/wireless/ath/ath5k/base.c
b/drivers/net/wireless/ath/ath5k/base.c
-int modparam_nohwcrypt;
+static int
On Wed, 2011-01-05 at 14:49 -0500, Bob Copeland wrote:
On Wed, Jan 5, 2011 at 2:40 PM, Joe Perches j...@perches.com wrote:
On Wed, 2011-01-05 at 14:22 -0500, John W. Linville wrote:
diff --git a/drivers/net/wireless/ath/ath.h
b/drivers/net/wireless/ath/ath.h
[]
+ bool nohwcrypt
, multiple
prints, and 1 loop which can exceed array bounds.
Bundled and integrated the individual patches into a single patch series.
Joe Perches (4):
ath: Add and use ath_printk and ath_level
ath: Convert ath_print(.., ATH_DBG_FATAL to ath_err
ath: Convert ath_print to ath_dbg
ath: Fix ath_dbg
Fix immunity misspelling.
Standardize strings from multiple modules.
Add spaces between words of concatenated strings.
Signed-off-by: Joe Perches j...@perches.com
---
drivers/net/wireless/ath/ath5k/ani.c |2 +-
drivers/net/wireless/ath/ath9k/ar9002_calib.c |4 ++--
drivers/net
On Thu, 2010-12-02 at 06:30 +0100, Peter Stuge wrote:
Joe Perches wrote:
+++ b/drivers/net/wireless/ath/ath9k/ar9002_calib.c
..
@@ -734,7 +734,7 @@ static bool ar9285_hw_cl_cal(struct ath_hw *ah, struct
ath9k_channel *chan)
if (!ath9k_hw_wait(ah, AR_PHY_AGC_CONTROL
Fix immunity misspelling.
Standardize strings from multiple modules.
Add spaces between words of concatenated strings.
Signed-off-by: Joe Perches j...@perches.com
---
V2: Fix a newly introduced tyop...
drivers/net/wireless/ath/ath5k/ani.c |2 +-
drivers/net/wireless/ath/ath9k
On Sat, 2010-11-20 at 20:50 -0800, David Miller wrote:
From: Joe Perches j...@perches.com
Date: Sat, 20 Nov 2010 18:38:01 -0800
Using static const generally increases object text and decreases data size.
It also generally decreases overall object size.
Joe, I'm going to be frank
On Mon, 2010-11-22 at 14:19 -0800, David Miller wrote:
From: Joe Perches j...@perches.com
Date: Mon, 22 Nov 2010 14:10:46 -0800
Do let me know if you'd consider pulling these sorts of
changes from me.
Expand your horizon beyond drivers/net/ and into places like net/
and you'll see I also
2074597 70614 48 2611879 27daa7 (TOTALS) -old
Joe Perches (62):
3c501: Use static const
3c503: Use static const
3c507: Use static const
3c527: Use static const
at1700: Use static const
benet: Use static const
bnx2: Use static const
bnx2x: Use static const
can: Use static const
drivers/net/wireless/ath/ath5k/ani.o.new
Signed-off-by: Joe Perches j...@perches.com
---
drivers/net/wireless/ath/ath5k/ani.c | 34 +-
1 files changed, 17 insertions(+), 17 deletions(-)
diff --git a/drivers/net/wireless/ath/ath5k/ani.c
b/drivers/net/wireless/ath
On Fri, 2010-07-23 at 12:04 +0200, Dan Carpenter wrote:
This is a smatch thing. I suppose someday I will fix smatch to
evaulate the strings themselves and verify that the buffer is large
enough. But for now it's nice to be able to automatically check that
the buffers don't overflow.
There
(test == true) is not nice.
Signed-off-by: Joe Perches [EMAIL PROTECTED]
drivers/net/wireless/ath5k/hw.c | 42 +++---
drivers/net/wireless/ath5k/phy.c | 10
2 files changed, 26 insertions(+), 26 deletions(-)
diff --git a/drivers/net/wireless/ath5k
18 matches
Mail list logo
