[ath5k-devel] [PATCH] ath5k: depend on CONFIG_PM_SLEEP for suspend/resume functions

2010-05-29 Thread Tobias Doerffel
/net/wireless/ath/ath5k/base.c:722:12: warning: ‘ath5k_pci_resume’ defined but not used Depending on CONFIG_PM_SLEEP rather than CONFIG_PM fixes the issue. Signed-off-by: Tobias Doerffel --- drivers/net/wireless/ath/ath5k/base.c |8 1 files changed, 4 insertions(+), 4 deletions

[ath5k-devel] Commit 6b5d11 breaks association with WPA enabled APs

2010-05-29 Thread Tobias Doerffel
Hi, using the latest kernel (Linus master branch) breaks my wireless connection (ath5k/AR5001), i.e. I'm not able to connect to my WPA-secured AP anymore. It's been working fine up to (and including) 2.6.34. Verbose output of wpa_supplicant: Selecting BSS from priority group 0 Try to find WPA-

Re: [ath5k-devel] [PATCH] ath5k: added cfg80211 based rfkill support

2009-06-09 Thread Tobias Doerffel
Hi, Am Dienstag, 9. Juni 2009 20:26:12 schrieb Bob Copeland: > > + /* enable RFKILL when stopping HW so Wifi LED is turned off */ > > + ath5k_rfkill_enable(sc); > > Odd, but ok :) Why odd? As a user if I disable Wifi (i.e. enable rfkill, be it via software or rfkill switch), I do not

[ath5k-devel] [PATCH] ath5k: added cfg80211 based rfkill support

2009-06-09 Thread Tobias Doerffel
ernal 32KHz crystal when sleeping if one diff --git a/drivers/net/wireless/ath/ath5k/rfkill.c b/drivers/net/wireless/ath/ath5k/rfkill.c new file mode 100644 index 000..492ada9 --- /dev/null +++ b/drivers/net/wireless/ath/ath5k/rfkill.c @@ -0,0 +1,121 @@ +/* + * RFKILL support for ath5k + * + * Co

[ath5k-devel] [PATCH] ath5k: added cfg80211 based rfkill support

2009-06-07 Thread Tobias Doerffel
/net/wireless/ath/ath5k/rfkill.c new file mode 100644 index 000..b57ab27 --- /dev/null +++ b/drivers/net/wireless/ath/ath5k/rfkill.c @@ -0,0 +1,120 @@ +/* + * RFKILL support for ath5k + * + * Copyright (c) 2009 Tobias Doerffel + * + * All rights reserved. + * + * Redistribution and use

Re: [ath5k-devel] [PATCH] ath5k: added initial RFKILL support

2009-05-29 Thread Tobias Doerffel
Hi, Am Dienstag, 26. Mai 2009 01:32:46 schrieb Johannes Berg: > On Tue, 2009-05-26 at 01:24 +0200, Tobias Doerffel wrote: > > + err = rfkill_register(sc->rf_kill.rfkill); > > + if (err) { > > + sc->rf_kill.rfkill = NULL; &g

[ath5k-devel] [PATCH] ath5k: added initial RFKILL support

2009-05-25 Thread Tobias Doerffel
addressed all remarks in the last review by Bob Copeland. Regards, Toby From 0dfab8fbd3223747e2a7948296606e661899630b Mon Sep 17 00:00:00 2001 From: Tobias Doerffel Date: Tue, 26 May 2009 00:52:20 +0200 Subject: [PATCH] ath5k: added initial RFKILL support This patch introduces initial RFKILL supp

Re: [ath5k-devel] [PATCH 1/3] ath5k: add support for radio LED

2009-05-20 Thread Tobias Doerffel
Hi, Am Mittwoch, 20. Mai 2009 22:08:57 schrieb Jiri Slaby: > From: Tobias Doerffel > > I found these patches on the web not being merged since Jan. Was > there any reason why they shouldn't be accepted? Yes - they needed further work. The approach was wrong because the GPIO does

Re: [ath5k-devel] [PATCH 1/3] ath5k: add support for radio LED

2009-05-20 Thread Tobias Doerffel
Am Mittwoch, 20. Mai 2009 22:29:42 schrieb Bob Copeland: > On Wed, 20 May 2009 22:16:42 +0200, Tobias Doerffel wrote > > > If there's interest, I'll prepare a new patch which represents the > > current state. > > I'm definitely interested in seeing rfkill

Re: [ath5k-devel] [PATCH] ath5k: initial RFKILL support for Atheros 5xxx cards

2009-01-28 Thread Tobias Doerffel
Am Mittwoch, 28. Januar 2009 18:01:22 schrieb Bob Copeland: > On Sat, Jan 24, 2009 at 10:56 AM, Tobias Doerffel > wrote: > > Hi! Here's a quick review, comments inline. Thanks for your comments! I'll deal with them in detail at/after the weekend. Regards, Tobias sig

Re: [ath5k-devel] ath5k: initial RFKILL support for Atheros 5xxx cards

2009-01-26 Thread Tobias Doerffel
Hi, Am Samstag, 24. Januar 2009 16:56:06 schrieb Tobias Doerffel: > as announced here's a reworked patch for RFKILL support. It now features > actually reading RFKILL state from according GPIO. Furthermore it's not > a polled input device anymore (and thus does not depend on po

[ath5k-devel] [PATCH] ath5k: initial RFKILL support for Atheros 5xxx cards

2009-01-24 Thread Tobias Doerffel
Signed-off-by: Tobias Doerffel --- drivers/net/wireless/ath5k/Kconfig |9 ++ drivers/net/wireless/ath5k/Makefile |1 + drivers/net/wireless/ath5k/ath5k.h | 24 +++ drivers/net/wireless/ath5k/base.c | 17 ++- drivers/net/wireless/ath5k/base.h | 25 drivers/net/wireless

[ath5k-devel] ath5k: initial RFKILL support for Atheros 5xxx cards

2009-01-24 Thread Tobias Doerffel
Hi, as announced here's a reworked patch for RFKILL support. It now features actually reading RFKILL state from according GPIO. Furthermore it's not a polled input device anymore (and thus does not depend on polled input device support in kernel anymore) and handles interrupts instead. Everything

Re: [ath5k-devel] [PATCH 2/2] ath5k: initial support for RFKILL with Atheros 5xxx cards

2009-01-23 Thread Tobias Doerffel
Hi, Am Freitag, 9. Januar 2009 22:24:18 schrieb Nick Kossifidis: > Correction: You can get the pin and polarity from EEPROM (check out > eeprom.h) #define AR5K_EEPROM_RFKILL_GPIO_SEL 0x001c > #define AR5K_EEPROM_RFKILL_GPIO_SEL_S 2 > #define AR5K_EEPROM_RFKILL_POLARITY 0x0002 >

Re: [ath5k-devel] [PATCH] ath5k: initial support for RFKILL with Atheros 5xxx cards

2009-01-14 Thread Tobias Doerffel
Am Mittwoch, 14. Januar 2009 20:02:22 schrieb Bob Copeland: > Just a general comment, if you do it like this: > > #ifdef CONFIG_ATH5K_RFKILL > > extern int ath5k_rfkill_init(struct ath5k_softc *sc); > extern void ath5k_rfkill_deinit(struct ath5k_softc *sc); > > #else > > static inline int ath5k_rfk

Re: [ath5k-devel] [PATCH] ath5k: initial support for RFKILL with Atheros 5xxx cards

2009-01-14 Thread Tobias Doerffel
Am Mittwoch, 14. Januar 2009 22:50:22 schrieb Nick Kossifidis: > You still poll for rf kill switch state, in most cases there is an rf > kill switch attached on gpio pin 0 (we can get it from eeprom anyway > but it's 0 in most cases) which generates an interrupt when switched. > Instead of polling

Re: [ath5k-devel] [PATCH 1/2] ath5k: added support for Wireless LED on Samsung NC10

2009-01-13 Thread Tobias Doerffel
Hi, Am Dienstag, 13. Januar 2009 19:08:59 schrieb Bob Copeland: > Which just makes me think that writing gpio 0 actually does rfkill > and it just happens to be tied to the radio LED. I'm quite sure this is true. > Would there be any harm at just setting this up in attach() for all > cards provid

[ath5k-devel] [PATCH] ath5k: initial support for RFKILL with Atheros 5xxx cards

2009-01-13 Thread Tobias Doerffel
Signed-off-by: Tobias Doerffel --- drivers/net/wireless/ath5k/Kconfig | 11 ++ drivers/net/wireless/ath5k/Makefile |1 + drivers/net/wireless/ath5k/ath5k.h | 15 +++ drivers/net/wireless/ath5k/base.c | 34 -- drivers/net/wireless/ath5k/base.h | 19 +++ drivers/net/wireless

[ath5k-devel] [PATCH] ath5k: added support for radio LED

2009-01-13 Thread Tobias Doerffel
Signed-off-by: Tobias Doerffel --- drivers/net/wireless/ath5k/base.c |8 drivers/net/wireless/ath5k/base.h |2 ++ 2 files changed, 10 insertions(+), 0 deletions(-) diff --git a/drivers/net/wireless/ath5k/base.c b/drivers/net/wireless/ath5k/base.c index fdf7733..933c606 100644

[ath5k-devel] [PATCH] ath5k: added support for radio LED on Samsung NC10

2009-01-13 Thread Tobias Doerffel
Signed-off-by: Tobias Doerffel --- drivers/net/wireless/ath5k/base.c | 35 --- include/linux/pci_ids.h |2 ++ 2 files changed, 26 insertions(+), 11 deletions(-) diff --git a/drivers/net/wireless/ath5k/base.c b/drivers/net/wireless/ath5k/base.c

[ath5k-devel] Reworked patchset for LED and RFKILL support

2009-01-13 Thread Tobias Doerffel
As announced, here's another try. Support for radio LED and actual usage has been separated. RFKILL patch is mostly unchanged except for the switch to BSD license. ___ ath5k-devel mailing list ath5k-devel@lists.ath5k.org https://lists.ath5k.org/mailman/

Re: [ath5k-devel] [PATCH 1/2] ath5k: added support for Wireless LED on Samsung NC10

2009-01-13 Thread Tobias Doerffel
Hi, Am Freitag, 9. Januar 2009 16:31:45 schrieb Bob Copeland: > BTW you can turn off rx/tx triggers through sysfs if you don't want to > see the LED blink. I think it should be made working out of the box. As already stated in a previous mail, as soon as the LED is turned off via GPIO, it seems t

Re: [ath5k-devel] [PATCH 1/2] ath5k: added support for Wireless LED on Samsung NC10

2009-01-13 Thread Tobias Doerffel
Hi, Am Freitag, 9. Januar 2009 15:09:58 schrieben Sie: > Why do you want to not register the led as tx/rx ? > Have you tried to change led_on to 0 and see if it's still always off ? Because it's set to off then and this way it disables radio on my card. However I reworked things a bit, updated pa

[ath5k-devel] Splitted patches for LED- and RFKILL support

2009-01-09 Thread Tobias Doerffel
As announced, I splitted my previous patch into two separate patches. Furthermore I fixed license issues and improved coding style. ___ ath5k-devel mailing list ath5k-devel@lists.ath5k.org https://lists.ath5k.org/mailman/listinfo/ath5k-devel

[ath5k-devel] [PATCH 2/2] ath5k: initial support for RFKILL with Atheros 5xxx cards

2009-01-09 Thread Tobias Doerffel
Signed-off-by: Tobias Doerffel --- drivers/net/wireless/ath5k/Kconfig | 10 ++ drivers/net/wireless/ath5k/Makefile |1 + drivers/net/wireless/ath5k/ath5k.h | 15 ++ drivers/net/wireless/ath5k/base.c | 34 -- drivers/net/wireless/ath5k/base.h | 19 +++ drivers/net/wireless

[ath5k-devel] Splitted patches for LED- and RFKILL support

2009-01-09 Thread Tobias Doerffel
GIT: Please enter your email below. GIT: Lines beginning in "GIT: " will be removed. GIT: Consider including an overall diffstat or table of contents GIT: for the patch you are writing. As announced, I splitted my previous patch into two separate patches. Furthermore I fixed license issues and impr

[ath5k-devel] Splitted patches for LED- and RFKILL support

2009-01-09 Thread Tobias Doerffel
As announced, I splitted my previous patch into two separate patches. Furthermore I fixed license issues and improved coding style. Any comments are welcome. ___ ath5k-devel mailing list ath5k-devel@lists.ath5k.org https://lists.ath5k.org/mailman/listinf

[ath5k-devel] [PATCH 1/2] ath5k: added support for Wireless LED on Samsung NC10

2009-01-09 Thread Tobias Doerffel
Signed-off-by: Tobias Doerffel --- drivers/net/wireless/ath5k/base.c | 32 +--- drivers/net/wireless/ath5k/base.h |5 +++-- include/linux/pci_ids.h |2 ++ 3 files changed, 34 insertions(+), 5 deletions(-) diff --git a/drivers/net/wireless/ath5k

[ath5k-devel] [PATCH] ath5k: initial support for rfkill, better LED support

2009-01-08 Thread Tobias Doerffel
clock sleep register diff --git a/drivers/net/wireless/ath5k/rfkill.c b/drivers/net/wireless/ath5k/rfkill.c new file mode 100644 index 000..1754bfa --- /dev/null +++ b/drivers/net/wireless/ath5k/rfkill.c @@ -0,0 +1,242 @@ +/*- + * Copyright (c) 2009 Tobias Doerffel + * + * All rights reserved. + *