Re: [ath5k-devel] [PATCH] ath5k: add support for Dell Vostro A860 LED

2009-12-18 Thread Luis R. Rodriguez
On Fri, Dec 18, 2009 at 09:03:26AM -0800, Shahar Or wrote: > On Fri, Dec 18, 2009 at 5:37 PM, Luis R. Rodriguez > wrote: > >> If we have all the IDs from the INF file, then why do we need this in > >> userspace? Is the list growing? > > > > No, but for other newer hardware/drivers it can likely gr

Re: [ath5k-devel] [PATCH] ath5k: add support for Dell Vostro A860 LED

2009-12-18 Thread Shahar Or
On Fri, Dec 18, 2009 at 5:37 PM, Luis R. Rodriguez wrote: >> If we have all the IDs from the INF file, then why do we need this in >> userspace? Is the list growing? > > No, but for other newer hardware/drivers it can likely grow, so my > comment was more of a generic driver approach to this. Is

Re: [ath5k-devel] [PATCH] ath5k: add support for Dell Vostro A860 LED

2009-12-18 Thread Luis R. Rodriguez
On Fri, Dec 18, 2009 at 07:37:24AM -0800, Luis Rodriguez wrote: > On Fri, Dec 18, 2009 at 3:42 AM, Shahar Or > wrote: > > On Tue, Dec 8, 2009 at 6:30 PM, Luis R. Rodriguez > > wrote: > IIRC this is all mapped in the INF file, I thought I had released an > INF file under the ISC license

Re: [ath5k-devel] [PATCH] ath5k: add support for Dell Vostro A860 LED

2009-12-18 Thread Luis R. Rodriguez
On Fri, Dec 18, 2009 at 3:42 AM, Shahar Or wrote: > On Tue, Dec 8, 2009 at 6:30 PM, Luis R. Rodriguez > wrote: IIRC this is all mapped in the INF file, I thought I had released an INF file under the ISC license but it seems that's not the case, I can try to do that if it helps. Any

Re: [ath5k-devel] [PATCH] ath5k: add support for Dell Vostro A860 LED

2009-12-18 Thread Shahar Or
On Tue, Dec 8, 2009 at 6:30 PM, Luis R. Rodriguez wrote: >>> IIRC this is all mapped in the INF file, I thought I had released an >>> INF file under the ISC license but it seems that's not the case, I can >>> try to do that if it helps. Anyway, if we can move this sort of map to >>> userspace it'd

Re: [ath5k-devel] [PATCH] ath5k: add support for Dell Vostro A860 LED

2009-12-08 Thread Luis R. Rodriguez
On Tue, Dec 8, 2009 at 8:06 AM, John W. Linville wrote: > On Tue, Dec 08, 2009 at 08:01:52AM -0800, Luis R. Rodriguez wrote: >> On Tue, Dec 8, 2009 at 6:57 AM, Bob Copeland wrote: >> > On Mon, Dec 7, 2009 at 4:59 PM, John W. Linville >> > wrote: >> >> On Mon, Dec 07, 2009 at 12:05:54PM +0200, S

Re: [ath5k-devel] [PATCH] ath5k: add support for Dell Vostro A860 LED

2009-12-08 Thread John W. Linville
On Tue, Dec 08, 2009 at 08:01:52AM -0800, Luis R. Rodriguez wrote: > On Tue, Dec 8, 2009 at 6:57 AM, Bob Copeland wrote: > > On Mon, Dec 7, 2009 at 4:59 PM, John W. Linville > > wrote: > >> On Mon, Dec 07, 2009 at 12:05:54PM +0200, Shahar Or wrote: > >>> Adds support for the WiFi activity LED on

Re: [ath5k-devel] [PATCH] ath5k: add support for Dell Vostro A860 LED

2009-12-08 Thread Luis R. Rodriguez
On Tue, Dec 8, 2009 at 6:57 AM, Bob Copeland wrote: > On Mon, Dec 7, 2009 at 4:59 PM, John W. Linville > wrote: >> On Mon, Dec 07, 2009 at 12:05:54PM +0200, Shahar Or wrote: >>> Adds support for the WiFi activity LED on the Dell Vostro A860 laptop. >>> >>> Signed-off-by: Shahar Or >>> --- >>> I

Re: [ath5k-devel] [PATCH] ath5k: add support for Dell Vostro A860 LED

2009-12-08 Thread Bob Copeland
On Mon, Dec 7, 2009 at 4:59 PM, John W. Linville wrote: > On Mon, Dec 07, 2009 at 12:05:54PM +0200, Shahar Or wrote: >> Adds support for the WiFi activity LED on the Dell Vostro A860 laptop. >> >> Signed-off-by: Shahar Or >> --- >> I hope this one is perfect. Thanks for the patch. As for gettin

Re: [ath5k-devel] [PATCH] ath5k: add support for Dell Vostro A860 LED

2009-12-07 Thread John W. Linville
On Mon, Dec 07, 2009 at 12:05:54PM +0200, Shahar Or wrote: > Adds support for the WiFi activity LED on the Dell Vostro A860 laptop. > > Signed-off-by: Shahar Or > --- > I hope this one is perfect. Well, no, it was still quite whitespace damaged. However this time I was able to fix it manually a

Re: [ath5k-devel] [PATCH] ath5k: add support for Dell Vostro A860 LED

2009-12-07 Thread Shahar Or
Adds support for the WiFi activity LED on the Dell Vostro A860 laptop. Signed-off-by: Shahar Or --- I hope this one is perfect. --- drivers/net/wireless/ath/ath5k/led.c.orig 2009-12-03 14:57:20.0 +0200 +++ drivers/net/wireless/ath/ath5k/led.c2009-12-03 14:25:30.0 +0200

Re: [ath5k-devel] [PATCH] ath5k: add support for Dell Vostro A860 LED

2009-12-04 Thread John W. Linville
This patch is whitespace-damaged, you don't have your email address in the Signed-off-by or From lines (the latter being unnecessary anyway), and even after I took the time to fix those issues it still didn't apply. Feel free to try again...thanks. JOhn On Thu, Dec 03, 2009 at 03:07:28PM +0200,

[ath5k-devel] [PATCH] ath5k: add support for Dell Vostro A860 LED

2009-12-03 Thread Shahar Or
From: Shahar Or Adds support for the WiFi activity LED on the Dell Vostro A860 laptop. Signed-off-by: Shahar Or --- --- linux-2.6.31/drivers/net/wireless/ath/ath5k/led.c.orig 2009-12-03 14:57:20.0 +0200 +++ linux-2.6.31/drivers/net/wireless/ath/ath5k/led.c 2009-12-03 14:25:30.0