Re: [ath5k-devel] [PATCH] ath5k: disable all tasklets while resetting

2010-06-15 Thread Bob Copeland
On Tue, Jun 15, 2010 at 01:54:43PM +0900, Bruno Randolf wrote: > if we disable interrupts in the chip (ath5k_hw_set_imr) , the hardware does > not generate any interrupts. so no tasklets will get scheduled... The tasklet might already be scheduled on another CPU: cpu0

Re: [ath5k-devel] [PATCH] ath5k: disable all tasklets while resetting

2010-06-15 Thread Bob Copeland
On Tue, Jun 15, 2010 at 10:07:21AM +0900, Bruno Randolf wrote: > On Mon June 14 2010 20:43:02 you wrote: > > On Mon, Jun 14, 2010 at 10:50:59AM +0900, Bruno Randolf wrote: > > > we disable interrupts right after disabling the tasklets, so they should > > > not be scheduled again, right? actually, w

Re: [ath5k-devel] [PATCH] ath5k: disable all tasklets while resetting

2010-06-15 Thread Bob Copeland
On Mon, Jun 14, 2010 at 10:50:59AM +0900, Bruno Randolf wrote: > we disable interrupts right after disabling the tasklets, so they should not > be scheduled again, right? actually, we should disable interrupts first, and > then disable tasklets... but then it should be safe, no? Disable interrup

Re: [ath5k-devel] [PATCH] ath5k: disable all tasklets while resetting

2010-06-11 Thread Bob Copeland
On Fri, Jun 11, 2010 at 10:21 AM, Bob Copeland wrote: > On Fri, Jun 11, 2010 at 6:41 AM, Johannes Berg > wrote: > >> I have no idea how long a reset can take, but this means that all these >> tasklets will spin while your reset is running if they were scheduled. > > It looks to me like tasklet_ac

Re: [ath5k-devel] [PATCH] ath5k: disable all tasklets while resetting

2010-06-11 Thread Bob Copeland
On Fri, Jun 11, 2010 at 6:41 AM, Johannes Berg wrote: > I have no idea how long a reset can take, but this means that all these > tasklets will spin while your reset is running if they were scheduled. It looks to me like tasklet_action() will bail out when the tasklet has a positive t->count (wh

Re: [ath5k-devel] [PATCH] ath5k: disable all tasklets while resetting

2010-06-11 Thread Johannes Berg
On Fri, 2010-06-11 at 19:12 +0900, Bruno Randolf wrote: > Make sure no tasklets can run concurrently to a reset. > > Signed-off-by: Bruno Randolf > --- > drivers/net/wireless/ath/ath5k/base.c | 12 > 1 files changed, 12 insertions(+), 0 deletions(-) > > diff --git a/drivers/net/w

[ath5k-devel] [PATCH] ath5k: disable all tasklets while resetting

2010-06-11 Thread Bruno Randolf
Make sure no tasklets can run concurrently to a reset. Signed-off-by: Bruno Randolf --- drivers/net/wireless/ath/ath5k/base.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k/base.c b/drivers/net/wireless/ath/ath5k/base.c index