setting up tx descriptors with a rate of zero will put the HW into a mode where
it continously sends noise on the channel, thus blocking the whole channel.
since it is important to avoid this situation, add a WARN_ON in these cases,
even if we hope to never get bad rates from the rate control modul
On 12/12/2007 02:51 AM, Luis R. Rodriguez wrote:
> On Dec 11, 2007 8:46 PM, bruno randolf <[EMAIL PROTECTED]> wrote:
>> On Tuesday 11 December 2007 21:38:25 Jiri Slaby wrote:
+ if (unlikely(tx_tries0 == 0)) {
+ ATH5K_ERR(ah->ah_sc, "zero retries\n");
+
On Dec 11, 2007 8:46 PM, bruno randolf <[EMAIL PROTECTED]> wrote:
> On Tuesday 11 December 2007 21:38:25 Jiri Slaby wrote:
> > > + if (unlikely(tx_tries0 == 0)) {
> > > + ATH5K_ERR(ah->ah_sc, "zero retries\n");
> > > + WARN_ON(1);
> > > return -EINV
On Tuesday 11 December 2007 21:38:25 Jiri Slaby wrote:
> > + if (unlikely(tx_tries0 == 0)) {
> > + ATH5K_ERR(ah->ah_sc, "zero retries\n");
> > + WARN_ON(1);
> > return -EINVAL;
> > + }
>
> I would just do
> if (WARN_ON(tx_tries0 == 0))
>
On Dec 11, 2007 9:07 AM, Bruno Randolf <[EMAIL PROTECTED]> wrote:
> setting up tx descriptors with a rate of zero will put the HW into a mode
> where
> it continously sends noise on the channel, thus blocking the whole channel.
> since it is important to avoid this situation, add a WARN_ON in thes
hi!
i sent this for review here, before i bother the people at linux-wireless with
it, also since my patches usually seem to need two or three rounds of minor
fix ups ;)
this addresses the issue mentioned on the madwifi lists for ath5k.
bruno
On Tuesday 11 December 2007 17:07:41 Bruno Randolf
setting up tx descriptors with a rate of zero will put the HW into a mode where
it continously sends noise on the channel, thus blocking the whole channel.
since it is important to avoid this situation, add a WARN_ON in these cases,
even if we hope to never get bad rates from the rate control modul
