On Tue, Mar 31, 2009 at 8:23 AM, Bob Copeland m...@bobcopeland.com wrote:
Ok - that is a useful data point. Perhaps something to do with the rates
the peer supports; it would help if you could grab a scan next time you
are in the area. Turn off auto-connect to open networks, then do:
Hi
On Tue, Mar 31, 2009 at 09:21:40AM +0530, Dhaval Giani wrote:
Am not sure what the PID controller is, and google gave me a number of
results, which did not make too much sense in the context.
CONFIG_MAC80211_RC_PID -- unfortunately I recall having to jump through
a few config hoops to enable
On Sun, Mar 01, 2009 at 12:08:07AM +0100, Jiri Slaby wrote:
On 15.2.2009 14:47, Bob Copeland wrote:
On Mon, Feb 02, 2009 at 01:27:39PM +0530, Dhaval Giani wrote:
So I finally managed to hit this on 2.6.29-rc3. It is hard to
reproduce, so I hope so much information is enough to give you a good
On Mon, Mar 30, 2009 at 4:59 AM, Dhaval Giani dha...@linux.vnet.ibm.com wrote:
Where is the fix? Is it merged in? I still see this happen on 2.6.29
thanks,
It's in b726604706ad88d8b28bc487e45e710f58cc19ee in Linus' tree, after
2.6.29. You still might get a warning, but this time from the
On Mon, Mar 30, 2009 at 12:58:28PM -0400, Bob Copeland wrote:
On Mon, Mar 30, 2009 at 4:59 AM, Dhaval Giani dha...@linux.vnet.ibm.com
wrote:
Where is the fix? Is it merged in? I still see this happen on 2.6.29
thanks,
It's in b726604706ad88d8b28bc487e45e710f58cc19ee in Linus' tree,
On Mon, Mar 30, 2009 at 1:59 PM, Dhaval Giani dha...@linux.vnet.ibm.com wrote:
ok, so my kernel does hve this patch applied, and this is what I get,
[ cut here ]
WARNING: at include/net/mac80211.h:1956 minstrel_get_rate+0xa1/0x4b9
[mac80211]()
I believe this is
2009/3/23 Bob Copeland m...@bobcopeland.com:
On Tue, Mar 03, 2009 at 06:31:05AM +0200, Nick Kossifidis wrote:
and i don't believe i've ever seen them, so we can warn on them too
and print something like Reserved rate code: %x, also it would be
nice to warn on XR rates (1,2,3,6,7) in case we
On Sun, Mar 22, 2009 at 11:04:19PM -0400, Bob Copeland wrote:
On Tue, Mar 03, 2009 at 06:31:05AM +0200, Nick Kossifidis wrote:
and i don't believe i've ever seen them, so we can warn on them too
and print something like Reserved rate code: %x, also it would be
nice to warn on XR rates
On Mon, Mar 23, 2009 at 01:45:58AM +0100, Stefan Lippers-Hollmann wrote:
Post scriptum: I'm not able to trigger this trace with ath5k/ AR2425.
Okay, well just to be clear ath5k had the same issue (I posted a patch
a couple of weeks ago - I think it got lost and I need to repost it).
But this
On Tue, Mar 03, 2009 at 06:31:05AM +0200, Nick Kossifidis wrote:
and i don't believe i've ever seen them, so we can warn on them too
and print something like Reserved rate code: %x, also it would be
nice to warn on XR rates (1,2,3,6,7) in case we want to debug this in
the future.
Nick, are
Hi
On Mittwoch, 7. Januar 2009, Jiri Slaby wrote:
On 01/07/2009 02:51 PM, Jiri Slaby wrote:
Dhaval Giani wrote:
I see this on current git. Not sure how to reproduce it, has happened on
two random occasions. At both times, I was not connected to a wireless
network, but to wired networks.
On Sunday 15 March 2009 22:27:13 Stefan Lippers-Hollmann wrote:
Hi
On Mittwoch, 7. Januar 2009, Jiri Slaby wrote:
On 01/07/2009 02:51 PM, Jiri Slaby wrote:
Dhaval Giani wrote:
I see this on current git. Not sure how to reproduce it, has happened on
two random occasions. At both
On Sun, Mar 01, 2009 at 12:21:52AM -0500, Pavel Roskin wrote:
I would prefer that we don't hide problems.
If we don't know why we cannot get a valid rate, we should use WARN_ON
and find out why and when it happens. I'm fine with using a bogus rate
with WARN_ON.
So here is at least stage
On 15.2.2009 14:47, Bob Copeland wrote:
On Mon, Feb 02, 2009 at 01:27:39PM +0530, Dhaval Giani wrote:
So I finally managed to hit this on 2.6.29-rc3. It is hard to
reproduce, so I hope so much information is enough to give you a good
guess. This time it hit while trying to connect to an open
On Thu, 2009-02-26 at 21:27 -0500, Bob Copeland wrote:
Actually, I remembered in the dark recesses of my moldering brain
that someone had a lost patch for this a while ago, so I searched
the archives. Pavel, ok to add your s-o-b?
Since my patch was dropped and the new patch was implemented
Make sure we print out a warning when the index is out of bounds,
i.e. even on hw_rix == AR5K_MAX_RATES.
Also change to WARN and print text with the reported hw_rix.
Signed-off-by: Jiri Slaby jirisl...@gmail.com
Cc: Nick Kossifidis mickfl...@gmail.com
Cc: Luis R. Rodriguez lrodrig...@atheros.com
On Thu, Feb 26, 2009 at 6:19 PM, Jiri Slaby jirisl...@gmail.com wrote:
On 27.2.2009 00:15, Bob Copeland wrote:
Speaking of, I think there's another potential oob array access at:
if (rxs.rate_idx= 0 rs.rs_rate ==
sc-curband-bitrates[rxs.rate_idx].hw_value_short)
rxs.flag |=
On 27.2.2009 00:28, Bob Copeland wrote:
hw_to_driver_rix() returns sc-rate_idx[x][y] as an int, and that
array is initialized to (u8)-1 for invalid rates. So, it can
return 255 if the hardware rate index (y) is bad, then the check
rxs.rate_idx= 0 would always be true, right? If it's not a
On Fri, Feb 27, 2009 at 12:32:55AM +0100, Jiri Slaby wrote:
On 27.2.2009 00:28, Bob Copeland wrote:
hw_to_driver_rix() returns sc-rate_idx[x][y] as an int, and that
array is initialized to (u8)-1 for invalid rates. So, it can
return 255 if the hardware rate index (y) is bad, then the check
On Thu, Feb 26, 2009 at 06:27:04PM -0800, Bob Copeland wrote:
On Fri, Feb 27, 2009 at 12:32:55AM +0100, Jiri Slaby wrote:
On 27.2.2009 00:28, Bob Copeland wrote:
hw_to_driver_rix() returns sc-rate_idx[x][y] as an int, and that
array is initialized to (u8)-1 for invalid rates. So, it can
On Thu, Feb 26, 2009 at 06:39:12PM -0800, Luis R. Rodriguez wrote:
Might be worth adding a note why this is the case. Can't we simply avoid
this by checking earlier for the error or simply assigning it an actual
default _good_ hw rate value?
I guess an alternative is to initialize to 0, that
On Mon, Feb 02, 2009 at 01:27:39PM +0530, Dhaval Giani wrote:
So I finally managed to hit this on 2.6.29-rc3. It is hard to
reproduce, so I hope so much information is enough to give you a good
guess. This time it hit while trying to connect to an open network at
the airport.
WARNING: at
22 matches
Mail list logo
