Re: [ath5k-devel] [PATCH 1/2] ath5k: fix wrong per rate target power eeprom reads for AR5K_EEPROM_MODE_11A

2012-08-05 Thread Nick Kossifidis
2012/8/5 Thomas Huehn : > Hi Nick > >> According to EEPROM docs there are 10 calibration piers on all chips >> after 5111 for 11a but some of them are not used and the way to test >> this is if frequency is zero. Now here is a bug in the EEPROM code >> that might result the wrong reads you get, che

Re: [ath5k-devel] [PATCH 1/2] ath5k: fix wrong per rate target power eeprom reads for AR5K_EEPROM_MODE_11A

2012-08-05 Thread Nick Kossifidis
2012/8/5 Thomas Huehn : > Hi Nick > >> According to EEPROM docs there are 10 calibration piers on all chips >> after 5111 for 11a but some of them are not used and the way to test >> this is if frequency is zero. Now here is a bug in the EEPROM code >> that might result the wrong reads you get, che

Re: [ath5k-devel] [PATCH 1/2] ath5k: fix wrong per rate target power eeprom reads for AR5K_EEPROM_MODE_11A

2012-08-05 Thread Thomas Huehn
Hi Nick > According to EEPROM docs there are 10 calibration piers on all chips > after 5111 for 11a but some of them are not used and the way to test > this is if frequency is zero. Now here is a bug in the EEPROM code > that might result the wrong reads you get, check this out: > > on ath5k_eepr

Re: [ath5k-devel] [PATCH 1/2] ath5k: fix wrong per rate target power eeprom reads for AR5K_EEPROM_MODE_11A

2012-08-05 Thread Nick Kossifidis
2012/8/5 Thomas Huehn : > Hi Nick, > >> There is nothing suspicious about it, it's what EEPROM docs say: >> >> a) For 11a mode there are 10 calibration peers > > > As I tested AR5413, AR5414 and AR5213 there are only 8 eeprom lines for > 802.11a that provide valid per rate target power levels. I am

Re: [ath5k-devel] [PATCH 1/2] ath5k: fix wrong per rate target power eeprom reads for AR5K_EEPROM_MODE_11A

2012-08-05 Thread Thomas Huehn
Hi Nick, > There is nothing suspicious about it, it's what EEPROM docs say: > > a) For 11a mode there are 10 calibration peers As I tested AR5413, AR5414 and AR5213 there are only 8 eeprom lines for 802.11a that provide valid per rate target power levels. I am curious if this also holds for ot

Re: [ath5k-devel] [PATCH 1/2] ath5k: fix wrong per rate target power eeprom reads for AR5K_EEPROM_MODE_11A

2012-08-04 Thread Nick Kossifidis
2012/8/4 Thomas Huehn : > Hi all, > > After several experiments on cm9 and dcma82 cards, I figured out that > this patch does not solve the max_power calibration problem as intended. > > The partly reduction to 8 with this: > #define AR5K_EEPROM_N_5GHZ_CHAN 10 > #define AR5K_EEPROM_N_5GHZ_R

Re: [ath5k-devel] [PATCH 1/2] ath5k: fix wrong per rate target power eeprom reads for AR5K_EEPROM_MODE_11A

2012-08-04 Thread Thomas Huehn
Hi all, After several experiments on cm9 and dcma82 cards, I figured out that this patch does not solve the max_power calibration problem as intended. The partly reduction to 8 with this: #define AR5K_EEPROM_N_5GHZ_CHAN 10 #define AR5K_EEPROM_N_5GHZ_RATE_CHAN8 ... creates a wrong pow

Re: [ath5k-devel] [PATCH 1/2] ath5k: fix wrong per rate target power eeprom reads for AR5K_EEPROM_MODE_11A

2012-07-25 Thread Nick Kossifidis
2012/7/26 Thomas Huehn : > Hi Nick, > > [...] > > The calibration data for 802.11a in the standard conform mode should > only consider 8 reads from the eeprom, thats why I introduced this new > define... a "-3" is from my view of readability not as traceable. > Any other non standard mode as you me

Re: [ath5k-devel] [PATCH 1/2] ath5k: fix wrong per rate target power eeprom reads for AR5K_EEPROM_MODE_11A

2012-07-25 Thread Nick Kossifidis
2012/7/25 Felix Fietkau : > On 2012-07-25 8:42 PM, Nick Kossifidis wrote: >> 2012/7/23 Thomas Huehn : >>> This patch reduces the per rate target power eeprom reads for >>> AR5K_EEPROM_MODE_11A from 10 to 8, as there are only 8 valid >>> power curve entries on the eeprom. The former 10 reads lead to

Re: [ath5k-devel] [PATCH 1/2] ath5k: fix wrong per rate target power eeprom reads for AR5K_EEPROM_MODE_11A

2012-07-25 Thread Thomas Huehn
Hi Nick, Nick Kossifidis schrieb: > Thanks for catching this but the bug is elsewhere: > So guess why the last 2 "invalid" power gain values have the same > power levels for all rates ? They are for XR mode (they've put it > there on the eeprom because XR mode also operates at 5GHz) and since >

Re: [ath5k-devel] [PATCH 1/2] ath5k: fix wrong per rate target power eeprom reads for AR5K_EEPROM_MODE_11A

2012-07-25 Thread Nick Kossifidis
2012/7/23 Thomas Huehn : > This patch reduces the per rate target power eeprom reads for > AR5K_EEPROM_MODE_11A from 10 to 8, as there are only 8 valid > power curve entries on the eeprom. The former 10 reads lead to > wrong per rate power limits where rates above 24MBit could be > amplified with t

Re: [ath5k-devel] [PATCH 1/2] ath5k: fix wrong per rate target power eeprom reads for AR5K_EEPROM_MODE_11A

2012-07-25 Thread Felix Fietkau
On 2012-07-25 8:42 PM, Nick Kossifidis wrote: > 2012/7/23 Thomas Huehn : >> This patch reduces the per rate target power eeprom reads for >> AR5K_EEPROM_MODE_11A from 10 to 8, as there are only 8 valid >> power curve entries on the eeprom. The former 10 reads lead to >> wrong per rate power limits

[ath5k-devel] [PATCH 1/2] ath5k: fix wrong per rate target power eeprom reads for AR5K_EEPROM_MODE_11A

2012-07-23 Thread Thomas Huehn
This patch reduces the per rate target power eeprom reads for AR5K_EEPROM_MODE_11A from 10 to 8, as there are only 8 valid power curve entries on the eeprom. The former 10 reads lead to wrong per rate power limits where rates above 24MBit could be amplified with to high distortion leading to bad pe