Re: [ath5k-devel] [PATCH 1/3] ath5k: remove stale function declarations, make some functions static

2010-02-23 Thread Pavel Roskin
On Sat, 2010-02-20 at 10:30 -0500, Bob Copeland wrote: On Fri, Feb 19, 2010 at 6:15 PM, Pavel Roskin pro...@gnu.org wrote: On Fri, 2010-02-19 at 08:44 -0500, John W. Linville wrote: On Thu, Feb 18, 2010 at 08:28:02PM -0500, Pavel Roskin wrote: Any reason not to just remove those functions

Re: [ath5k-devel] [PATCH 1/3] ath5k: remove stale function declarations, make some functions static

2010-02-23 Thread Bob Copeland
On Tue, Feb 23, 2010 at 3:17 PM, Pavel Roskin pro...@gnu.org wrote: Maybe one or two functions are waiting on an API in the stack to be useful (e.g. antenna stuff), but we can always get these routines back from git history if need be. I see you are doing that work already, so please just

Re: [ath5k-devel] [PATCH 1/3] ath5k: remove stale function declarations, make some functions static

2010-02-20 Thread Bob Copeland
On Fri, Feb 19, 2010 at 6:15 PM, Pavel Roskin pro...@gnu.org wrote: On Fri, 2010-02-19 at 08:44 -0500, John W. Linville wrote: On Thu, Feb 18, 2010 at 08:28:02PM -0500, Pavel Roskin wrote: Any reason not to just remove those functions instead of commenting them out? I'm fine either way.  I

Re: [ath5k-devel] [PATCH 1/3] ath5k: remove stale function declarations, make some functions static

2010-02-19 Thread Bob Copeland
On Thu, Feb 18, 2010 at 8:28 PM, Pavel Roskin pro...@gnu.org wrote: Remove all unnecessary function declarations from ath5k.h.  Comment out unused functions.  Remove ath5k_hw_get_tsf32(), which is too trivial to be commented out.  Make functions static if suggested by sparse.  Make

Re: [ath5k-devel] [PATCH 1/3] ath5k: remove stale function declarations, make some functions static

2010-02-19 Thread John W. Linville
On Thu, Feb 18, 2010 at 08:28:02PM -0500, Pavel Roskin wrote: Remove all unnecessary function declarations from ath5k.h. Comment out unused functions. Remove ath5k_hw_get_tsf32(), which is too trivial to be commented out. Make functions static if suggested by sparse. Make ath5k_pm_ops

Re: [ath5k-devel] [PATCH 1/3] ath5k: remove stale function declarations, make some functions static

2010-02-19 Thread Pavel Roskin
On Fri, 2010-02-19 at 08:44 -0500, John W. Linville wrote: On Thu, Feb 18, 2010 at 08:28:02PM -0500, Pavel Roskin wrote: Remove all unnecessary function declarations from ath5k.h. Comment out unused functions. Remove ath5k_hw_get_tsf32(), which is too trivial to be commented out. Make

[ath5k-devel] [PATCH 1/3] ath5k: remove stale function declarations, make some functions static

2010-02-18 Thread Pavel Roskin
Remove all unnecessary function declarations from ath5k.h. Comment out unused functions. Remove ath5k_hw_get_tsf32(), which is too trivial to be commented out. Make functions static if suggested by sparse. Make ath5k_pm_ops static. Signed-off-by: Pavel Roskin pro...@gnu.org ---