Re: [ath5k-devel] [PATCH 1/3] ath5k: rework calibration timer

2010-03-23 Thread Bruno Randolf
On Saturday 20 March 2010 11:35:50 Bruno Randolf wrote: On Saturday 20 March 2010 01:55:49 Luis R. Rodriguez wrote: Can you split this up into different patches, each one doing just one of the above? erm, i thought i already split it up... e.g. the moving into base.c as a separate patch.

Re: [ath5k-devel] [PATCH 1/3] ath5k: rework calibration timer

2010-03-20 Thread Bruno Randolf
On Saturday 20 March 2010 01:55:49 Luis R. Rodriguez wrote: On Fri, Mar 19, 2010 at 03:09:36AM -0700, Bruno Randolf wrote: From: Bruno Randolf b...@einfach.org - we don't need to generate a software interrupt (SWI) just to schedule a tasklet - we can just schedule the tasklet

Re: [ath5k-devel] [PATCH 1/3] ath5k: rework calibration timer

2010-03-19 Thread Bob Copeland
On Fri, Mar 19, 2010 at 07:09:36PM +0900, Bruno Randolf wrote: +++ b/drivers/net/wireless/ath/ath5k/phy.c + if (time_is_before_eq_jiffies(ah-ah_cal_next_full)) { + ah-ah_cal_next_full = jiffies + + msecs_to_jiffies(ATH5K_TUNE_CALIBRATION_INTERVAL_FULL); +

Re: [ath5k-devel] [PATCH 1/3] ath5k: rework calibration timer

2010-03-19 Thread Luis R. Rodriguez
On Fri, Mar 19, 2010 at 03:09:36AM -0700, Bruno Randolf wrote: From: Bruno Randolf b...@einfach.org - we don't need to generate a software interrupt (SWI) just to schedule a tasklet - we can just schedule the tasklet directly. - rename constants, etc to reflect the fact that we don't use