Re: [ath5k-devel] [PATCH 15/19] ath5k: review and add comments for descriptors

2010-06-15 Thread Bob Copeland
On Mon, Jun 14, 2010 at 10:41:47AM +0900, Bruno Randolf wrote: > > Did you check that generated object files are the same? I'm sure they > > are, but it would be an easier way to review than by eye-balling it. > > thats a very good idea! i'm not sure what is the best way to do that > though?...

Re: [ath5k-devel] [PATCH 15/19] ath5k: review and add comments for descriptors

2010-06-11 Thread Bob Copeland
On Fri, Jun 11, 2010 at 5:51 AM, Bruno Randolf wrote: > I carefully reviewed desh.h against the HAL sources. Added comments and made > differences between 5210, 5211 and 5212 more clear by adding _521x to the > defines which are specific to that chipset. Renamed some defines. No > functional > ch

[ath5k-devel] [PATCH 15/19] ath5k: review and add comments for descriptors

2010-06-11 Thread Bruno Randolf
I carefully reviewed desh.h against the HAL sources. Added comments and made differences between 5210, 5211 and 5212 more clear by adding _521x to the defines which are specific to that chipset. Renamed some defines. No functional changes. Signed-off-by: Bruno Randolf --- drivers/net/wireless/at