Re: [ath5k-devel] [PATCH 2/2] mac80211: Remove control.sta from struct ieee80211_tx_info and restructure tx-path

2012-07-17 Thread Johannes Berg
> Virtual box did the job and I found 3 drivers that somehow did not > complain in my OpenWRT build env... thx for not playing :)... v3 is out. See, that's why I don't want to play the game -- I could've gone back and forth with you for like a week over multiple compile failures :-) > I used wir

Re: [ath5k-devel] [PATCH 2/2] mac80211: Remove control.sta from struct ieee80211_tx_info and restructure tx-path

2012-07-17 Thread Thomas Huehn
Hi Johannes, > No, I'm not going to play that game. Make sure it compiles on > wireless-next. Virtual box did the job and I found 3 drivers that somehow did not complain in my OpenWRT build env... thx for not playing :)... v3 is out. I used wireless-testing and not -next,as in -next the necessa

Re: [ath5k-devel] [PATCH 2/2] mac80211: Remove control.sta from struct ieee80211_tx_info and restructure tx-path

2012-07-17 Thread Johannes Berg
On Tue, 2012-07-17 at 14:57 +0200, Thomas Huehn wrote: > > Ok first of all, please actually compile the tree after your changes. It > > doesn't. When it does, please fix > > I always do compile the compat-wireless-tree after changes I introduce, > and it compiles without errors in the case of thi

Re: [ath5k-devel] [PATCH 2/2] mac80211: Remove control.sta from struct ieee80211_tx_info and restructure tx-path

2012-07-17 Thread Thomas Huehn
Hi Johannes, Johannes Berg schrieb: > Ok first of all, please actually compile the tree after your changes. It > doesn't. When it does, please fix I always do compile the compat-wireless-tree after changes I introduce, and it compiles without errors in the case of this mac80211:sta-remove patch.

Re: [ath5k-devel] [PATCH 2/2] mac80211: Remove control.sta from struct ieee80211_tx_info and restructure tx-path

2012-07-17 Thread Johannes Berg
Ok first of all, please actually compile the tree after your changes. It doesn't. When it does, please fix 1) line length in the commit log should be < 72 chars 2) indentation in mac80211.h 3) removal of an important comment in mac80211.h that I pointed out in previous review > The tx-path

Re: [ath5k-devel] [PATCH 2/2] mac80211: Remove control.sta from struct ieee80211_tx_info and restructure tx-path

2012-07-14 Thread Luciano Coelho
On Fri, 2012-07-13 at 20:52 +0200, Thomas Huehn wrote: > The pointer control.sta is removed from ieee80211_tx_info to free up > sufficient > memory in SKB_CB on the tx-path to enable new annotations per data packet e.g. > support of upcoming Transmit Power Control (TPC). > Now the control.sta poin

Re: [ath5k-devel] [PATCH 2/2] mac80211: Remove control.sta from struct ieee80211_tx_info and restructure tx-path

2012-07-14 Thread Arend van Spriel
On 07/13/2012 08:52 PM, Thomas Huehn wrote: > The pointer control.sta is removed from ieee80211_tx_info to free up > sufficient > memory in SKB_CB on the tx-path to enable new annotations per data packet e.g. > support of upcoming Transmit Power Control (TPC). > Now the control.sta pointer is put

[ath5k-devel] [PATCH 2/2] mac80211: Remove control.sta from struct ieee80211_tx_info and restructure tx-path

2012-07-13 Thread Thomas Huehn
The pointer control.sta is removed from ieee80211_tx_info to free up sufficient memory in SKB_CB on the tx-path to enable new annotations per data packet e.g. support of upcoming Transmit Power Control (TPC). Now the control.sta pointer is put on the stack where it is passed as function parameter t